From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DBAC3DB64B for ; Fri, 24 Apr 2026 14:08:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777039692; cv=none; b=LCCDJTt1YtzInYuimiDlK5ICMQ+MWAFbOwFajg7R8TPYi4vSjstG0D3oqLazGP4B/9LqaKuRrSmYA9WG03hEJ5qRsxDHSOo8pAwYFaWLZFBALUv26Yk9micSVIFInnKVPD2N6geDKs0PBgUzMl99AvYoYI1OtvBZviPvLfafCLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777039692; c=relaxed/simple; bh=eqsoHMIOOabBLTi9Vt6IUu2GMKr3JRX0N3iuQ2xWg/Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iVnLLZJ83DqWIUdQ+vLQOFMgfMcz4XImcGn6pWwlTG8p5q1y4AStjT5W96Zy4GghPtCGSiDiUhapPA2pMt3fdBSwiexFjaJbSTURGCtzl5AOpm/RWmnYjrxx1Q61hZkP3uGNuMSDS5icBsJIAVf0Ma95EHq687UWgvbwQYV2WJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fxXR2Fm9; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fxXR2Fm9" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-82418b0178cso4968974b3a.1 for ; Fri, 24 Apr 2026 07:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777039690; x=1777644490; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=H8i0Gpepc+zFweLSIN4Cg/R5ifn3iGWjVwE5PfxJUKQ=; b=fxXR2Fm9GUuCDlkvZ98tIX4UJXqKIU0OM7457fN6WTnN91K8CevFZkUZCywzcAN/QX 7Hw1K+LSk/U5CWugbAjXXRnyqwjaRmhJFh4dmL1X2TPe0bcNalHnhioa5lcOOY3l5ze/ 3v/+P+Ejl+l9LZE2y+cAt/X18v3HxeKAtAOMXjP+i8dg1BJEIeFSDVTxMEXvuHJU7LQV Ms0bdLSIOPOimpoqPXuHk8iydvltF8Sq0hDq7/MIskvXbJNIYdEZ4da0cKBqmehtMU8H E1JqRBI1HQwwhi2fmz68tdBjsKMH6LXAGE5D1rkPdddQkdQP8XnM3kf6vHuEbTguU+5a e29w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777039690; x=1777644490; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H8i0Gpepc+zFweLSIN4Cg/R5ifn3iGWjVwE5PfxJUKQ=; b=JR0gDsQJtBhKl2HJZMMKj64pDKspwQ3f5aeVqLyRaXM7y/XVG2a5ZQDDfPSDBtjpLx jmpULC0NGgV0axdbm/TpcykBo2f0dF0wV7sj+K4y5AFbKIbhFaM+vYAFc1ZxSksOOnwk jCkjOw+QSo/RLWWkC4GFGBwaayegbd9V0E8Q1KJVZwsU8L6EBsw10Kpwmq0gmBt+/Pvr bAFOSVRGAWtKU+MczLAuzLbncR/2cg2bDu9Kw/wI+cMHWsTtF5qaBgV0x3XNexYxvWMH Xm0+nIcdB9+5u7BhPqYoo7YkS8m//zaJruNa+j2u0pbZHxOq6qEWkWN/Fk9WQBF0MAsI XJ1g== X-Forwarded-Encrypted: i=1; AFNElJ/AX2qQs8wJayK+nfE8dQs5ardDx1Zs6uKjbadmG0GsSotGQpJ8XBW9e1YKMNnYwcGkGmI2IPFlSOj62g==@vger.kernel.org X-Gm-Message-State: AOJu0YzN9QaiZO9PUy69VS/ezJsTssENU5HD2HDUOEw9WDUqLEcQS+4f nifTIWcuxY+mRcaSLOGgfMrBJyhScaWVqsmh34Tih7hUq9ChfoPztbM= X-Gm-Gg: AeBDieu2M6a0bgwzAN37LfwVmK6sX59RKRAc59/D+2DjdqVaDpC1lUg/ZNavOPDGBs8 jR0O7ZsbEy2ASxNhIlC2LLEDEDI1xPjMp8x5tjY4sJAFPfeUnRAyuNPy5PAyaLabhxRmdsrlqx/ zB2SulW94fyYW259OMMGXmMnNT4KNQQSYhDTdPnSRDtdOMliGQLOIPFzbVAJj7T7zAqrto1YyfC scBl2y/YwjONfBakJwjfiwzq7McfoDrGsgLuqL6cLXa+WUe5Q7MT9vak4/2axow8IDDdtWsxyY+ jC/jS4rMPeviFutEK2U17V4KpCC0zQm8VYEkohrV4xZL882Q9Hvzl+X0YR/2JFlyJKSfdGtfB2P dDCsc15ii1/x0s3Rep+buoJqTfPj6YBcj6ZpEXOmODfXMKUnngHjPHG3B/dBwcHCi7PoflEAE0b MrAZWShXEiz9IXKTj1xYNvkHXT+6VmJvTkVC5qzgopbnPp81dVd9+LlBZdZASTLQHsmeSzPnuKK k4S+zgr0nPtUDA= X-Received: by 2002:a05:6a00:2d03:b0:82c:ebae:3cb with SMTP id d2e1a72fcca58-82f8c91924dmr33416449b3a.43.1777039690269; Fri, 24 Apr 2026 07:08:10 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9d9a1csm25404664b3a.20.2026.04.24.07.08.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 24 Apr 2026 07:08:09 -0700 (PDT) From: Myeonghun Pak To: Benjamin Mugnier , Sylvain Petinot , Sakari Ailus , Mauro Carvalho Chehab Cc: Myeonghun Pak , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] media: i2c: vd56g3: Clean up subdev state on probe failure Date: Fri, 24 Apr 2026 23:07:41 +0900 Message-ID: <20260424140804.31568-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit vd56g3_subdev_init() calls v4l2_subdev_init_finalize(), which allocates the subdev active state and requires v4l2_subdev_cleanup() to release it. If vd56g3_update_controls() fails after finalize succeeds, the probe error path currently skips v4l2_subdev_cleanup() and returns an error. The driver .remove() callback is not called after a failed probe, so the active state is leaked. Route this error through a subdev cleanup label before freeing the control handler and media entity. Fixes: 87aa97fc3157 ("media: i2c: Add driver for ST VD56G3 camera sensor") Cc: stable@vger.kernel.org Signed-off-by: Myeonghun Pak --- drivers/media/i2c/vd56g3.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/vd56g3.c b/drivers/media/i2c/vd56g3.c index 157acea9e2..43f792288a 100644 --- a/drivers/media/i2c/vd56g3.c +++ b/drivers/media/i2c/vd56g3.c @@ -1427,11 +1427,14 @@ static int vd56g3_subdev_init(struct vd56g3 *sensor) v4l2_subdev_unlock_state(state); if (ret) { dev_err(sensor->dev, "Controls update failed: %d\n", ret); - goto err_ctrls; + goto err_subdev; } return 0; +err_subdev: + v4l2_subdev_cleanup(&sensor->sd); + err_ctrls: v4l2_ctrl_handler_free(sensor->sd.ctrl_handler); -- 2.50.1