From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB622D531; Fri, 24 Apr 2026 23:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777071623; cv=none; b=f62ug8s+E1leUed8kBls925gjy2HY6oriIzKnBXlKPBJkTG2U0Kd9HJyoJ5Z4rqzt2gj+P9y8DpZHwZ17JWFvz+aUnie2TrYlLIdZDoU0CaROM58lUZcSTwb7ujjLMUBKejbB1YgDuRAmJ42iBB6sDavWlLpK49x+SBrIPVreQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777071623; c=relaxed/simple; bh=mXeWIc4bSwDCNBcdRGufU1M9fLVnzL1D1gJleQSCgmQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j8CO0K3+uN14+8wa5VdK4IP/i3Q8K1c8K49eWFFZb14KNhTO9GBuNx+ERylIM7GUzE2QeDkmepRRyFfFbsGCJKJMFuAehonrCSFwu9d8S+n5d2hysJYowZeK3xuzB32ve1fSXP94+vn0dMN+Vc+pHd91L+Rs26eboI0wvVHIfAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=FFci2RcD; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="FFci2RcD" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 59E6C986; Sat, 25 Apr 2026 00:58:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1777071519; bh=mXeWIc4bSwDCNBcdRGufU1M9fLVnzL1D1gJleQSCgmQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FFci2RcD/qwzOICb/XJNhBJMrszBBdEiF2PyvpZYQfELPjQ992/wd1Xq+LB4T+F+a UAj9P3s909RycxhJp4fW+3EBpbIxcOA2C/2kXmTl51mqqbRKLFXHhfQRuik4aavhI3 Tf7H1cNcUMW50IzgCaiIUOL90GIg1VQyVer2BrgU= Date: Sat, 25 Apr 2026 02:00:17 +0300 From: Laurent Pinchart To: Paul Elder Cc: Xu Hongfei , michael.riesch@collabora.com, stefan.klug@ideasonboard.com, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Heiko Stuebner Subject: Re: [RFC PATCH 2/5] arm64: dts: rockchip: add ISP nodes to rk3588 Message-ID: <20260424230017.GD3219146@killaraus.ideasonboard.com> References: <20260424175853.638202-1-paul.elder@ideasonboard.com> <20260424175853.638202-3-paul.elder@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260424175853.638202-3-paul.elder@ideasonboard.com> Hi Paul, Thank you for the patch. On Sat, Apr 25, 2026 at 02:58:47AM +0900, Paul Elder wrote: > From: Xu Hongfei > > Add device tree nodes for the ISP and their iommus on the RK3588. > > Signed-off-by: Xu Hongfei > Signed-off-by: Paul Elder > --- > arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi > index 8b98e5c3cc8b..607b03d55dfd 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi > @@ -3535,6 +3535,66 @@ gpio4: gpio@fec50000 { > #interrupt-cells = <2>; > }; > }; > + > + isp0: isp@fdcb0000 { > + compatible = "rockchip,rk3588-isp"; > + reg = <0x0 0xfdcb0000 0x0 0x7f00>; > + interrupts = , > + , > + ; > + interrupt-names = "isp_irq", "mi_irq"; > + clocks = <&cru ACLK_ISP0>, <&cru HCLK_ISP0>, > + <&cru CLK_ISP0_CORE>, <&cru CLK_ISP0_CORE_MARVIN>, > + <&cru CLK_ISP0_CORE_VICAP>; > + clock-names = "aclk", "hclk", "clk_core", > + "clk_core_marvin", "clk_core_vicap"; > + power-domains = <&power RK3588_PD_VI>; > + iommus = <&isp0_mmu>; > + status = "disabled"; > + }; > + > + isp0_mmu: iommu@fdcb7f00 { > + compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu"; > + reg = <0x0 0xfdcb7f00 0x0 0x100>; > + interrupts = ; > + interrupt-names = "isp0_mmu"; I don't think interrupt-names is needed. Same for the second IOMMU. > + clocks = <&cru ACLK_ISP0>, <&cru HCLK_ISP0>; > + clock-names = "aclk", "iface"; > + power-domains = <&power RK3588_PD_VI>; > + #iommu-cells = <0>; > + rockchip,disable-mmu-reset; > + status = "disabled"; > + }; > + > + isp1: isp@fdcc0000 { > + compatible = "rockchip,rk3588-isp"; > + reg = <0x0 0xfdcc0000 0x0 0x7f00>; > + interrupts = , > + , > + ; > + interrupt-names = "isp_irq", "mi_irq"; > + clocks = <&cru ACLK_ISP1>, <&cru HCLK_ISP1>, > + <&cru CLK_ISP1_CORE>, <&cru CLK_ISP1_CORE_MARVIN>, > + <&cru CLK_ISP1_CORE_VICAP>; > + clock-names = "aclk", "hclk", "clk_core", > + "clk_core_marvin", "clk_core_vicap"; > + power-domains = <&power RK3588_PD_ISP1>; > + iommus = <&isp1_mmu>; > + status = "disabled"; > + }; > + > + isp1_mmu: iommu@fdcc7f00 { > + compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu"; > + reg = <0x0 0xfdcc7f00 0x0 0x100>; > + interrupts = ; > + interrupt-names = "isp1_mmu"; > + clocks = <&cru ACLK_ISP1>, <&cru HCLK_ISP1>; > + clock-names = "aclk", "iface"; > + power-domains = <&power RK3588_PD_ISP1>; > + #iommu-cells = <0>; > + rockchip,disable-mmu-reset; > + status = "disabled"; > + }; > }; > > #include "rk3588-base-pinctrl.dtsi" -- Regards, Laurent Pinchart