From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0831739A049 for ; Tue, 28 Apr 2026 07:14:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777360497; cv=none; b=h36ygrePMbvVDZ3Zvb1WFognWFepquzVsranSXe4gwtiSOXh7nQXWXruN0zylX9y6WETUbnO5XFDjVYG9pdA1MTNIYGHgbYrcl7J7UsRtWxyRkOyGnOUz4oM+n5b+gfqJRbqOldn1FfR2Uod42QSnzghu3jZPAQj1jy0XWFBpGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777360497; c=relaxed/simple; bh=5IAbPV7GjXJcmCemjnRj6zkNyiWGO0VFknnZB5qbFJ4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=maoRcRwQOvGZ4mk956B9KemEdq4AwJRhrLVHOocarj0vv3l/0XptxaeaJyLxuD+PmxbzwTfv9zIiAA3N1llSToTXDHSpCjozWEownr5HGAQVYB5tQvcwbJJRIKKDpR1l5PZ8SWHJsRat362HthT6RXye6/+8cZ5EFpQWoaW4qAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pJjAvay/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Dfv3bTTg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pJjAvay/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Dfv3bTTg" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63S4EWqM429032 for ; Tue, 28 Apr 2026 07:14:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=mRkuhVxeIvIJUI8nAiBY// YMf+HTmpsVYFRpYf2MAlg=; b=pJjAvay/xLiY3dQ6EH9jnVAieHGekhHfy2jvzk 63Yd0ZJxlEx37Cisj/ocdyjNeELKC8iIx51bkbsIgp1kKhJue0bP7Xm9RFiI469J l7GSKkI54G9cotUxMroObTW3FB3zIZqErX2XUIz13Hm1MAApiCl4vi8g+xa961z9 tdGEsmooAMOS49xvjQtGxR/oFuTxs1OZONLa2cs+nfHV48brSkcaTCK89dYYDecD PfGdhs6DivS8DYrXUzIr0lR4u/DIdJV0BhTeV1B0NbFBlaUuaEu2ORWfM10/rH+v Bksyfxg4269/ttjHjuT2ONUhc6N/dvJcz1AKujcoLO3UHMQQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dt7x33ucj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Apr 2026 07:14:54 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82cf8dcd079so7263938b3a.1 for ; Tue, 28 Apr 2026 00:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777360493; x=1777965293; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=mRkuhVxeIvIJUI8nAiBY//YMf+HTmpsVYFRpYf2MAlg=; b=Dfv3bTTgLPHcN7sPRdW4NyN05yS7TDxQVaqzitEnklUOeSjeOLm/sPSQc81k8TQWXR 5qXAweE+pvBijwBBYLbHAtSjaNWG1qgFB1JikpF0ioOGN9pAqWJ0fKdYGsvUKpOYGyZQ qKBQxytaUi6W5WrmXv8HvFrusoa0762SBI2ITpW1BiwNvuZh96YEEEOt1rmdn+ULpkdh Ta8mtB+gDJjVAfZGg9LRhYM+bBa7Ss2XWVa69jmHrJY/jcc6U9NvB21A7CfWc66hgP/O z8FCJBLkWW3GlPAMk+x11UEkeEnxD079neq6dU/Uec7AG7a4s9YXjfe64fUd1I7oOkRi IY/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777360493; x=1777965293; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mRkuhVxeIvIJUI8nAiBY//YMf+HTmpsVYFRpYf2MAlg=; b=IRIUCAPEF3tn+YONe0dEL+xdZsQJLRp6YjEFkQCj+vq6r5B+ce06hI4HgBrMHfbMNi 4L3AZisf8joBBpMe3oKdrscUjwl3JOHr2p1oUaF3kpE89PRXNj//5ByhoPSIiOIozYJH XFpLV0GiMnkduTumbwop9QANGFsH3gW8jcfkKtkf+JI5nxyATLy+bA1irYDBRaoGfqve Yn5PXBEkEg5KB9L7Ih/mnXid+a66UtvmEVHNmP0UTaZ6+7N1vMK6a9d1obXCZnUmvaMP MaHOfR8d4iTwk03ReATO9M/pNxoZ8NV62/bJSc4kk/NRPEjHBYPab7KBXRmlWi3Rs3QR uzaA== X-Gm-Message-State: AOJu0YxOvDHZDz38hqrWRQD/CMtVZ+ofNWzimDshlZ2rfjoekX67Pxvl c/6+Hk920Ez/s3x5zJWiaQZs3Zi8r8t0JBsHRcqgToUpeX75IUdGX9N5BH05A4A9CIH56Ro4ncu LxDecTefSxEJbDh9JCx8IcDY7eRY6Iy2EKh5xtz/pRbrQ5YBs4uFJE7s+5xqpuH30yw== X-Gm-Gg: AeBDiesIV7C4zEXNg6VRZhagb6dmd2sJHeFNikN0rOs4oFSCgHEV2XHjwKEjpmD3E+U HlMiOjY/VhbU1sQwvMSiIfw4jnaY/3rosaM/njZw0Sc/+vXSqEQ7SWW+xLEEjzJrbxP3x1NLCQV RnfIopKi0BpNg2utq6MpfaHlzsmnbUqQ2Z6STQr2M2T4Woi7qJol/BD0Qx5uhdZoga/zP/YFel6 Pb8+n6uSOzJY7v46dlGKghAQ8/PlESMqWWvDjAt5HC+F6F+lb/ix4Bb53VH+L77io/23jeU4Kdn 0seJkLdGT8fCcGAVX7A8ywNMzpbHcHrbjDKwLSa3mwk+fEAQ0fc+Z4iHSFMJNPFn6ZVIk2Q4hbD vvb6k8M90bmaUcVvQYwqXyxE9KdeKj34V0JyIp1/YL7SxjN31W/gNouIoKNiQYjU= X-Received: by 2002:a05:6a00:2990:b0:82a:6461:6d1e with SMTP id d2e1a72fcca58-834ddc7705bmr1787113b3a.46.1777360493387; Tue, 28 Apr 2026 00:14:53 -0700 (PDT) X-Received: by 2002:a05:6a00:2990:b0:82a:6461:6d1e with SMTP id d2e1a72fcca58-834ddc7705bmr1787081b3a.46.1777360492863; Tue, 28 Apr 2026 00:14:52 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-834daf5705fsm1980977b3a.42.2026.04.28.00.14.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 00:14:52 -0700 (PDT) From: Sachin Kumar Garg Date: Tue, 28 Apr 2026 12:44:43 +0530 Subject: [PATCH] Add support for multi_slice in iris encoder Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260428-iris_multi_slice-v1-1-92c327619ebf@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAGJe8GkC/x3MSQqAMBAF0atIrw2Y4HwVkSCx1Q9OpFUE8e4Gl 29R9ZCwBwvV0UOeLwi2NUDHEbmpW0dW6IPJJCZPUpMpeIhdzvmAlRmOVand0Ls801VVUMh2zwP uf9m07/sBGeROo2IAAAA= X-Change-ID: 20260425-iris_multi_slice-81cfdc651997 To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Kumar Garg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777360489; l=10274; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=5IAbPV7GjXJcmCemjnRj6zkNyiWGO0VFknnZB5qbFJ4=; b=VvhmKb2UQTG9AjmACJwhVlRM6ueOIKj6vl2+bWMsPlsaq71j2JFjP4HWAljISkd0GKICmjJr6 JOJXiMvNfeaADGeskDFlmSkzfnZs8L6muDk3iNDAmhsFfJLnr2EAWaW X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI4MDA2NSBTYWx0ZWRfX66oTr7WXtc/+ KKwbDynJ8lSbdWFk8lLhOs/uMQu0lAMi+g2O6pixlwaw6YvjjzpkVPk0kzK1HT9oqVhrewhAjr5 1OlhES/Oni8kKB8m0CNn1oNLe5SmBn6czeqXrvO8+n4W4EdPaQiRTHOuKj4q3qPW8Vz3DPvmj6k wwyzjbY5XfX3bC/S31ctHk/3AQxasQdQXTOHAwThE5aoiJK7Knwm8Q9UnXX0+qCeSUS13fcvVMD lA8Ag/+q6jfkXQWUlOxiyI/fD6MYyLvb86d28megeWqj/mgXdzx1WIDpy77Mwz4ptKaEMK2JBph jseNaqTUQehT3k+bTAFpJiz6rcr86X7/HD64xF0pj29pcDqfqVhQHgG3/ASypCiC2+utFy8mOFN yDc7WJqVZcvshfkbmTSStpdvQzwwPrXaPDzbj5daNPD23PT7M/505tzNvxMgX+4xwZdI/IV30EU 4mtkiAJxvsh24i62XpQ== X-Proofpoint-ORIG-GUID: 2B474rgnFlzd5l1P-v3iK1dTxX5Ltbqw X-Authority-Analysis: v=2.4 cv=AJEsYPsu c=1 sm=1 tr=0 ts=69f05e6e cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=ea3OJAFQNpsezTeQoQYA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: 2B474rgnFlzd5l1P-v3iK1dTxX5Ltbqw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-28_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604280065 Add multi-slice encoding support with MAX_MB and MAX_BYTES modes. Clients can enable slice mode using V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE control and configure slice size via V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB or V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BYTES controls. Signed-off-by: Sachin Kumar Garg --- This series adds the support for multi slice feature in the Qualcomm Iris driver. Multi-slice mode allows encoding a single frame into multiple slices, which can improve error resilience and enable parallel processing. The feature supports two slice modes: - MAX_MB mode: Slices are created based on macroblock count, controlled via V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB - MAX_BYTES mode: Slices are created based on byte size, controlled via V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BYTES Clients can enable slice mode using the V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE control. This series adds multi-slice support for HFI Gen2 targets (SM8550 and later). Support for HFI Gen1 targets will be added in a follow-up series. This Patch has been verified with GST level. Command used: gst-launch-1.0 -v videotestsrc ! video/x-raw,format=NV12, \ width=1280,height=720,framerate=30/1 ! v4l2h264enc output-io-mode=4 | capture-io-mode=4 extra-controls="controls,video_bitrate_mode=1, \ slice_partitioning_method=1,number_of_mbs_in_a_slice=460;" \ ! filesink location=/opt/test_enc.h264 --- drivers/media/platform/qcom/iris/iris_ctrls.c | 89 ++++++++++++++++++++++ drivers/media/platform/qcom/iris/iris_ctrls.h | 1 + .../platform/qcom/iris/iris_hfi_gen2_defines.h | 2 + .../platform/qcom/iris/iris_platform_common.h | 3 + .../media/platform/qcom/iris/iris_platform_gen2.c | 31 ++++++++ 5 files changed, 126 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c index 3cec957580f5..52b92241e7f0 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -13,6 +13,15 @@ #define CABAC_MAX_BITRATE 160000000 #define CAVLC_MAX_BITRATE 220000000 +#define MAX_SLICES_PER_FRAME 10 +#define MAX_SLICES_FRAME_RATE 60 +#define MAX_MB_SLICE_WIDTH 4096 +#define MAX_MB_SLICE_HEIGHT 2160 +#define MAX_BYTES_SLICE_WIDTH 1920 +#define MAX_BYTES_SLICE_HEIGHT 1088 +#define MIN_HEVC_SLICE_WIDTH 384 +#define MIN_AVC_SLICE_WIDTH 192 +#define MIN_SLICE_HEIGHT 128 static inline bool iris_valid_cap_id(enum platform_inst_fw_cap_type cap_id) { @@ -112,6 +121,12 @@ static enum platform_inst_fw_cap_type iris_get_cap_id(u32 id) return IR_TYPE; case V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD: return IR_PERIOD; + case V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE: + return SLICE_MODE; + case V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BYTES: + return SLICE_MAX_BYTES; + case V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB: + return SLICE_MAX_MB; default: return INST_FW_CAP_MAX; } @@ -213,6 +228,12 @@ static u32 iris_get_v4l2_id(enum platform_inst_fw_cap_type cap_id) return V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE; case IR_PERIOD: return V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD; + case SLICE_MODE: + return V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE; + case SLICE_MAX_BYTES: + return V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BYTES; + case SLICE_MAX_MB: + return V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB; default: return 0; } @@ -996,6 +1017,74 @@ int iris_set_ir_period(struct iris_inst *inst, enum platform_inst_fw_cap_type ca &ir_period, sizeof(u32)); } +int iris_set_slice_count(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id) +{ + const struct iris_hfi_command_ops *hfi_ops = inst->core->hfi_ops; + u32 slice_mode = inst->fw_caps[SLICE_MODE].value; + u32 bitrate = inst->fw_caps[BITRATE].value; + u32 rc_type = inst->fw_caps[BITRATE_MODE].value; + u32 fps = inst->frame_rate; + u32 output_width = inst->fmt_dst->fmt.pix_mp.width; + u32 output_height = inst->fmt_dst->fmt.pix_mp.height; + u32 mbpf = NUM_MBS_PER_FRAME(output_height, output_width); + u32 max_width, max_height, min_width, min_height; + u32 max_avg_slicesize, hfi_value, hfi_id; + + if (slice_mode == V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_SINGLE) { + dev_dbg(inst->core->dev, "slice mode is: %u, ignore setting to fw\n", slice_mode); + return 0; + } + if (!fps) { + dev_err(inst->core->dev, "Invalid frame rate %d\n", fps); + return -EINVAL; + } + if (fps > MAX_SLICES_FRAME_RATE || + (rc_type != HFI_RC_OFF && rc_type != HFI_RC_CBR_CFR && + rc_type != HFI_RC_CBR_VFR)) { + dev_err(inst->core->dev, "slice unsupported, fps: %u, rc_type: %#x\n", + fps, rc_type); + return -EINVAL; + } + + max_width = (slice_mode == V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB) ? + MAX_MB_SLICE_WIDTH : MAX_BYTES_SLICE_WIDTH; + max_height = (slice_mode == V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB) ? + MAX_MB_SLICE_HEIGHT : MAX_BYTES_SLICE_HEIGHT; + min_width = (inst->codec == V4L2_PIX_FMT_HEVC) ? + MIN_HEVC_SLICE_WIDTH : MIN_AVC_SLICE_WIDTH; + min_height = MIN_SLICE_HEIGHT; + + if (output_width < min_width || output_height < min_height || + output_width > max_width || output_height > max_height) { + dev_err(inst->core->dev, "slice unsupported, codec: %#x wxh: [%dx%d]\n", + inst->codec, output_width, output_height); + return -EINVAL; + } + + if (slice_mode == V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB) { + hfi_value = inst->fw_caps[SLICE_MAX_MB].value; + hfi_value = max(hfi_value, mbpf / MAX_SLICES_PER_FRAME); + if (inst->codec == V4L2_PIX_FMT_HEVC) + hfi_value = (hfi_value + 3) / 4; + hfi_id = inst->fw_caps[SLICE_MAX_MB].hfi_id; + } else if (slice_mode == V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_BYTES) { + hfi_value = inst->fw_caps[SLICE_MAX_BYTES].value; + if (rc_type != HFI_RC_OFF) { + max_avg_slicesize = ((bitrate / fps) / 8) / MAX_SLICES_PER_FRAME; + hfi_value = max(hfi_value, max_avg_slicesize); + } + hfi_id = inst->fw_caps[SLICE_MAX_BYTES].hfi_id; + } else { + return -EINVAL; + } + + return hfi_ops->session_set_property(inst, hfi_id, + HFI_HOST_FLAGS_NONE, + iris_get_port_info(inst, cap_id), + HFI_PAYLOAD_U32, + &hfi_value, sizeof(u32)); +} + int iris_set_properties(struct iris_inst *inst, u32 plane) { const struct iris_hfi_command_ops *hfi_ops = inst->core->hfi_ops; diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.h b/drivers/media/platform/qcom/iris/iris_ctrls.h index 9518803577bc..5280ee00d9a0 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.h +++ b/drivers/media/platform/qcom/iris/iris_ctrls.h @@ -35,6 +35,7 @@ int iris_set_qp_range(struct iris_inst *inst, enum platform_inst_fw_cap_type cap int iris_set_rotation(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id); int iris_set_flip(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id); int iris_set_ir_period(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id); +int iris_set_slice_count(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id); int iris_set_properties(struct iris_inst *inst, u32 plane); #endif diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h b/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h index cecf771c55dd..8a27f246e114 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h @@ -71,6 +71,8 @@ enum hfi_rate_control { #define HFI_PROP_MIN_QP_PACKED 0x0300012f #define HFI_PROP_MAX_QP_PACKED 0x03000130 #define HFI_PROP_IR_RANDOM_PERIOD 0x03000131 +#define HFI_PROP_MULTI_SLICE_MB_COUNT 0x03000132 +#define HFI_PROP_MULTI_SLICE_BYTES_COUNT 0x03000133 #define HFI_PROP_TOTAL_BITRATE 0x0300013b #define HFI_PROP_MAX_GOP_FRAMES 0x03000146 #define HFI_PROP_MAX_B_FRAMES 0x03000147 diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h index 5a489917580e..05962d8fbb25 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_common.h +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h @@ -159,6 +159,9 @@ enum platform_inst_fw_cap_type { VFLIP, IR_TYPE, IR_PERIOD, + SLICE_MODE, + SLICE_MAX_BYTES, + SLICE_MAX_MB, INST_FW_CAP_MAX, }; diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c index 5da90d47f9c6..191154a8ab8d 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c @@ -18,6 +18,8 @@ #define VIDEO_ARCH_LX 1 #define BITRATE_MAX 245000000 +#define MAX_SLICE_MB_SIZE \ + (((4096 + 15) >> 4) * ((2304 + 15) >> 4)) static struct iris_fmt platform_fmts_sm8550_dec[] = { [IRIS_FMT_H264] = { @@ -740,6 +742,35 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8550_enc[] = { CAP_FLAG_DYNAMIC_ALLOWED, .set = iris_set_ir_period, }, + { + .cap_id = SLICE_MODE, + .min = V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_SINGLE, + .max = V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_BYTES, + .step_or_mask = BIT(V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_SINGLE) | + BIT(V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB) | + BIT(V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_BYTES), + .value = V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_SINGLE, + .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU, + .set = iris_set_slice_count, + }, + { + .cap_id = SLICE_MAX_BYTES, + .min = 512, + .max = BITRATE_MAX >> 3, + .step_or_mask = 1, + .value = 512, + .hfi_id = HFI_PROP_MULTI_SLICE_BYTES_COUNT, + .flags = CAP_FLAG_OUTPUT_PORT, + }, + { + .cap_id = SLICE_MAX_MB, + .min = 1, + .max = MAX_SLICE_MB_SIZE, + .step_or_mask = 1, + .value = 1, + .hfi_id = HFI_PROP_MULTI_SLICE_MB_COUNT, + .flags = CAP_FLAG_OUTPUT_PORT, + }, }; static struct platform_inst_caps platform_inst_cap_sm8550 = { --- base-commit: 4fbeef21f5387234111b5d52924e77757626faa5 change-id: 20260425-iris_multi_slice-81cfdc651997 Best regards, -- Sachin Kumar Garg