From: kernel test robot <lkp@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-media@vger.kernel.org
Subject: [sailus-media-tree:metadata 32/122] drivers/media/platform/renesas/vsp1/vsp1_entity.c:302:5: error: conflicting types for 'vsp1_subdev_set_pad_format'; have 'int(struct v4l2_subdev *, const struct v4l2_subdev_client_info *, struct v4l2_subdev_state *, struct v4l2_subdev_format *)'
Date: Wed, 29 Apr 2026 14:18:49 +0800 [thread overview]
Message-ID: <202604291444.xozszFSV-lkp@intel.com> (raw)
tree: git://linuxtv.org/sailus/media_tree.git metadata
head: 489ab6e79288be8d219b68525a13699fde0248ae
commit: 66bc8bdd8684ee2b5ae46e66fb88e8c3474e69eb [32/122] media: v4l2-subdev: Add struct v4l2_subdev_client_info argument to pad ops
config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20260429/202604291444.xozszFSV-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260429/202604291444.xozszFSV-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604291444.xozszFSV-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/media/platform/renesas/vsp1/vsp1_entity.c:302:5: error: conflicting types for 'vsp1_subdev_set_pad_format'; have 'int(struct v4l2_subdev *, const struct v4l2_subdev_client_info *, struct v4l2_subdev_state *, struct v4l2_subdev_format *)'
302 | int vsp1_subdev_set_pad_format(struct v4l2_subdev *subdev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/media/platform/renesas/vsp1/vsp1_entity.c:22:
drivers/media/platform/renesas/vsp1/vsp1_entity.h:190:5: note: previous declaration of 'vsp1_subdev_set_pad_format' with type 'int(struct v4l2_subdev *, struct v4l2_subdev_state *, struct v4l2_subdev_format *)'
190 | int vsp1_subdev_set_pad_format(struct v4l2_subdev *subdev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
vim +302 drivers/media/platform/renesas/vsp1/vsp1_entity.c
076e834fee91db drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2016-02-24 290
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 291 /*
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 292 * vsp1_subdev_set_pad_format - Subdev pad set_fmt handler
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 293 * @subdev: V4L2 subdevice
30d187cd74874a drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2023-11-26 294 * @sd_state: V4L2 subdev state
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 295 * @fmt: V4L2 subdev format
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 296 *
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 297 * This function implements the subdev set_fmt pad operation for entities that
c247aa0b75d67c drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2026-03-19 298 * do not support scaling or cropping. It defaults to the first supported media
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 299 * bus code if the requested code isn't supported, clamps the size to the
2cbf20a3fd8ffd drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2026-03-19 300 * entity's limits, and propagates the sink pad format to the source pad.
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 301 */
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 @302 int vsp1_subdev_set_pad_format(struct v4l2_subdev *subdev,
66bc8bdd8684ee drivers/media/platform/renesas/vsp1/vsp1_entity.c Sakari Ailus 2026-01-30 303 const struct v4l2_subdev_client_info *ci,
0d346d2a6f54f0 drivers/media/platform/vsp1/vsp1_entity.c Tomi Valkeinen 2021-06-10 304 struct v4l2_subdev_state *sd_state,
2cbf20a3fd8ffd drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2026-03-19 305 struct v4l2_subdev_format *fmt)
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 306 {
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 307 struct vsp1_entity *entity = to_vsp1_entity(subdev);
30d187cd74874a drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2023-11-26 308 struct v4l2_subdev_state *state;
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 309 struct v4l2_mbus_framefmt *format;
3d7899c21fbba1 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 310 struct v4l2_rect *selection;
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 311 unsigned int i;
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 312 int ret = 0;
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 313
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 314 mutex_lock(&entity->lock);
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 315
30d187cd74874a drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2023-11-26 316 state = vsp1_entity_get_state(entity, sd_state, fmt->which);
30d187cd74874a drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2023-11-26 317 if (!state) {
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 318 ret = -EINVAL;
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 319 goto done;
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 320 }
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 321
0aaf7db0872677 drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2023-11-12 322 format = v4l2_subdev_state_get_format(state, fmt->pad);
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 323
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 324 if (fmt->pad == entity->source_pad) {
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 325 /* The output format can't be modified. */
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 326 fmt->format = *format;
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 327 goto done;
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 328 }
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 329
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 330 /*
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 331 * Default to the first media bus code if the requested format is not
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 332 * supported.
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 333 */
c247aa0b75d67c drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2026-03-19 334 for (i = 0; i < entity->num_codes; ++i) {
c247aa0b75d67c drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2026-03-19 335 if (fmt->format.code == entity->codes[i])
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 336 break;
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 337 }
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 338
c247aa0b75d67c drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2026-03-19 339 format->code = i < entity->num_codes
c247aa0b75d67c drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2026-03-19 340 ? entity->codes[i] : entity->codes[0];
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 341 format->width = clamp_t(unsigned int, fmt->format.width,
2cbf20a3fd8ffd drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2026-03-19 342 entity->min_width, entity->max_width);
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 343 format->height = clamp_t(unsigned int, fmt->format.height,
2cbf20a3fd8ffd drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2026-03-19 344 entity->min_height, entity->max_height);
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 345 format->field = V4L2_FIELD_NONE;
d5e3bc24d5ce4c drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2025-04-30 346
d5e3bc24d5ce4c drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2025-04-30 347 format->colorspace = fmt->format.colorspace;
d5e3bc24d5ce4c drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2025-04-30 348 format->xfer_func = fmt->format.xfer_func;
d5e3bc24d5ce4c drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2025-04-30 349 format->ycbcr_enc = fmt->format.ycbcr_enc;
d5e3bc24d5ce4c drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2025-04-30 350 format->quantization = fmt->format.quantization;
d5e3bc24d5ce4c drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2025-04-30 351
d5e3bc24d5ce4c drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2025-04-30 352 vsp1_entity_adjust_color_space(format);
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 353
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 354 fmt->format = *format;
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 355
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 356 /* Propagate the format to the source pad. */
0aaf7db0872677 drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2023-11-12 357 format = v4l2_subdev_state_get_format(state, entity->source_pad);
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 358 *format = fmt->format;
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 359
23a99e80e3082b drivers/media/platform/vsp1/vsp1_entity.c Kieran Bingham 2018-08-31 360 /* Reset the crop and compose rectangles. */
769d5fe4eb8e8f drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2023-11-12 361 selection = v4l2_subdev_state_get_crop(state, fmt->pad);
3d7899c21fbba1 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 362 selection->left = 0;
3d7899c21fbba1 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 363 selection->top = 0;
3d7899c21fbba1 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 364 selection->width = format->width;
3d7899c21fbba1 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 365 selection->height = format->height;
3d7899c21fbba1 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 366
769d5fe4eb8e8f drivers/media/platform/renesas/vsp1/vsp1_entity.c Laurent Pinchart 2023-11-12 367 selection = v4l2_subdev_state_get_compose(state, fmt->pad);
3d7899c21fbba1 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 368 selection->left = 0;
3d7899c21fbba1 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 369 selection->top = 0;
3d7899c21fbba1 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 370 selection->width = format->width;
3d7899c21fbba1 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 371 selection->height = format->height;
3d7899c21fbba1 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 372
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 373 done:
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 374 mutex_unlock(&entity->lock);
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 375 return ret;
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 376 }
b4ccae1025f3c7 drivers/media/platform/vsp1/vsp1_entity.c Laurent Pinchart 2017-11-27 377
:::::: The code at line 302 was first introduced by commit
:::::: b4ccae1025f3c7dac3c35019369627622ec01e94 media: v4l: vsp1: Share the CLU, LIF and LUT set_fmt pad operation code
:::::: TO: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
:::::: CC: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-04-29 6:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202604291444.xozszFSV-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox