From: Stepan Ionichev <sozdayvek@gmail.com>
To: mchehab@kernel.org
Cc: gregkh@linuxfoundation.org, dan.carpenter@linaro.org,
aadarshmandal9354@gmail.com, luka.gejak@linux.dev,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Stepan Ionichev <sozdayvek@gmail.com>
Subject: [PATCH] staging: media: av7110: remove dead av7110_reset_arm()
Date: Mon, 4 May 2026 17:21:05 +0500 [thread overview]
Message-ID: <20260504122105.1428-1-sozdayvek@gmail.com> (raw)
The av7110_reset_arm() function in av7110_hw.c is wrapped in an
"#if 0 / #endif" block and therefore not compiled into the driver.
The function name is not referenced from anywhere else in the
av7110 driver tree:
$ git grep -n av7110_reset_arm drivers/staging/media/av7110/
(no results after this change)
The actual ARM boot path is implemented by av7110_bootarm(), so the
disabled av7110_reset_arm() is leftover code with no remaining
purpose. Drop it; "#if 0" blocks are dead code and should be
removed rather than kept around (see coding-style.rst, section 21,
"Conditional Compilation").
The "/* av7110 ARM core boot stuff */" section comment is kept,
since it still applies to the helpers that follow (waitdebi(),
load_dram(), av7110_bootarm()).
No functional change.
Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
---
drivers/staging/media/av7110/av7110_hw.c | 21 ---------------------
1 file changed, 21 deletions(-)
diff --git a/drivers/staging/media/av7110/av7110_hw.c b/drivers/staging/media/av7110/av7110_hw.c
index 49ce29577..3cd0988db 100644
--- a/drivers/staging/media/av7110/av7110_hw.c
+++ b/drivers/staging/media/av7110/av7110_hw.c
@@ -96,27 +96,6 @@ u32 av7110_debiread(struct av7110 *av7110, u32 config, int addr, unsigned int co
}
/* av7110 ARM core boot stuff */
-#if 0
-void av7110_reset_arm(struct av7110 *av7110)
-{
- saa7146_setgpio(av7110->dev, RESET_LINE, SAA7146_GPIO_OUTLO);
-
- /* Disable DEBI and GPIO irq */
- SAA7146_IER_DISABLE(av7110->dev, MASK_19 | MASK_03);
- SAA7146_ISR_CLEAR(av7110->dev, MASK_19 | MASK_03);
-
- saa7146_setgpio(av7110->dev, RESET_LINE, SAA7146_GPIO_OUTHI);
- msleep(30); /* the firmware needs some time to initialize */
-
- ARM_ResetMailBox(av7110);
-
- SAA7146_ISR_CLEAR(av7110->dev, MASK_19 | MASK_03);
- SAA7146_IER_ENABLE(av7110->dev, MASK_03);
-
- av7110->arm_ready = 1;
- dprintk(1, "reset ARM\n");
-}
-#endif /* 0 */
static int waitdebi(struct av7110 *av7110, int adr, int state)
{
--
2.33.0.windows.2
reply other threads:[~2026-05-04 13:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504122105.1428-1-sozdayvek@gmail.com \
--to=sozdayvek@gmail.com \
--cc=aadarshmandal9354@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox