From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13EF51DE894; Tue, 5 May 2026 22:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778020887; cv=none; b=dYiLAvgGelW7QDL5wxXpf++F3evByL/3mX8BiFIDzpLU3PxZelJLgEeHOyy3XdfXzu9vZSI4JUKKLtVLXI+GgYyWePGKTFX/XHqd1sZ5VUGWAauXaCFJhdEC98Vj9eZ2NTXVuHAF00WDXcNTaK+p+Xv7KoG4E6FROimiDqNIY8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778020887; c=relaxed/simple; bh=whhdB0jSlNvIcCn4yTQh1IWX+0kZn4kDL5bgL/kWPXU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XI8L0FmC8oKmdRfKFiGRIs+auBx4m/NKhHAV0oBuibAIIY5Z2OogUgCL1C7bUlefjmc4RXzpw1fQUxwFCHd3dyiK1KHbXZ944cr/FM8ZAWks6WsBC6PzEvtrfkR56PQH5swA95/SHqpofifXnDLsdOaC37d3xunQp+5rZpUpBwQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=N2FdDZC7; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="N2FdDZC7" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 645875B2; Wed, 6 May 2026 00:41:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1778020881; bh=whhdB0jSlNvIcCn4yTQh1IWX+0kZn4kDL5bgL/kWPXU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N2FdDZC7vLPJArLf0fbyGhKPzHWf3fyR+jP6pUJ2cCvcMLOiZ9ruKzWEs6MoLG5wA bGA0e6n1qC+P2ARixooOQIRp5AvWXpjzibSpNa33b8RVZHMPUNYfFy8YScU9queoUh lFgeB3Kj7CVM8eNJLHvr/hZH6pcgh7DiImZ0e1FE= Date: Wed, 6 May 2026 01:41:23 +0300 From: Laurent Pinchart To: Ricardo Ribalda Cc: Mauro Carvalho Chehab , Sakari Ailus , Hans Verkuil , Nas Chung , Jackson Lee , Bingbu Cao , Tianshu Qiu , Greg Kroah-Hartman , Keke Li , Yong Zhi , Jacopo Mondi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Mauro Carvalho Chehab Subject: Re: [PATCH v3 2/6] media: i2c: mt9p031: Rewrite assignment to make smatch happy Message-ID: <20260505224123.GD1598374@killaraus.ideasonboard.com> References: <20260504-smatch-7-1-v3-0-fda125c30058@chromium.org> <20260504-smatch-7-1-v3-2-fda125c30058@chromium.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260504-smatch-7-1-v3-2-fda125c30058@chromium.org> On Mon, May 04, 2026 at 06:54:05AM +0000, Ricardo Ribalda wrote: > The current code makes smatch a bit uncomfortable: > drivers/media/i2c/mt9p031.c:799 mt9p031_s_ctrl() warn: assigning (-1952) to unsigned variable 'data' > > Probably because smatch is not clever enough (yet). Do a simple rewrite > to make sure that smatch understands what we are doing here. > > Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/mt9p031.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c > index ea5d43d925ff..8dc57eeba606 100644 > --- a/drivers/media/i2c/mt9p031.c > +++ b/drivers/media/i2c/mt9p031.c > @@ -796,7 +796,8 @@ static int mt9p031_s_ctrl(struct v4l2_ctrl *ctrl) > data = (1 << 6) | (ctrl->val >> 1); > } else { > ctrl->val &= ~7; > - data = ((ctrl->val - 64) << 5) | (1 << 6) | 32; > + data = ((ctrl->val - 64) >> 3) & 0x7f; > + data = (data << 8) | (1 << 6) | 32; > } > > return mt9p031_write(client, MT9P031_GLOBAL_GAIN, data); -- Regards, Laurent Pinchart