From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E09722139C9; Tue, 5 May 2026 23:17:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778023039; cv=none; b=Ico6T6Wu/i1/IGElBqLTYuIjPCnXkoiM7YiU5dhfOZQP2tfE5bUIujwUDydyf4k0262TT+tjbLjqovvT9wDl07Htfv24EkaeGp7Ni8+8nG/5k98vLv3FrpBenGNcmernHSxxugln+ivOfzPm2vhqFxWp/hWd4mvATvWS58+b7ro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778023039; c=relaxed/simple; bh=c8M4maA60WNCneZAUPBVL/CCdJLUgPwcYyV/VxFNqZ0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lfEiIHLRieJDKWauPZBrLEvPIngf6hiteAmpQpWZPURpWgQTi8zsE6F2q/+wLG7kpZGhywHU3BMxWpy2cmjAX2bC1AorEddd+/NvMiNVxZLY5vB4sYAILVq01JWvYV3U2E/bxKMQDM9OGIeMdtEKefG5FG+BEmhGCp8IzUpUn2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=fZB7KleA; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fZB7KleA" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 378855B2; Wed, 6 May 2026 01:17:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1778023033; bh=c8M4maA60WNCneZAUPBVL/CCdJLUgPwcYyV/VxFNqZ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fZB7KleAbE0ZRbNifz1iPnPMN4zO3FVFoahmaezfmomNKG42PGkqibhPYIADotQ7E l6i3HhOailRhn6ISJwXYLyxVT8Z4wSBd17wx5aXXBI8X59pv714ceZNtWrPJZNEAXX M5EsVgrVDoY8EDvozIJikaGBl6rrmirZjihRgwuQ= Date: Wed, 6 May 2026 02:17:14 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: Ricardo Ribalda , Mauro Carvalho Chehab , Sakari Ailus , Hans Verkuil , Nas Chung , Jackson Lee , Bingbu Cao , Tianshu Qiu , Greg Kroah-Hartman , Keke Li , Yong Zhi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Mauro Carvalho Chehab , stable@vger.kernel.org Subject: Re: [PATCH v3 6/6] media: amlogic-c3: Add validations for ae and awb config Message-ID: <20260505231714.GF1598374@killaraus.ideasonboard.com> References: <20260504-smatch-7-1-v3-0-fda125c30058@chromium.org> <20260504-smatch-7-1-v3-6-fda125c30058@chromium.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Mon, May 04, 2026 at 09:19:30AM +0200, Jacopo Mondi wrote: > On Mon, May 04, 2026 at 06:54:09AM +0000, Ricardo Ribalda wrote: > > Avoid invalid memory access if the zones_num is bigger than > > zone_weight. > > > > This patch fixes the following smatch errors: > > drivers/media/platform/amlogic/c3/isp/c3-isp-params.c:111 c3_isp_params_awb_wt() error: buffer overflow 'cfg->zone_weight' 768 <= u32max > > drivers/media/platform/amlogic/c3/isp/c3-isp-params.c:111 c3_isp_params_awb_wt() error: buffer overflow 'cfg->zone_weight' 768 <= u32max > > drivers/media/platform/amlogic/c3/isp/c3-isp-params.c:227 c3_isp_params_ae_wt() error: buffer overflow 'cfg->zone_weight' 255 <= u32max > > drivers/media/platform/amlogic/c3/isp/c3-isp-params.c:227 c3_isp_params_ae_wt() error: buffer overflow 'cfg->zone_weight' 255 <= u32max > > > > Cc: stable@vger.kernel.org > > Fixes: fb2e135208f3 ("media: platform: Add C3 ISP driver") > > Signed-off-by: Ricardo Ribalda > > --- > > drivers/media/platform/amlogic/c3/isp/c3-isp-params.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/media/platform/amlogic/c3/isp/c3-isp-params.c b/drivers/media/platform/amlogic/c3/isp/c3-isp-params.c > > index 6f9ca7a7dd88..aec3eed0e443 100644 > > --- a/drivers/media/platform/amlogic/c3/isp/c3-isp-params.c > > +++ b/drivers/media/platform/amlogic/c3/isp/c3-isp-params.c > > @@ -104,6 +104,8 @@ static void c3_isp_params_awb_wt(struct c3_isp_device *isp, > > c3_isp_write(isp, ISP_AWB_BLK_WT_ADDR, 0); > > > > zones_num = cfg->horiz_zones_num * cfg->vert_zones_num; > > + if (zones_num > C3_ISP_AWB_MAX_ZONES) > > + zones_num = C3_ISP_AWB_MAX_ZONES; > > Or > zones_num = min(cfg->horiz_zones_num * cfg->vert_zones_num, > C3_ISP_AWB_MAX_ZONES); I have a slight preference for that, but both options work for me. Reviewed-by: Laurent Pinchart > Whatever you prefer: > Reviewed-by: Jacopo Mondi > > > > > /* Need to write 8 weights at once */ > > for (i = 0; i < zones_num / 8; i++) { > > @@ -220,6 +222,8 @@ static void c3_isp_params_ae_wt(struct c3_isp_device *isp, > > c3_isp_write(isp, ISP_AE_BLK_WT_ADDR, 0); > > > > zones_num = cfg->horiz_zones_num * cfg->vert_zones_num; > > + if (zones_num > C3_ISP_AE_MAX_ZONES) > > + zones_num = C3_ISP_AE_MAX_ZONES; > > > > /* Need to write 8 weights at once */ > > for (i = 0; i < zones_num / 8; i++) { -- Regards, Laurent Pinchart