From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f194.google.com (mail-dy1-f194.google.com [74.125.82.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C86728725A for ; Thu, 7 May 2026 02:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778120562; cv=none; b=s7gGXSQzPLMgJWgaji+yZBRW1D6FHNT244iwkKsySX++ZHYJCyKP7ZtKnM6FHUZARCRTgEG1mVIFtZ9UHYuWGBCSpDahfkHn/XTKw0GlhtM9Se4Et7IHnznhJHHPDYuUNtusFkW1cypDVShJ+Cjb1porZMJ4CCBGNzvFEUqpgno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778120562; c=relaxed/simple; bh=Zl68Je2THxiwdgrtmVgPoRyHAnq26RpEGmiXgHyG+i8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=j+Dt1OEEQzZfNYiHW6chL/efQA0IYnGX7gxD4VUJbBng/cUQmwmO27/oFPNw+4NvLP/T6uDWvZCFIYX9CD+GRzxnCwfEh7+usxFCpW8QVSXsOHvkIH5w2FAY0rTvlRgaI/C2uR8WEToyhWuKmTV+6dAqqxB9xkKxWmN/RxWSYGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fHo+0TwY; arc=none smtp.client-ip=74.125.82.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fHo+0TwY" Received: by mail-dy1-f194.google.com with SMTP id 5a478bee46e88-2c15849aa2cso443811eec.0 for ; Wed, 06 May 2026 19:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778120559; x=1778725359; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m2A7OPcIfEOOgPo/hUvss5p4sYWrcq7D2ShgndF76WM=; b=fHo+0TwYIMwabPTXEjFVd0tLPEN+rVmK8+bmjbgcvwbyMDarTb1h69oYOnq8wP8K1V v7eVsGYsjNBonkym+o0FYItFvEtdCAEwQdiu4Eep3N8PO8/apxtxmlOxFbK9/tVXRNFl ZAEgxXV+HH1wE2a5eQxkt8zsqbsDBX9WN6NPw7HCeYBg/I6xlf4npo9IsmVuHKGSJpG4 Hvs4UZMqn8vSrWCcXKmKjUqHaJtWgWRdY6iUYVaebiC2We384hIsPVXaY/diy2BlHqOS jSCeJSFqF+KGBxuMGRA1BzghY8dAbb2JZhVqUAxUiFe1WkFoAy+A8W1tm8NNC4865KtN 559g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778120559; x=1778725359; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=m2A7OPcIfEOOgPo/hUvss5p4sYWrcq7D2ShgndF76WM=; b=N0dsjIXN8ekbRFJKOmQenR+4EbNm7WEmujmE0xtSognertw0rjoxR8W4EACVklKbIa s0ZSZBAf0QBpumJUdkqjaqjUoI9e1TRhCEenM7pi7B/1yH+7JtNDKsgo8OUY8h2mbKgk AWmcHroaYANVjm4S1gxQZsHpwmNQQYQOzTC80S7HiaOaWVEMNOIDYs/s0hchYziC5Eqp fTnCGkuCtAJ6fSLPpupV950XnmZ6VA1zwCy04LuzjohM4axErqHYy42lLPuvzPl4IJyJ kaXJgFCmWh91KskddGujdaiqGc33EZ2myybY3hgEDqmL5BLqMGXBi6zsmcbhxtJx5yqU +Rug== X-Forwarded-Encrypted: i=1; AFNElJ/t0y9ut5H95Z0/rADX1lelzeGjbqHvulM/exoJKsWEZekOBpZCM+zd7/6n61NjbfKz7oLVPKpuxn/w1w==@vger.kernel.org X-Gm-Message-State: AOJu0YwUiHeuZnRasdl2OGCYJyD432QkgmvSgm12A9jkC2cFeGdaWGYJ NLKn50M2cSEUc9oe19+BqVqPl1bIoVkzpiGwoC1g+DTj8AoxfsAwgD6y X-Gm-Gg: AeBDietINzHdp7xlmCjITr6TC09tWdjpNEUUxcjRIAgpM1aDSd3iT0CWhCA3pZ3A/ep 5iJ5CtkDsBsxCZAdP46+H3KAjIQ+pX18D0mgMBjQtwBOwotlxyX0lQxygXSp1A5UhSDHdB296+O zG3Z26FqgudZVDG9nllpuTDAdpENt9wWCoqoul12tSFnJaDHvnNRPMnQMw80ds61akwi0x+iDP/ 7gE4vSMTOqrrJy3vO7vhMHv8+oUjw8dldP7u4vzIp9FGy2B6IOyPgjVEbcVebXJYciNo4rvGZ1l 1L+A2sg2tJ1f9J4ux7eBBobA+Ev9DZI4g6WfNRbz4QSVX9W58Y89zHlW9OhZdkoxxd1n3guCtAO N7GNsMLdaDmHpN8IfN6eKsD9PTjYlH5qKYZ+VlcrytifgQ74/YGGAhIMd130pzVWIxLV0yCR9V4 qdwLQm7ospJpi9F3Wg7i2vCIOXaEPGETwY6LemSdK1dXWaaBVKDbFdKQe3e1NqI7bBfA== X-Received: by 2002:a05:7300:ec08:b0:2e6:e916:70ff with SMTP id 5a478bee46e88-2f54aa81abemr3065260eec.28.1778120559210; Wed, 06 May 2026 19:22:39 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f570384e46sm6658192eec.26.2026.05.06.19.22.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 19:22:38 -0700 (PDT) From: Hungyu Lin To: mchehab@kernel.org, gregkh@linuxfoundation.org, luca.ceresoli@bootlin.com Cc: thierry.reding@kernel.org, jonathanh@nvidia.com, skomatineni@nvidia.com, digetx@gmail.com, hverkuil+cisco@kernel.org, dan.carpenter@linaro.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin , stable@vger.kernel.org Subject: [PATCH v3 1/1] media: tegra-video: vi: fix invalid u32 return value in format lookup Date: Thu, 7 May 2026 02:22:13 +0000 Message-Id: <20260507022213.29290-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260507022213.29290-1-dennylin0707@gmail.com> References: <20260507022213.29290-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit tegra_get_format_fourcc_by_idx() returns a u32 but uses -EINVAL to signal an out-of-bounds index. This results in a large unsigned value being returned, which may be interpreted as a valid fourcc. Returning 0 is not a valid fourcc either. This condition should never happen, so use WARN_ON_ONCE() to catch unexpected out-of-bounds access and return a valid fallback format instead. Suggested-by: Hans Verkuil Fixes: 3d8a97eabef0 ("media: tegra-video: Add Tegra210 Video input driver") Cc: stable@vger.kernel.org Reviewed-by: Luca Ceresoli Signed-off-by: Hungyu Lin --- drivers/staging/media/tegra-video/vi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c index f14cdc7b5211..456134a9e8cf 100644 --- a/drivers/staging/media/tegra-video/vi.c +++ b/drivers/staging/media/tegra-video/vi.c @@ -80,8 +80,8 @@ static int tegra_get_format_idx_by_code(struct tegra_vi *vi, static u32 tegra_get_format_fourcc_by_idx(struct tegra_vi *vi, unsigned int index) { - if (index >= vi->soc->nformats) - return -EINVAL; + if (WARN_ON_ONCE(index >= vi->soc->nformats)) + return vi->soc->video_formats[0].fourcc; return vi->soc->video_formats[index].fourcc; } -- 2.34.1