Linux Media Controller development
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Frank Li <Frank.li@nxp.com>
Cc: linux-media@vger.kernel.org, Sakari Ailus <sakari.ailus@iki.fi>
Subject: Re: [PATCH 1/2] media: mc-entity: Fix documentation typo in function name
Date: Fri, 8 May 2026 23:07:56 +0300	[thread overview]
Message-ID: <20260508200756.GE2186850@killaraus.ideasonboard.com> (raw)
In-Reply-To: <af4K5RFxKAWkAcwf@lizhi-Precision-Tower-5810>

On Fri, May 08, 2026 at 12:10:13PM -0400, Frank Li wrote:
> On Wed, May 06, 2026 at 07:54:37PM +0300, Laurent Pinchart wrote:
> > The media_entity_pads_init() function name is misspelled. Fix it.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Nit: suggest put real functions name in subject.
> 
> documentation typo in media_entity_pads_init()

I've left it out to avoid a too long subject. If the person picking this
patch (Sakari ?) would prefer adding it I'm fine with that too.

> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> 
> > ---
> >  include/media/media-entity.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/media/media-entity.h b/include/media/media-entity.h
> > index b91ff6f8c3bb..904f61c14dc1 100644
> > --- a/include/media/media-entity.h
> > +++ b/include/media/media-entity.h
> > @@ -726,7 +726,7 @@ int media_entity_pads_init(struct media_entity *entity, u16 num_pads,
> >   * the entity (currently, it does nothing).
> >   *
> >   * Calling media_entity_cleanup() on a media_entity whose memory has been
> > - * zeroed but that has not been initialized with media_entity_pad_init() is
> > + * zeroed but that has not been initialized with media_entity_pads_init() is
> >   * valid and is a no-op.
> >   */
> >  #if IS_ENABLED(CONFIG_MEDIA_CONTROLLER)
> >
> > base-commit: 3cd9b7011519c3fffffb7b6752fc7603be52dc1d

-- 
Regards,

Laurent Pinchart

      reply	other threads:[~2026-05-08 20:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 16:54 [PATCH 1/2] media: mc-entity: Fix documentation typo in function name Laurent Pinchart
2026-05-06 16:54 ` [PATCH 2/2] media: mc-entity: Drop ifdef for media_entity_cleanup definition Laurent Pinchart
2026-05-07 12:48   ` Jacopo Mondi
2026-05-07 12:54     ` Laurent Pinchart
2026-05-07 12:46 ` [PATCH 1/2] media: mc-entity: Fix documentation typo in function name Jacopo Mondi
2026-05-08 16:10 ` Frank Li
2026-05-08 20:07   ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260508200756.GE2186850@killaraus.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=Frank.li@nxp.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox