From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71BC03FCB03 for ; Wed, 13 May 2026 10:44:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778669053; cv=none; b=pCsKlslcbxA20vL3DS9GKMWeA+sWWR0SUjDeXPmMsQBK3JHQTYoRqJTM2giJFRlI9Pm+10h3ohO1OVKxDp8Mtr1LJG/MPqikrxU5oY6gcA8VeuuWnOU81tqHlZD29XKZXXqJ//+aSv8OHGGL0/T536gJ13qPkqGZHd7c/+KpCkA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778669053; c=relaxed/simple; bh=qwp3qKeUD6zfoReKydwZNu0N0fQBjOgtGZqfeaz91Pk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R/qwsZ/CvN4lf0STBwP3mDNnPQdunA57rziORa7YIPIm5CHmX+hTSH/Hv0I51BP49Kp11Q68t+tbs4sGhMJe2y305QW5vARng1PKyJNsZ2hdeiRlUfonbv1LKxgnZrXC4AtCe5uzTeKHLHT7zImyJ2gBTc5GE7Mo/FtZHmBPnA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OvgYbJ1W; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OvgYbJ1W" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778669053; x=1810205053; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qwp3qKeUD6zfoReKydwZNu0N0fQBjOgtGZqfeaz91Pk=; b=OvgYbJ1Wsbno9d4oh8N77CcC+jY46AEs1yFCsKqFcdWNLGMYH92hg7+w +/HIFVRKbp+zGiMBsG1w6sL0FOn2Vwg86zvGas5il5M3+sAxC2IjAnkbB 0iShCxGA/5hQTvEQLeZfbD3WU9Kr9mCK/CvKYfhD8G+ekx+6UE/dxVbpo rHP+COQNojTQCenvwEzkc/po5zga6i3NFQAUDHfB6RFXTjK2+jWODml3L 7Xy4Y+8S+7cxD1tX0H3BCh81oJqin4UrulEaFvKfo7/i/bdwZY7qy+qyz JpsdPukB1DDFfy5WCO1fWvYxNHkH7+4j1ghNMhVH1W0Jlm8lheYZMvdtl Q==; X-CSE-ConnectionGUID: BZJukSlFSniaiViXfF64BQ== X-CSE-MsgGUID: 3SIh+sKoT3ic28CeZprY2g== X-IronPort-AV: E=McAfee;i="6800,10657,11784"; a="83464479" X-IronPort-AV: E=Sophos;i="6.23,232,1770624000"; d="scan'208";a="83464479" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2026 03:44:08 -0700 X-CSE-ConnectionGUID: N/Zd7WULSDi6J6fD5hXqLw== X-CSE-MsgGUID: QrV32yTKSq6CvQMbVwr6GQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,232,1770624000"; d="scan'208";a="233599267" Received: from ettammin-mobl3.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.244.111]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2026 03:44:05 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id E425F121DB7; Wed, 13 May 2026 13:43:59 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1wN74I-00000009S29-3fjS; Wed, 13 May 2026 13:43:58 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: laurent.pinchart@ideasonboard.com, Dave Stevenson , Jacopo Mondi , Tomi Valkeinen , Jai Luthra , Mehdi Djait Subject: [PATCH 14/17] media: exynos4-is: Use v4l2_subdev_get_frame_desc() Date: Wed, 13 May 2026 13:43:55 +0300 Message-ID: <20260513104358.2252605-15-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260513104358.2252605-1-sakari.ailus@linux.intel.com> References: <20260513104358.2252605-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Call v4l2_subdev_get_frame_desc() to obtain the frame descriptor. This is preferred over calling the get_frame_desc() pad operation directly. Signed-off-by: Sakari Ailus --- .../platform/samsung/exynos4-is/fimc-capture.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-capture.c b/drivers/media/platform/samsung/exynos4-is/fimc-capture.c index d85811f4b8c5..7f463871ea0c 100644 --- a/drivers/media/platform/samsung/exynos4-is/fimc-capture.c +++ b/drivers/media/platform/samsung/exynos4-is/fimc-capture.c @@ -6,6 +6,7 @@ * Sylwester Nawrocki */ +#include #include #include #include @@ -853,18 +854,23 @@ static int fimc_get_sensor_frame_desc(struct v4l2_subdev *sensor, struct v4l2_plane_pix_format *plane_fmt, unsigned int num_planes, bool try) { - struct v4l2_mbus_frame_desc fd = { }; + struct v4l2_mbus_frame_desc *alloc_fd + __free(v4l2_subdev_free_frame_desc) = NULL, fd = { }; int i, ret; int pad; for (i = 0; i < num_planes; i++) - fd.entry[i].length = plane_fmt[i].sizeimage; + set_fd.entry[i].length = plane_fmt[i].sizeimage; pad = sensor->entity.num_pads - 1; - if (try) + if (try) { ret = v4l2_subdev_call(sensor, pad, set_frame_desc, pad, &fd); - else - ret = v4l2_subdev_call(sensor, pad, get_frame_desc, pad, &fd); + } else { + alloc_fd = v4l2_subdev_get_frame_desc(sensor, pad, + V4L2_MBUS_FRAME_DESC_TYPE_CSI2); + ret = PTR_ERR(alloc_fd); + fd = *alloc_fd; + } if (ret < 0) return ret; -- 2.47.3