From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56E823F7AA5 for ; Wed, 13 May 2026 10:44:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778669049; cv=none; b=kPj6xCkbpqr8vDoYEdDcOaE6Xf6TyYWlKoH/Na4Lp68AHxwLObp5zVGam17f+Sbi7ziCkg1n7VwPsL8+s2HO2rU4TsBSXsgOQx1f3W4eYiwIplJYQ8z11m0rgM7iElfCDzPSUROuxSTLpD0jycQq9oAII/6qRoLvrV4CNQPao/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778669049; c=relaxed/simple; bh=wRXz/v/zrSy050U9DfK+VWqzYxpL91u3b6LGz+8h9tQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pd9ulRRc0mud1RVCyIct3RnjFQr8RT15stPMcOJuDFwmNAKrxvae1s/+OZJCwj3w4EqgnDi9A8jhp8VQGRVc49Rxc4qczldkoDBYo1SB1dbAN09cTxCF153V625tiH3MpxL9cPcDroCil8ei3jaZqb7z6QyxxgeiH977+QZJX4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dgZAErdY; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dgZAErdY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778669049; x=1810205049; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=wRXz/v/zrSy050U9DfK+VWqzYxpL91u3b6LGz+8h9tQ=; b=dgZAErdYWHEl4TPTc+z7TT7ETILgJ2rk7pNkbZsRIYXG1xij2oNGjR4l +Z0aUWTGPZvGFK+XNYoiSiud1VaG+okZ144UlZqKdqYyfrQqAH7NUsSFu NxtHHSPR6tanYERoPudO103maKeQtevzh/lPJViEGsXt2F+KvVV83QXFu xhUdTDXNIOMfFPfeS7I+coj9iBZM1uCW7+HgMDOL0SJIefAbTyZ47iBJg 0JbWfjI7/yYJczrrtLnNItS7tKAa2o81u2bW6lLH+KoVK3DEajFwJEKCn k0AwDiTOBOM3mbmPY9GNQv08VGA+0HMx99NCxMlN0fIWTBOvWjTiXwIvX Q==; X-CSE-ConnectionGUID: KJQKx/SbQCOYVKcxnUn8Eg== X-CSE-MsgGUID: CmIYxcKORdSou87Uj49X+Q== X-IronPort-AV: E=McAfee;i="6800,10657,11784"; a="83464458" X-IronPort-AV: E=Sophos;i="6.23,232,1770624000"; d="scan'208";a="83464458" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2026 03:44:07 -0700 X-CSE-ConnectionGUID: Hon/w4qVTUai7Rau3ZzOJw== X-CSE-MsgGUID: 6O9AjYVKQUaKDXnzYUXUKg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,232,1770624000"; d="scan'208";a="233599258" Received: from ettammin-mobl3.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.244.111]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2026 03:44:05 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id D0228121CFE; Wed, 13 May 2026 13:43:59 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1wN74I-00000009S1e-3K9P; Wed, 13 May 2026 13:43:58 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: laurent.pinchart@ideasonboard.com, Dave Stevenson , Jacopo Mondi , Tomi Valkeinen , Jai Luthra , Mehdi Djait Subject: [PATCH 08/17] media: v4l2-subdev: Always return at least one frame descriptor Date: Wed, 13 May 2026 13:43:49 +0300 Message-ID: <20260513104358.2252605-9-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260513104358.2252605-1-sakari.ailus@linux.intel.com> References: <20260513104358.2252605-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make v4l2_subdev_get_frame_desc() return at least one frame descriptor entry or an error. Empty frame descriptors aren't useful for callers so callers can now omit this check. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-subdev.c | 5 +++++ include/media/v4l2-subdev.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c index 9d7f616ab7ea..b92ae87fa5d0 100644 --- a/drivers/media/v4l2-core/v4l2-subdev.c +++ b/drivers/media/v4l2-core/v4l2-subdev.c @@ -2709,6 +2709,11 @@ static int __v4l2_subdev_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad return -EINVAL; } + if (!desc->num_entries) { + dev_dbg(sd->dev, "no frame descriptor entries\n"); + return -EINVAL; + } + return ret; } diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index 6e40420c2fcc..8b10dcab5590 100644 --- a/include/media/v4l2-subdev.h +++ b/include/media/v4l2-subdev.h @@ -1816,6 +1816,8 @@ int v4l2_subdev_get_frame_desc_passthrough(struct v4l2_subdev *sd, * struct v4l2_mbus_frame_desc *desc __free(v4l2_subdev_free_frame_desc) = * v4l2_subdev_get_frame_desc(sd, pad, desc); * + * The returned frame descriptor will contain at least one entry. + * * Return: The frame descriptor on success or a negative error code on failure. */ struct v4l2_mbus_frame_desc * -- 2.47.3