From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a5-smtp.messagingengine.com (fhigh-a5-smtp.messagingengine.com [103.168.172.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09D6E3B0AC8; Wed, 13 May 2026 19:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.156 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778699354; cv=none; b=gN8ocGRg+lGeJeJ145U0NkJeKWOcP0RCYdTdYR8/+V80TjvHhqgoifGN0QfQAX1ZU/51m07H704q2auWuh7ChYZ0E9aOlBzjFABiA3QxQuE0wUn3pP9qSTgz/iOi7cUqK2ma+c9lE5zSfaCvUFGb+GYxTITmotK4ZSHK4WuE7CY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778699354; c=relaxed/simple; bh=wfTP6zrHiTZ5P8XkKFVjSsb1ZSvHabiMgrAGsl4oPqY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bw2wyHnNnVyEUH4+nARTiknc1oIzOlqBQEaX/S8CRHWt1NOlIJLzi5WitEI5ov1ptUDe9gqJY52emtKT9yojxbPgibqSXsb0DN/ccu91EadKXZGPp6xdkC6fgbQKx574Xk2nvJi8ETgofD238k3sLzl3fzGqIfcI3Oawdm0tw+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se; spf=pass smtp.mailfrom=ragnatech.se; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b=LKQv8VEB; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=nAAVujk1; arc=none smtp.client-ip=103.168.172.156 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b="LKQv8VEB"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="nAAVujk1" Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id 3093214001DA; Wed, 13 May 2026 15:09:12 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Wed, 13 May 2026 15:09:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1778699352; x=1778785752; bh=dUE4QjuDvAG3ZYTCQ2+yRiAVPToiCx1/5ddNt3VIM/s=; b= LKQv8VEBWtcH2qa80Lj975XxxOnoZDKgarju4CBGDgIAYYHohn3L2QV8k41iFcST 06iTjmn05bL9GOESaNEyDnt8mTPJDd2N+EE2zLCqwO7q5JYehDruXfme6ZH3HYHW udYOrqlJ+XHx4G6z5Uf/lf3H5jSRquucue6s1kYcyhyOqec92kLRbMKNsGPxS9d2 A66vIq7yjjCfYSi0+Fj40iJotATJjFuxR/GpIt4ngYKF6w2EqWmtlN7DrBE+K75z EvFBUl2fsNyLK1Y4knG+Cl/I8u5+xur8jiwJYlahxtZM8SrqhHiTqz1IhdEGRbx9 9xjjekHzNGXVPt6hmR736w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1778699352; x= 1778785752; bh=dUE4QjuDvAG3ZYTCQ2+yRiAVPToiCx1/5ddNt3VIM/s=; b=n AAVujk1XxOJ8W62GwtM8KxoXEs8zp6DhiwqisrBVYnWdVFMWPhrbdj+67i8+1/AJ botKkj9iGiLtwE9kZwmFPoiaeTAjCKHFjT+DeDZySEwmWlgxU5IYoNS2yUsATvqP AbaAPubkk9QeYgT7pfSfOYoZvjPsF2sPmLtcj7DLvKQMQfGDhfWLR2PfD+fY4Doo LAEAf8O0LbtqE8xJWuufbHjgjRZOlLpzS6G4t7tm078PsirLDFLm8lloN7f8mW1R rVUvdX6ea8ppPuDPUW4jldxbxBrnl36qSVszLMrZJb80fnSYBPFvdCWeRdxWPG4y rokFRpaYIUaUdDR/BmPDQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduvdehgeehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggugfgjsehtkeertddttdejnecuhfhrohhmpefpihhklhgr shcuufpnuggvrhhluhhnugcuoehnihhklhgrshdrshhouggvrhhluhhnugesrhgrghhnrg htvggthhdrshgvqeenucggtffrrghtthgvrhhnpeevteegtddvvdfhtdekgefhfeefheet heekkeegfeejudeiudeuleegtdehkeekteenucevlhhushhtvghrufhiiigvpedunecurf grrhgrmhepmhgrihhlfhhrohhmpehnihhklhgrshdrshhouggvrhhluhhnugesrhgrghhn rghtvggthhdrshgvpdhnsggprhgtphhtthhopeelpdhmohguvgepshhmthhpohhuthdprh gtphhtthhopehlrghurhgvnhhtrdhpihhntghhrghrthdorhgvnhgvshgrshesihguvggr shhonhgsohgrrhgurdgtohhmpdhrtghpthhtoheplhhinhhugidqmhgvughirgesvhhgvg hrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopegurhhiqdguvghvvghlsehlihhsthhs rdhfrhgvvgguvghskhhtohhprdhorhhgpdhrtghpthhtoheplhhinhhugidqrhgvnhgvsh grshdqshhotgesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehtohhmihdr vhgrlhhkvghinhgvnhesihguvggrshhonhgsohgrrhgurdgtohhmpdhrtghpthhtohepkh hivghrrghnrdgsihhnghhhrghmsehiuggvrghsohhnsghorghrugdrtghomhdprhgtphht thhopegsihhjuhdruggrshdrjhiisegsphdrrhgvnhgvshgrshdrtghomhdprhgtphhtth hopegrihhrlhhivggusehgmhgrihhlrdgtohhmpdhrtghpthhtohepshhimhhonhgrsehf fhiflhhlrdgthh X-ME-Proxy: Feedback-ID: i80c9496c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 May 2026 15:09:11 -0400 (EDT) Date: Wed, 13 May 2026 21:09:09 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Laurent Pinchart Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Tomi Valkeinen , Kieran Bingham , Biju Das , David Airlie , Simona Vetter Subject: Re: [PATCH 01/11] media: renesas: vsp1: Avoid forward function declaration Message-ID: <20260513190909.GD332351@ragnatech.se> References: <20260511235637.3468558-1-laurent.pinchart+renesas@ideasonboard.com> <20260511235637.3468558-2-laurent.pinchart+renesas@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260511235637.3468558-2-laurent.pinchart+renesas@ideasonboard.com> Hi Laurent, Thanks for your patch. On 2026-05-12 02:56:25 +0300, Laurent Pinchart wrote: > Reorder functions to avoid the forward declaration of the > vsp1_du_pipeline_configure(). No functional change intended. > > Signed-off-by: Laurent Pinchart Reviewed-by: Niklas Söderlund > --- > .../media/platform/renesas/vsp1/vsp1_drm.c | 90 +++++++++---------- > 1 file changed, 44 insertions(+), 46 deletions(-) > > diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drm.c b/drivers/media/platform/renesas/vsp1/vsp1_drm.c > index 15d266439564..79b85968b061 100644 > --- a/drivers/media/platform/renesas/vsp1/vsp1_drm.c > +++ b/drivers/media/platform/renesas/vsp1/vsp1_drm.c > @@ -57,6 +57,50 @@ static void vsp1_du_pipeline_frame_end(struct vsp1_pipeline *pipe, > * Pipeline Configuration > */ > > +/* Configure all entities in the pipeline. */ > +static void vsp1_du_pipeline_configure(struct vsp1_pipeline *pipe) > +{ > + struct vsp1_drm_pipeline *drm_pipe = to_vsp1_drm_pipeline(pipe); > + struct vsp1_entity *entity; > + struct vsp1_entity *next; > + struct vsp1_dl_list *dl; > + struct vsp1_dl_body *dlb; > + unsigned int dl_flags = 0; > + > + vsp1_pipeline_calculate_partition(pipe, &pipe->part_table[0], > + drm_pipe->width, 0); > + > + if (drm_pipe->force_brx_release) > + dl_flags |= VSP1_DL_FRAME_END_INTERNAL; > + if (pipe->output->writeback) > + dl_flags |= VSP1_DL_FRAME_END_WRITEBACK; > + > + dl = vsp1_dl_list_get(pipe->output->dlm); > + dlb = vsp1_dl_list_get_body0(dl); > + > + list_for_each_entry_safe(entity, next, &pipe->entities, list_pipe) { > + /* Disconnect unused entities from the pipeline. */ > + if (!entity->pipe) { > + vsp1_dl_body_write(dlb, entity->route->reg, > + VI6_DPR_NODE_UNUSED); > + > + entity->sink = NULL; > + list_del(&entity->list_pipe); > + > + continue; > + } > + > + vsp1_entity_route_setup(entity, pipe, dlb); > + vsp1_entity_configure_stream(entity, entity->state, pipe, > + dl, dlb); > + vsp1_entity_configure_frame(entity, pipe, dl, dlb); > + vsp1_entity_configure_partition(entity, pipe, > + &pipe->part_table[0], dl, dlb); > + } > + > + vsp1_dl_list_commit(dl, dl_flags); > +} > + > /* > * Insert the UIF in the pipeline between the prev and next entities. If no UIF > * is available connect the two entities directly. > @@ -224,8 +268,6 @@ static int vsp1_du_pipeline_setup_rpf(struct vsp1_device *vsp1, > /* Setup the BRx source pad. */ > static int vsp1_du_pipeline_setup_inputs(struct vsp1_device *vsp1, > struct vsp1_pipeline *pipe); > -static void vsp1_du_pipeline_configure(struct vsp1_pipeline *pipe); > - > static int vsp1_du_pipeline_setup_brx(struct vsp1_device *vsp1, > struct vsp1_pipeline *pipe) > { > @@ -541,50 +583,6 @@ static int vsp1_du_pipeline_setup_output(struct vsp1_device *vsp1, > return 0; > } > > -/* Configure all entities in the pipeline. */ > -static void vsp1_du_pipeline_configure(struct vsp1_pipeline *pipe) > -{ > - struct vsp1_drm_pipeline *drm_pipe = to_vsp1_drm_pipeline(pipe); > - struct vsp1_entity *entity; > - struct vsp1_entity *next; > - struct vsp1_dl_list *dl; > - struct vsp1_dl_body *dlb; > - unsigned int dl_flags = 0; > - > - vsp1_pipeline_calculate_partition(pipe, &pipe->part_table[0], > - drm_pipe->width, 0); > - > - if (drm_pipe->force_brx_release) > - dl_flags |= VSP1_DL_FRAME_END_INTERNAL; > - if (pipe->output->writeback) > - dl_flags |= VSP1_DL_FRAME_END_WRITEBACK; > - > - dl = vsp1_dl_list_get(pipe->output->dlm); > - dlb = vsp1_dl_list_get_body0(dl); > - > - list_for_each_entry_safe(entity, next, &pipe->entities, list_pipe) { > - /* Disconnect unused entities from the pipeline. */ > - if (!entity->pipe) { > - vsp1_dl_body_write(dlb, entity->route->reg, > - VI6_DPR_NODE_UNUSED); > - > - entity->sink = NULL; > - list_del(&entity->list_pipe); > - > - continue; > - } > - > - vsp1_entity_route_setup(entity, pipe, dlb); > - vsp1_entity_configure_stream(entity, entity->state, pipe, > - dl, dlb); > - vsp1_entity_configure_frame(entity, pipe, dl, dlb); > - vsp1_entity_configure_partition(entity, pipe, > - &pipe->part_table[0], dl, dlb); > - } > - > - vsp1_dl_list_commit(dl, dl_flags); > -} > - > static int vsp1_du_pipeline_set_rwpf_format(struct vsp1_device *vsp1, > struct vsp1_rwpf *rwpf, > u32 pixelformat, unsigned int pitch) > -- > Regards, > > Laurent Pinchart > > -- Kind Regards, Niklas Söderlund