From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F38FD42E01A; Fri, 15 May 2026 09:12:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778836338; cv=none; b=RCaC8C6yVTTfgFIowzx4t6mP5QVJe2DOvm2SuxpA/mACOlXK/CdmGOmS7294vXIZpcToXXFMgpzFe7VUvelAvpRqCxXMS7MWyT5VeyimIAggHv0Ag8SxUucNY/KQS4nQQ0UHhzCE+jvWCJ4BgADA8eg4UU3Jrwwf765wk8AM8vw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778836338; c=relaxed/simple; bh=XVR3ojhWkkxsLCom5Bq0SC+fLWXsPrYwVWwe2bgRWsE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=F32z+mNn7lDJzXA7WzXCBvb3pxDCWg2xpex1aLwyCqYc+0hKcnnZtlJJ0YJgpnWKaEq4M7k85RKMWpGs7I45Q9EaetSG8kndUfpb8mrAWvRr9qJGhLuEOosagHDkhBcVjlbVZ/cEqqcD3HTKjf/ABw8f0Zzxh89FAGKGBWMo93A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HiYmuv+1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HiYmuv+1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 778DFC2BCB8; Fri, 15 May 2026 09:12:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778836337; bh=XVR3ojhWkkxsLCom5Bq0SC+fLWXsPrYwVWwe2bgRWsE=; h=From:To:Cc:Subject:Date:From; b=HiYmuv+1L1CeTy9Xiuv2hCGHbHza2zJneMRA5dprt+1LPI4War6K24QhCL5nIY3CB wey4qRBXYup6FrQXfzx91PYNkk/+kUit3QjOLIXLHLUc2aOrBZycf4/bXn5q1B3eBx nerubRkubruJ7qStPHkRiZ8AhtFV9EmY1XMNdmE8EP043GcLgWE3Gm7HojumRoz8fw 678ABvg4fsxhcxBjn9OiGdk5INDz5b/xys2B84ZsK425iIXlU5tBUjGqYOyrz/bQLi kQywVmKcFzJgkk++o6J3aAtBYIR2729AEj/RR11Td7xnmNFPbgLHjxzaC3H4lphgS0 +33G6p7ugFEZg== From: Arnd Bergmann To: Bin Du , Nirujogi Pratap , Mauro Carvalho Chehab , Sultan Alsawaf , Svetoslav Stoilov , Sakari Ailus , "Mario Limonciello (AMD)" Cc: Arnd Bergmann , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: platform: amd: add DRM_AMDGPU dependency Date: Fri, 15 May 2026 11:12:06 +0200 Message-Id: <20260515091212.581789-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnd Bergmann With DRM_AMDGPU=m and DRM_AMD_ISP=y, it is possible to configura VIDEO_AMD_ISP4_CAPTURE as built-in, but that fails to link: aarch64-linux-ld: drivers/media/platform/amd/isp4/isp4_interface.o: in function `isp4if_gpu_mem_alloc.isra.0': isp4_interface.c:(.text+0x1d0): undefined reference to `isp_kernel_buffer_alloc' aarch64-linux-ld: drivers/media/platform/amd/isp4/isp4_interface.o: in function `isp4if_dealloc_fw_gpumem': isp4_interface.c:(.text+0x26c): undefined reference to `isp_kernel_buffer_free' Add a dependency on the tristate DRM_AMDGPU symbol in addition to the boolean DRM_AMD_ISP=y, so this can only be built-in if the ISP driver is also linked into the kernel itself. Fixes: 9a54c285630c ("media: platform: amd: Introduce amd isp4 capture driver") Signed-off-by: Arnd Bergmann --- drivers/media/platform/amd/isp4/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/amd/isp4/Kconfig b/drivers/media/platform/amd/isp4/Kconfig index 55dd2dc453a2..9d1927af1cb8 100644 --- a/drivers/media/platform/amd/isp4/Kconfig +++ b/drivers/media/platform/amd/isp4/Kconfig @@ -2,7 +2,9 @@ config VIDEO_AMD_ISP4_CAPTURE tristate "AMD ISP4 and camera driver" - depends on DRM_AMD_ISP && VIDEO_DEV && HAS_DMA + depends on DRM_AMDGPU && DRM_AMD_ISP + depends on HAS_DMA + depends on VIDEO_DEV select VIDEOBUF2_CORE select VIDEOBUF2_MEMOPS select VIDEOBUF2_V4L2 -- 2.39.5