From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EB5F38C421 for ; Fri, 29 May 2026 05:06:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780031216; cv=none; b=NJUQ3sMEyHMd7IGv5WHB9sIbUROYXtcllqJpuME/NEUBcL2+FMj6iKfqnpvQEMhIB9wei4HdFH53z2PToa6kgY47mvnlp45W29wxcU8xOOQfVQgUiinEFxiCSnJZF7fws8zEFnlZychJUZGOxST1BDKC168ovPyaKst95om+X3c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780031216; c=relaxed/simple; bh=C1teFxbkmqUEpKxwsk6TrhvgKguX4DU7tWyrjp5RwxM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pqqYmo2v7BqQt1xzhSKOm9AoscqD3nnUAFCBl7nk9W5CJcXP06PRqOJeKgO41eU/Kf43HfpL31glKEA9Z6rBlyNl9yLmT6OxU39hfE5H3bP33kZpBsQ7BbHGDRP7sxSYa0u3aZV/r7MPHIoleHb1qMLDquTHUG3bhr7/IXjGKjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wt6zo7iz; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wt6zo7iz" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4891e5b9c1fso117038035e9.2 for ; Thu, 28 May 2026 22:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780031214; x=1780636014; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UBJ2gsXIs8bElFnwreFyB5fEKwJ7W4oMcY7a30B+xik=; b=Wt6zo7izN3UnLg8F6XJnk0DjPQxA1OBt4l0g4xu/8phBZLiHqkcHZsav8LMib6RCJ7 g6SKwk4BzchQykMQqLemjB9mejpTVj+1qIBfPsYQ+plrDSIwuMojBjg3BLZ2YjHkaONq k50PHc88AASs1oqOr192H5w5FDJR/Ote4RR1drrSvKWUWv4d6imFn51+rOOpNBP4sbbj iH3Pg6WnrGdLNVUa+K7b0/gT0q1Al35Tsb8uRV7aE62mZtz4PYsCUWfMCBvFILsXxjbT F6CHfY4x4CyMM476p++E/zR7b/Gv27GdxfnMlE2/9PW8dM+2z00F6BsCOa/1efbedbSP aTYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780031214; x=1780636014; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UBJ2gsXIs8bElFnwreFyB5fEKwJ7W4oMcY7a30B+xik=; b=Ho+jlVagB1wHVmf3Kj21xDYvqJBRw6ir03uv253/nccMzI2UlMXl0vI/uyjoxP7Vn9 BPgodGdU4kGGUjh2txvZk9bib5FDPtKo6Ep27yaBwVh84JlYgNofuCjWXKhfFw1LUtbI /+JokNWH4oHUAfm1RTNF2IcJcq5/vi4zx0FXvwCyZdsGBTTIWzZbETFjmOfZQAtI+83+ +VBXDHpwuvFxyBLQtclS8DS56yiGdpF1mgn5rlqvqLZbN9/MpeJSKjh1tGCydQaHuvcA DR4RDOlgFIfZGZuvKB8BlrIwBjEJej3Jmhr9Hn4ZjtX2vC+sJXr+Np7MUBDcFmQoBkYu 7IpQ== X-Forwarded-Encrypted: i=1; AFNElJ9WJ130XpJKEZlR0Gg6GqNHUifSV4nh9DrxEA3pHLVcB6OP9gJ6lGHevTI7gZQ2Oy0JlZC6bzG/ymSc9w==@vger.kernel.org X-Gm-Message-State: AOJu0YxQQUopleFQpEaqVkyKORiSMpjm3L9Z2Tu98tIUEPYHQaQpF8ad M4Rc3iQJMNEjC3KbeRT6GGG+8lLKJ8UpO6ZMhfY0IfyDFA8jhSrk1bJv X-Gm-Gg: Acq92OGmucIf3jBiy5Aj7PIJhu5nf8wLf2pnNSKfQCdIlspkP+sAJbbeboD9zQeHCQq mHLPXJEghTy340XQbNL3heoF7Lg+8SiORAzV8woQx2iL90VA0u6i8DoL49NtWwiNxblWy7T8GKv mMBG6/MHvjPbu42OnDDnMOUap8yt5nnGKF1TNA/khkVcURElTj5gA51+WosDrJDgZsNKsMFosk1 c8PWiZv92RkGYcoRUNQs4mP0JEFig4rX5Tdw07oTvk5zeCzFbdDGJ5CqU0rfvfjZc9ifCvV6rN5 96fgFrxd044R40h+ZDvRVEO3iJJax48jXlTihBUUHZBYpBHV4se9OWS30iGjbsgwi+apERfUuLp OypQ6pA5wTIYMHIu47+4NUkTvw1g4G2jMJM+/etbz4IpovVBRrkXiXyqB+PirstnhtDUViU48rq /Q5CYAzGlR9pAu6yPd3ZNAlbxbMZyA/yxNNPjbtQZ7dnkLrdi64WRx4BjSo0oEPpFxsZgPSfGbI NNsQ2u7bsBvJ30tIXTA9Q== X-Received: by 2002:a05:600c:4e0d:b0:490:5368:743 with SMTP id 5b1f17b1804b1-4909c0c8fcemr21786775e9.32.1780031213383; Thu, 28 May 2026 22:06:53 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef34c3081sm913830f8f.15.2026.05.28.22.06.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 22:06:53 -0700 (PDT) From: David Carlier To: Daniel Scally , Jacopo Mondi Cc: Mauro Carvalho Chehab , Hans Verkuil , Nayden Kanchev , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Carlier Subject: [PATCH v2] media: mali-c55: fix integer overflow in scaler factor calculation Date: Fri, 29 May 2026 06:06:49 +0100 Message-ID: <20260529050649.14109-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260529024429.6942-1-devnexen@gmail.com> References: <20260529024429.6942-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The scaling factors are computed by multiplying the crop dimension by the Q4.20 unit (1 << 20) and dividing by the output dimension. The results are stored in u64, but both operands are 32-bit, so the product is evaluated in 32-bit arithmetic and only widened afterwards. Crop dimensions may be up to 8192. Once a dimension reaches 4096 the product overflows 32 bits and wraps (zero at exactly 4096), programming a corrupted scaling increment and corrupting the downscaled output. Define the fixed-point unit as unsigned long long so the multiplication is done in 64-bit arithmetic. Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver") Cc: stable@vger.kernel.org Signed-off-by: David Carlier --- v2: Use the BIT_ULL() macro instead of an open-coded (1ULL << 20) (checkpatch). --- drivers/media/platform/arm/mali-c55/mali-c55-resizer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-resizer.c b/drivers/media/platform/arm/mali-c55/mali-c55-resizer.c index c4f46651dcee..6706939b4a90 100644 --- a/drivers/media/platform/arm/mali-c55/mali-c55-resizer.c +++ b/drivers/media/platform/arm/mali-c55/mali-c55-resizer.c @@ -15,7 +15,7 @@ #include "mali-c55-registers.h" /* Scaling factor in Q4.20 format. */ -#define MALI_C55_RSZ_SCALER_FACTOR (1U << 20) +#define MALI_C55_RSZ_SCALER_FACTOR BIT_ULL(20) #define MALI_C55_RSZ_COEFS_BANKS 8 #define MALI_C55_RSZ_COEFS_ENTRIES 64 -- 2.53.0