Re: [PATCH v5 07/14] media: mediatek: vcodec: support 36bit iova address

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch references an undeclared identifier `MTK_VDEC_MT8196`, causing a build failure and breaking `git bisect`.
--

commit 1d69905fbcb6b87b34af91dd5fb8d705e10184c1
Author: Yunfei Dong <yunfei.dong@mediatek.com>

media: mediatek: vcodec: support 36bit iova address

Need to set dma mask to support 36bit iova address for decoder
hardware can use 36bit address to decode for mt8196.

> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c
> index ce17b649022f7..68759db6f8d1c 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c
> @@ -390,6 +390,13 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
>  		return -ENODEV;
>  	}
>  	dma_set_max_seg_size(&pdev->dev, UINT_MAX);
> +	if (dev->chip_name == MTK_VDEC_MT8196) {
                              ^^^^^^^^^^^^^^^

[Severity: Low]
Does this code compile on its own? It appears that MTK_VDEC_MT8196 is not
defined in this commit, which would cause a build failure and break git bisect
at this point in the series.

> +		ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(36));
> +		if (ret) {
> +			dev_err(&pdev->dev, "Failed to enable 36-bit DMA: %d\n", ret);
> +			return ret;
> +		}
> +	}
>  
>  	dev->fw_handler = mtk_vcodec_fw_select(dev, fw_type, DECODER);
>  	if (IS_ERR(dev->fw_handler))

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260603084045.17488-1-kyrie.wu@mediatek.com?part=7