Re: [PATCH v17 1/6] rust: drm: gem: shmem: Fix Default implementation for ObjectConfig

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect use of `#[inline(always)]` annotation for `ObjectConfig::default()`.
--

commit 974110b1b618554fdff7106e2b5a8152da0f6df4
Author: Lyude Paul <lyude@redhat.com>

rust: drm: gem: shmem: Fix Default implementation for ObjectConfig

This commit replaces the derived Default implementation for ObjectConfig
with a manual one. This avoids the requirement for the generic type T
to also implement Default, since T is only used as a reference type here.

> diff --git a/rust/kernel/drm/gem/shmem.rs b/rust/kernel/drm/gem/shmem.rs
> index 34af402899a0e..084b798ce795b 100644
> --- a/rust/kernel/drm/gem/shmem.rs
> +++ b/rust/kernel/drm/gem/shmem.rs
[ ... ]
> @@ -53,6 +52,16 @@ pub struct ObjectConfig<'a, T: DriverObject, C: DeviceContext = Registered> {
>      pub parent_resv_obj: Option<&'a Object<T, C>>,
>  }
>  
> +impl<'a, T: DriverObject, C: DeviceContext> Default for ObjectConfig<'a, T, C> {
> +    #[inline(always)]
> +    fn default() -> Self {

[Severity: Low]
This isn't a bug, but should this be annotated with #[inline] instead of
#[inline(always)]?

According to the Rust subsystem guidelines, #[inline(always)] is reserved for
functions using build_assert!() that depend on function parameters, while
#[inline] is meant for small abstraction functions like ObjectConfig::default().

> +        Self {
> +            map_wc: false,
> +            parent_resv_obj: None,
> +        }
> +    }
> +}
> +
>  /// A shmem-backed GEM object.
>  ///
>  /// # Invariants

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260603195210.693856-1-lyude@redhat.com?part=1