Re: [PATCH v7 1/2] dt-bindings: media: i2c: add aptina,mt9m113

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing schema reference to video-interface-devices.yaml, preventing the use of standard camera properties.
--

commit b027ca2312842a35bda1f84dd148c51033735826
Author: Herman van Hazendonk <github.com@herrie.org>

dt-bindings: media: i2c: add aptina,mt9m113

This commit adds the device tree binding for the Aptina MT9M113 1.3
megapixel CMOS digital image sensor. It describes the I2C address,
power supplies, clocks, optional GPIOs, and the CSI-2 endpoint.

> diff --git a/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml b/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml
> new file mode 100644
> index 0000000000000..72b827c47b1d2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - vdd-supply
> +  - vddio-supply
> +  - vaa-supply
> +  - port
> +
> +additionalProperties: false
> +
> +examples:

[Severity: Medium]
Since this sensor is used as a front-facing tablet camera, will hardware
integrators need to specify mounting properties like rotation or orientation?

With additionalProperties set to false at the top level and no reference to
the common video interface schema, standard camera properties will be
rejected by dt_binding_check.

Would it make sense to include a reference to video-interface-devices.yaml
using an allOf block to allow these standard properties?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260607-submit-media-mt9m113-v7-0-5da397a3d2a5@herrie.org?part=1