From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C38A533F8CA for ; Mon, 22 Jun 2026 17:34:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782149644; cv=none; b=LTybMjZ67NoJ98t9G47kAWeudx66BYacXi1g7re0wmA92eoAdrHfmKkJnyihsL6FeiMSJ8BF6JiNmU6sHkgpsFRupvhi5Ks5YaIxEY7pTzdwDY2El6VslpO7YuY/e4Rc71olrtn2HqtFCW2IbHHLa1gIC4g0cxRmDerYg1o3RPI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782149644; c=relaxed/simple; bh=UGtdfUu+IvCc/FTRQGqWK5e4uHvzgKdZIdr7QuD80uo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iVQIPIXBYgot1TxCQrzITtfyrY211SpNewRSC5qR4GWqzVIr57PF1WyLpuEGRMKCHQEQSeDND9poN1UgyULE1F+zoudXRvFU4UdNYl1VasF6tDOuL2Xo9j+5XjQaPxrJEVpWw9EOyxguxqnINokqtDlqXQC/NIuMMLzU8fAeNm0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o5rzdukn; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o5rzdukn" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-845537740ddso1666443b3a.0 for ; Mon, 22 Jun 2026 10:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782149643; x=1782754443; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PjCDSDX5rdJBNz6pw3IrU3j4G9qavxrdCNiYTuZgJ2I=; b=o5rzduknYrxsB5iY7NM/RUSN54M0jmQWq6293sF8XCbKX6hy7xZ+8QOPFPIAoKoYCg e3UAjN93W9u+9XixCiTm/q3g4cSkl5kIZ5VtmUKORcDXnNMgg0j9NM0vGtPq3Fi8Knoe fBuKg82RIQqpCDnAs3XzhIxrMb2KKR//CgJP58Gb23BtdWGg6yCJhsiE/d1FgCAyb/uy 8GdZeS0OsgH/YiQDuYjyDL6A50qR4ejjxQFlGDuPRtQYNGzfhCLLIvkbyKas1UfjU0kO LvKkIbDcLs5zZ5+ymZSRghA7r61hP6I9VRc/xJZ+dIP4wgqDbfwliD/lpUvnJDvfQf+E ky2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782149643; x=1782754443; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PjCDSDX5rdJBNz6pw3IrU3j4G9qavxrdCNiYTuZgJ2I=; b=Rdxo/P//vjZ16iGwx/s3W6vVPryFKWi+L6cUyBVGYNVsZOp5X32TmECrbe3BC814BL XDJHY9C7eSmJqPI7JkKR57WVZc1pKW0mCvgz+4lHx5JhbMh0ELaPXbXG9/Maes0WRd56 SZhlW4o3DlR7ronnmH9RT7ilzE0Ejkmin20AMkfQlr9JrOok5YuS/1cz1noUrhQ6i4gd 0mdGzehwKP3YCbc3ePROF+WubsKy0HaMz+3eGU1brvzWPOxKKnNnqW0pEWUiDra1lI9P YPUasGyt6kccnbmHvNYBjDnH18wlEuDFCtkrtf9wnTIFQfXDkY/gDHHZnOGOx0ELqsK1 k1yw== X-Gm-Message-State: AOJu0YwpBNhfqporefxozlyyn9eYrbrH6vaGOVtC+xVX1Q9QYXLrMRJe 7cv1yfCt3DtiB1XdZV1HWBDkFHk0/8AK8QGA7HpNwcxm1R5TOHFniS8SIOXObbpp X-Gm-Gg: AfdE7cntXM+K+93pFP/hL8PJjSd3oMNhUqFTdTIkeE/VNKw8YMto0tri89JLa/nJj1r F+7GUSjByjM0P5danZDAgLqU59nWBidQhIe62ksd03nV6TRX+QsUa2z4zCEVT1Wg1c4HhkE93XL /EBdGKPQPRJzqn/o4efZqbIziDOM7caDPGJDxnlQP+NQyVXyVSR1pxL9s3wM4xoWcFv/+9f9MrQ uPqIeksry/LRBhbmiCixFdolgDQo2IuA8BYxOpVJdxbDdVNmttCo0ncXpzqKC/vQ/lz288SSUg8 NoPEN0nWkDs5UQsPnb1I+cBn4iyuC0aqFCRKUK7yhTKgLCUpfGa7g8nzfGgY7e36+VoxISy2zx2 MgtU5b51Ezy82vRq6hC4qMzpd7Y1wjKPNXnC27Bl6Wo/k0paudbZqonw9wYykCuO5bIupU5by6u zHHTCVgK99bASNxfusjV1gVUgyMA+8MgSNf9xArxCl7g== X-Received: by 2002:a05:6a00:2d8b:b0:845:44c7:2fdd with SMTP id d2e1a72fcca58-845508bb8camr17065797b3a.34.1782149642920; Mon, 22 Jun 2026 10:34:02 -0700 (PDT) Received: from localhost.localdomain ([49.207.234.96]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564ebd123sm7670753b3a.47.2026.06.22.10.33.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 22 Jun 2026 10:34:02 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org Cc: jacopo.mondi@ideasonboard.com, laurent.pinchart@ideasonboard.com, kieran.bingham+renesas@ideasonboard.com, mchehab@kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Biren Pandya , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Geert Uytterhoeven , Magnus Damm Subject: [PATCH v3 3/4] media: renesas: rcar-core: Add missing media_entity_cleanup() Date: Mon, 22 Jun 2026 23:03:38 +0530 Message-ID: <20260622173334.60491-9-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260622173334.60491-6-birenpandya@gmail.com> References: <20260622173334.60491-6-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The probe error path and remove function are missing calls to media_entity_cleanup(). Add a dedicated err_entity label so the cleanup is only invoked when media_entity_pads_init() has actually succeeded. This ensures that the teardown logic properly mirrors initialization. Signed-off-by: Biren Pandya --- drivers/media/platform/renesas/rcar-vin/rcar-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-core.c b/drivers/media/platform/renesas/rcar-vin/rcar-core.c index c8d564aa1eba..5bae8eb0ee19 100644 --- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c +++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c @@ -1211,7 +1211,7 @@ static int rcar_vin_probe(struct platform_device *pdev) ret = rvin_create_controls(vin); if (ret < 0) - goto err_id; + goto err_entity; switch (vin->info->model) { case RCAR_GEN3: @@ -1246,6 +1246,8 @@ static int rcar_vin_probe(struct platform_device *pdev) err_ctrl: rvin_free_controls(vin); +err_entity: + media_entity_cleanup(&vin->vdev.entity); err_id: rvin_id_put(vin); err_dma: @@ -1270,6 +1272,7 @@ static void rcar_vin_remove(struct platform_device *pdev) rvin_group_put(vin); rvin_free_controls(vin); + media_entity_cleanup(&vin->vdev.entity); rvin_id_put(vin); -- 2.50.1 (Apple Git-155)