From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DB1136A367; Wed, 24 Jun 2026 19:17:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782328636; cv=none; b=q+6mmhkVzxefRpLd3YgDGGcYyRQVDHmYajyR81QqkW+Uu5PCRuRFFcHvnBzj36RBXM6IA6KGVWTbH+iwg2c+dDd47zvqg3vPQk8C6tIBXl/WvXYYiMv+1NroEQnWyFyrl93o4F+RKhsD256Kz7WQk3cZJyCL1rwh7H+NAqeMuXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782328636; c=relaxed/simple; bh=W+NUk2llCaCs56ZgNCLMgYkpcn4ETSuJ2aIowCznhpU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jKGL5ag8U/vwKm1wUMjA5rweGOAAsB7JubtsslFfzGMxGECux66EHdoKPDWtmsepXIJw4EaPKTKTSy1rMAqn83MFugqL/lgflWJupYmYQnpxRx028nBiEydSph3++RBmS8OnpzhhgQVI1BY93l8Ntu1qUpMwZ127KNbgGQ4OBVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=LXERi1N0; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LXERi1N0" Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 85E47FC7; Wed, 24 Jun 2026 21:16:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782328594; bh=W+NUk2llCaCs56ZgNCLMgYkpcn4ETSuJ2aIowCznhpU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LXERi1N0Du4BVG2CSumtpg3Mo5sQj9/zNmVNSw35udWQOhje5cD7PImBHo3YMh6IY eXJA/ds2kxcGS2c2HKnAzWnBP99d2WPbU4g+fVf09wFEMJbMOtjAN6LiJ5gdZ9Z5mN I+zSOo0fgU79Teg6Z17Oeuw+Jq0sOq5k0f+JPrto= Date: Wed, 24 Jun 2026 22:17:12 +0300 From: Laurent Pinchart To: Frank.Li@oss.nxp.com Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Mauro Carvalho Chehab , Dafna Hirschfeld , Heiko Stuebner , Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , driver-core@lists.linux.dev, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, imx@lists.linux.dev, Guoniu Zhou , Frank Li , Guoniu Zhou Subject: Re: [PATCH v2 4/4] media: qcom: camss: use fwnode_graph_for_each_endpoint_scoped() to simplify code Message-ID: <20260624191712.GF851255@killaraus.ideasonboard.com> References: <20260624-fw_scoped-v2-0-0a8db472af4a@nxp.com> <20260624-fw_scoped-v2-4-0a8db472af4a@nxp.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260624-fw_scoped-v2-4-0a8db472af4a@nxp.com> On Wed, Jun 24, 2026 at 01:00:12PM -0400, Frank.Li@oss.nxp.com wrote: > From: Frank Li > > Use fwnode_graph_for_each_endpoint_scoped() to simplify code. > > No functional changes. > > Reviewed-by: Guoniu Zhou > Reviewed-by: Loic Poulain > Reviewed-by: Andy Shevchenko > Signed-off-by: Frank Li Reviewed-by: Laurent Pinchart > --- > change in v2 > - fix typo simplify > - collect andy, gouniou and loic's review tags > --- > drivers/media/platform/qcom/camss/camss.c | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c > index 2123f6388e3d7..23f3cc30a15a5 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -4793,30 +4793,23 @@ static int camss_parse_endpoint_node(struct device *dev, > static int camss_parse_ports(struct camss *camss) > { > struct device *dev = camss->dev; > - struct fwnode_handle *fwnode = dev_fwnode(dev), *ep; > + struct fwnode_handle *fwnode = dev_fwnode(dev); > int ret; > > - fwnode_graph_for_each_endpoint(fwnode, ep) { > + fwnode_graph_for_each_endpoint_scoped(fwnode, ep) { > struct camss_async_subdev *csd; > > csd = v4l2_async_nf_add_fwnode_remote(&camss->notifier, ep, > typeof(*csd)); > - if (IS_ERR(csd)) { > - ret = PTR_ERR(csd); > - goto err_cleanup; > - } > + if (IS_ERR(csd)) > + return PTR_ERR(csd); > > ret = camss_parse_endpoint_node(dev, ep, csd); > if (ret < 0) > - goto err_cleanup; > + return ret; > } > > return 0; > - > -err_cleanup: > - fwnode_handle_put(ep); > - > - return ret; > } > > /* -- Regards, Laurent Pinchart