From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Frank.Li@oss.nxp.com
Cc: linux-media@vger.kernel.org, Frank Li <Frank.Li@nxp.com>,
Guoniu Zhou <guoniu.zhou@nxp.com>,
Dong Aisheng <aisheng.dong@nxp.com>,
Jacopo Mondi <jacopo@jmondi.org>,
imx@lists.linux.dev
Subject: Re: [PATCH] media: nxp: imx8-isi: Drop unneeded downscaling factor clamping
Date: Mon, 29 Jun 2026 23:11:30 +0300 [thread overview]
Message-ID: <20260629201130.GJ3054459@killaraus.ideasonboard.com> (raw)
In-Reply-To: <178276171937.2424554.17141585139727533269.b4-ty@b4>
Hi Frank,
On Mon, Jun 29, 2026 at 03:35:27PM -0400, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
>
>
> On Wed, 20 May 2026 22:27:38 +0200, Laurent Pinchart wrote:
> > The total scaling factor including bi-linear downscaling and decimation
> > is clamped to 16. The bilinear factor calculation therefore produceds
> > values guaranteed not to exceed the maximum factor of 2.0. The clamping
> > is unneeded, drop it.
> >
> > Note that the ISI_DOWNSCALE_THRESHOLD value of 0x4000 is incorrect, as
> > that would be a factor of 4.0. This was inconsequential given that the
> > computed factor never exceeded 0x2000.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] media: nxp: imx8-isi: Drop unneeded downscaling factor clamping
> commit: 5f074ef2f1fa19d8730f5c0329ff2f7633639875
Please note that you are not supposed to push patches to the media
committers tree if you're not listed in the MAINTAINERS file for the
driver (as listed as a Linux media submaintainer for the specific part
of the subsystem).
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2026-06-29 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 20:27 [PATCH] media: nxp: imx8-isi: Drop unneeded downscaling factor clamping Laurent Pinchart
2026-06-29 19:35 ` Frank.Li
2026-06-29 20:11 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629201130.GJ3054459@killaraus.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=Frank.Li@nxp.com \
--cc=Frank.Li@oss.nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=guoniu.zhou@nxp.com \
--cc=imx@lists.linux.dev \
--cc=jacopo@jmondi.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox