Linux Media Controller development
 help / color / mirror / Atom feed
From: Shih-Sheng Yang <yshihsheng@gmail.com>
To: laurent.pinchart@ideasonboard.com
Cc: hverkuil+cisco@kernel.org, kees@kernel.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	mchehab@kernel.org, yshihsheng@gmail.com
Subject: Re: [PATCH] media: v4l2-dev: fix media controller registration error handling
Date: Tue, 30 Jun 2026 17:54:56 +0800	[thread overview]
Message-ID: <20260630095456.1745545-1-yshihsheng@gmail.com> (raw)
In-Reply-To: <20260626192257.GA2894880@killaraus.ideasonboard.com>

Hi Laurent,

Thank you for the review.

I've addressed this in v2 by moving the NULL check into
media_devnode_remove() and by using device_unregister() in
__video_register_device(), as device_register() has already succeeded
there.

I also checked the other media_devnode_remove() callers. I didn't find
another caller with the same failure pattern or an immediate risk that
requires changing the helper API. Since changing media_devnode_remove()
to take a pointer-to-pointer would affect a wider set of callers, I have
left that out of v2. I can add it if you prefer.

Regards,
Shih-Sheng

  reply	other threads:[~2026-06-30  9:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25 19:39 [PATCH] media: v4l2-dev: fix media controller registration error handling Shih-Sheng Yang
2026-06-26 19:22 ` Laurent Pinchart
2026-06-30  9:54   ` Shih-Sheng Yang [this message]
2026-06-30 10:24     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260630095456.1745545-1-yshihsheng@gmail.com \
    --to=yshihsheng@gmail.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=kees@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox