From: Linus Walleij <linusw@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Nayden Kanchev <nayden.kanchev@arm.com>,
Konstantin Babin <Konstantin.Babin@arm.com>,
Daniel Scally <dan.scally@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, Linus Walleij <linusw@kernel.org>
Subject: [PATCH] media: v4l2-ctrls: document expected validation scope
Date: Wed, 01 Jul 2026 10:11:20 +0200 [thread overview]
Message-ID: <20260701-v4l2-doc-v1-1-9cce64b7a1c2@kernel.org> (raw)
After discussion on the mailing list it became clear that these
validations are not expected to be exhaustive.
Link: https://lore.kernel.org/linux-media/20260629133209.GG3054459@killaraus.ideasonboard.com/
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
index b8698b85bd80..58184b6e386f 100644
--- a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
+++ b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
@@ -118,6 +118,18 @@ correct. This prevents the situation where only some of the controls
were set/get. Only low-level errors (e. g. a failed i2c command) can
still cause this situation.
+The validation of controls is not expected to be exhaustive, for example
+custom controls under ``V4L2_CTRL_CLASS_USER`` would become very voluminous.
+The expected behaviour is to reject settings that could:
+
+1. Pose stability issues, such as turning the hardware unresponsive requiring
+ a hard reset, such controls must be rejected.
+
+2. Pose security issues, such as compromising unrelated kernel-contained
+ data to userspace.
+
+Extended validation of control values should be performed in userspace.
+
.. tabularcolumns:: |p{6.8cm}|p{4.0cm}|p{6.5cm}|
.. c:type:: v4l2_ext_control
---
base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
change-id: 20260701-v4l2-doc-c60195d38d00
Best regards,
--
Linus Walleij <linusw@kernel.org>
next reply other threads:[~2026-07-01 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 8:11 Linus Walleij [this message]
2026-07-01 8:50 ` [PATCH] media: v4l2-ctrls: document expected validation scope Jacopo Mondi
2026-07-01 9:03 ` Hans Verkuil
2026-07-01 10:59 ` Linus Walleij
2026-07-01 11:16 ` Hans Verkuil
2026-07-01 15:05 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260701-v4l2-doc-v1-1-9cce64b7a1c2@kernel.org \
--to=linusw@kernel.org \
--cc=Konstantin.Babin@arm.com \
--cc=dan.scally@ideasonboard.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nayden.kanchev@arm.com \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox