From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6051739F19F for ; Sat, 4 Jul 2026 08:31:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783153904; cv=none; b=HiwMl0IbynyIUM6932LlL3EbpW5xZUdSYUkn7+NQYjKTs2wz/WaeYxOwyf4C1Z+BOjRRMYsYWTvznGQYe+Ebtb85PFjqWVEzlfWsYFrw/KRV7SvZAIdrs1vuA7Ik/kawTIedHccVdG9Cb7U0DcMbbnREMLsO5AjMSCgltep88zk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783153904; c=relaxed/simple; bh=y6mNeTzCyc08DlRJ6m8uHGdrjccntn+S5pSqgS1q7kY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a9a6kKy9WCxwzNTrldVffOsvjsFNCAv7vP0BEKPBBMVE+nZoyrxVpX63aAihkW/Cci2nSEHPfDMbabXT+1a8JOdyaRVVSaKgbakWHRrY0dDgn71ET071l6ookPIiTTGixCeE7o5v7eNs1aiKGlAt9SGiJ+tWvmsp5VQzGYaPREo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KUf7BNMH; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KUf7BNMH" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-383cb94f742so295030a91.3 for ; Sat, 04 Jul 2026 01:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783153892; x=1783758692; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6SKjOfWBF6wFcd/KZhxMJdBWrz9gubI4LNJ7uJpHMQs=; b=KUf7BNMHz0ksjbzDNtXOeoCoo5wGaRDIdW/Tw1FrosXBIn9S/fPs8qwal4qxBQtnJI QpLns/KVgMACHn5e5XYyFZx1U1TfzckJq7eqvUzd/JWa2dgvPKDTYqYtk1YTSRmLwJvm UKiQfXUOKQNgqh7JyX8QoznocBCBBozAMnPObVwg5kE/1WOuS1w6sDMWgRp3TBxEIp+y Z2OdfxhL/zMpMp3dNFUIDcAKeWdYLxdNlsNu/wt1UMbw2nyATW3daj9xT1WgcqTFcmAd tEngJeiSkzzMTOt/WJRFeOdjQ6rKySiKBPPUeDyt96AfIdgYss4LQi/J4C6HnNOoUb5Q uI7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783153892; x=1783758692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6SKjOfWBF6wFcd/KZhxMJdBWrz9gubI4LNJ7uJpHMQs=; b=Hxh/qPrTCj6j8eo/v/53cEmOxqLZ5Vt36kffXVXTSFJBsE00pI+na/ZXaDOFO0dibx hUYj58yG07vv4RQlGJZOXfcVkduROw3ZKInh5q5QvzOg/Cu/f7GP9b2sy3NgxspwtipR yBz1TjBT5ripTzh4XidzoV4OSQKoGM/cFJCVHZvuvrOOmLHp2DpM3SN7ytVjg6aE05oC rCU/u+4aFe42a20vUy/BNE7168wffLCLr11Du90hNUwHIJOC1by3sXZjROuhOEGKCtUP 6pLKsEpqv7wQSVFGBmQwwpTREc4qXY1ZiysbS6h3yilB3IGM1qczEKNIFBVMvuPAaUkk GeAw== X-Forwarded-Encrypted: i=1; AHgh+RqtaNabwRpyLIfgSLBm7NCRDmNWKrK5s6gQSF8fPnhCSsTgYd3q74MTjTpoWVRlxtzmWkF7Zb7Gm0iatg==@vger.kernel.org X-Gm-Message-State: AOJu0YyT+lWK+mw2KqSR2DuSFFJTAFoAH9ZWBoCUovc4gxNWFLyeLzFu h0uUjoDH5RH1mTz6NyJRT4pq68BrMSJx3EbTK5VKCyHbKUuK8raZjkyD X-Gm-Gg: AfdE7cnxZ292m24QqPDGCSL8q8aHpXhwK1aHfm6loJ0kHi0w99CYx6yepr4+iW8h1l1 Dt0nhNfDNUJR7WL2LREr7LLbwh24bX//77lJIkDU0G9SKTQ1WK1tMINOjvIaMnsfBsNRQQOhbZr hXK/dJ07JHeecD0LlrmKWuqCM+395Oxm4Z1vQVdc0ubmaIDqANaVUzGF1LrVmnz6YRkaM9VAJlz ylOFElofJdDnJbDp/99ce0SNUmm5gQXxF3q/h+Puyj5tf3PmWISR2ej3h6IVtoOwwWoVJidd//i 9+oVF//c9PGzflq0z53gLyw5VknwkTtXJlzH+ZW9pk2AyTOvL1Ky4eiGG0FAaIsf43t49tlMHus 9Bfqk5ej7hCEfaJUNXWifwb2+K0fzWDl2StXBcL+qvf9JaD/lXpisFC+UmqSQ3ykwSwqdkRe8y7 8d70hrE4q+TSZuxxaWnOapyWZCUd5iYSv7wpIZi104W8JvS7Qild71 X-Received: by 2002:a17:90b:4d88:b0:37f:d9dc:557 with SMTP id 98e67ed59e1d1-3829d70cc3bmr2590824a91.16.1783153892139; Sat, 04 Jul 2026 01:31:32 -0700 (PDT) Received: from primary ([223.181.23.202]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f376bf710sm10074745eec.6.2026.07.04.01.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 01:31:31 -0700 (PDT) From: Vidhu Sarwal To: sakari.ailus@linux.intel.com, linux-media@vger.kernel.org Cc: bingbu.cao@intel.com, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, kernel-mentees@lists.linuxfoundation.org, Vidhu Sarwal Subject: [PATCH 2/2] staging: media: ipu7: fix pm_runtime refcount leak in ipu7_resume() Date: Sat, 4 Jul 2026 14:00:31 +0530 Message-ID: <20260704083031.8524-3-vidhu.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260704083031.8524-1-vidhu.linux@gmail.com> References: <20260704083031.8524-1-vidhu.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ipu7_resume() calls pm_runtime_get_sync() before resuming the device. If the runtime PM resume fails, the usage count remains incremented, but the error path returns without dropping the reference. Use pm_runtime_resume_and_get() instead, which balances the usage count on failure and avoids the leak. Keep returning 0 on error, as resume callbacks should not propagate failures to the PM core, matching the behaviour of the ipu6 driver. Fixes: b7fe4c0019b1 ("media: staging/ipu7: add Intel IPU7 PCI device driver") Signed-off-by: Vidhu Sarwal --- drivers/staging/media/ipu7/ipu7.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/ipu7/ipu7.c b/drivers/staging/media/ipu7/ipu7.c index 056af3a07507..48a35bda4237 100644 --- a/drivers/staging/media/ipu7/ipu7.c +++ b/drivers/staging/media/ipu7/ipu7.c @@ -2702,7 +2702,7 @@ static int ipu7_resume(struct device *dev) if (ret) dev_err(dev, "IPC reset protocol failed!\n"); - ret = pm_runtime_get_sync(&isp->psys->auxdev.dev); + ret = pm_runtime_resume_and_get(&isp->psys->auxdev.dev); if (ret < 0) { dev_err(dev, "Failed to get runtime PM\n"); return 0; -- 2.53.0