From: Biren Pandya <birenpandya@gmail.com>
To: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Cc: "Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"Jacopo Mondi" <jacopo+renesas@jmondi.org>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Hans Verkuil" <hverkuil+cisco@kernel.org>,
"Tommaso Merciai" <tommaso.merciai.xr@bp.renesas.com>,
"Biren Pandya" <birenpandya@gmail.com>
Subject: [PATCH v4 0/4] media: renesas: Add missing media_entity_cleanup() calls
Date: Sun, 5 Jul 2026 01:45:07 +0530 [thread overview]
Message-ID: <20260704201506.82524-6-birenpandya@gmail.com> (raw)
This patch series addresses missing media_entity_cleanup() calls across
multiple Renesas platform drivers (rcar-csi2, csisp, rcar-vin, and
rzg2l-cru).
While media_entity_cleanup() is currently a no-op when
CONFIG_MEDIA_CONTROLLER is disabled (and even when enabled in modern
kernels, as pads are rarely dynamically allocated anymore), the media
subsystem guidelines strictly require drivers to call it to prevent future
leaks if the core framework behavior changes.
Changes in v4:
- Formatted commit messages to strictly adhere to the 75-character limit
per line to resolve checkpatch warnings on the mailing list.
- Removed unwrapped long lines from the commit descriptions.
Changes in v3:
- Addressed maintainer feedback from Jacopo Mondi to fix an unused-label
compilation error in rcar-csi2.c. The teardown inversion is now handled
cleanly inside the existing error path without requiring a new label.
Changes in v2:
- Introduced dedicated error labels in probe paths where shared error
labels previously caused media_entity_cleanup() to be skipped or improperly
called.
Biren Pandya (4):
media: renesas: rcar-csi2: Add missing media_entity_cleanup()
media: renesas: csisp: Add missing media_entity_cleanup()
media: renesas: rcar-core: Add missing media_entity_cleanup()
media: renesas: rzg2l-core: Add missing media_entity_cleanup()
drivers/media/platform/renesas/rcar-csi2.c | 2 ++
drivers/media/platform/renesas/rcar-isp/csisp.c | 5 ++++-
drivers/media/platform/renesas/rcar-vin/rcar-core.c | 5 ++++-
drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c | 1 +
4 files changed, 11 insertions(+), 2 deletions(-)
--
2.50.1 (Apple Git-155)
next reply other threads:[~2026-07-04 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 20:15 Biren Pandya [this message]
2026-07-04 20:15 ` [PATCH v4 1/4] media: renesas: rcar-csi2: Add missing media_entity_cleanup() Biren Pandya
2026-07-04 20:15 ` [PATCH v4 2/4] media: renesas: csisp: " Biren Pandya
2026-07-04 20:15 ` [PATCH v4 3/4] media: renesas: rcar-core: " Biren Pandya
2026-07-04 20:15 ` [PATCH v4 4/4] media: renesas: rzg2l-core: " Biren Pandya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260704201506.82524-6-birenpandya@gmail.com \
--to=birenpandya@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=hverkuil+cisco@kernel.org \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
--cc=tommaso.merciai.xr@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox