From: Biren Pandya <birenpandya@gmail.com>
To: slongerbeam@gmail.com, sakari.ailus@linux.intel.com,
mchehab@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Biren Pandya <birenpandya@gmail.com>
Subject: [PATCH v3] media: i2c: ov5640: use scoped fwnode_handle endpoint cleanup
Date: Wed, 8 Jul 2026 18:19:55 +0530 [thread overview]
Message-ID: <20260708124954.26954-2-birenpandya@gmail.com> (raw)
In-Reply-To: <20260616081517.44685-2-birenpandya@gmail.com>
Utilize the __free(fwnode_handle) scoped guard macro from
<linux/cleanup.h> to automate the lifecycle management of the endpoint
fwnode in ov5640_probe().
This eliminates the need for manual fwnode_handle_put() calls.
Additionally, drop the redundant !endpoint check before
v4l2_fwnode_endpoint_parse(), as the parse function already handles
NULL endpoints safely.
Signed-off-by: Biren Pandya <birenpandya@gmail.com>
---
v3: adopted __free scoped guard (Laurent); explicitly dropped redundant endpoint check (Sakari).
---
drivers/media/i2c/ov5640.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 8deb5f5501faf..29d4dee9690b9 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -4,6 +4,7 @@
* Copyright (C) 2014-2017 Mentor Graphics Inc.
*/
+#include <linux/cleanup.h>
#include <linux/clk.h>
#include <linux/clk-provider.h>
#include <linux/clkdev.h>
@@ -3844,7 +3845,6 @@ static int ov5640_check_chip_id(struct ov5640_dev *sensor)
static int ov5640_probe(struct i2c_client *client)
{
struct device *dev = &client->dev;
- struct fwnode_handle *endpoint;
struct ov5640_dev *sensor;
int ret;
@@ -3869,15 +3869,10 @@ static int ov5640_probe(struct i2c_client *client)
sensor->ae_target = 52;
- endpoint = fwnode_graph_get_next_endpoint(dev_fwnode(&client->dev),
- NULL);
- if (!endpoint) {
- dev_err(dev, "endpoint node not found\n");
- return -EINVAL;
- }
+ struct fwnode_handle *endpoint __free(fwnode_handle) =
+ fwnode_graph_get_next_endpoint(dev_fwnode(&client->dev), NULL);
ret = v4l2_fwnode_endpoint_parse(endpoint, &sensor->ep);
- fwnode_handle_put(endpoint);
if (ret) {
dev_err(dev, "Could not parse endpoint\n");
return ret;
--
2.50.1 (Apple Git-155)
next prev parent reply other threads:[~2026-07-08 12:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 8:15 [PATCH v2 0/3] media: i2c: Automate fwnode lifecycle with __free() scope guards Biren Pandya
2026-06-16 8:15 ` [PATCH v2 1/3] media: i2c: ov5640: Drop manual fwnode_handle_put() via scope-based cleanup Biren Pandya
2026-07-08 8:54 ` Sakari Ailus
2026-07-08 12:49 ` Biren Pandya [this message]
2026-07-08 13:27 ` [PATCH v3] media: i2c: ov5640: use scoped fwnode_handle endpoint cleanup Sakari Ailus
2026-06-16 8:15 ` [PATCH v2 2/3] media: i2c: imx290: Drop manual fwnode_handle_put() via scope-based cleanup Biren Pandya
2026-06-17 5:42 ` Manivannan Sadhasivam
2026-07-08 13:16 ` [PATCH v3] " Biren Pandya
2026-06-16 8:15 ` [PATCH v2 3/3] media: i2c: imx219: " Biren Pandya
2026-06-17 9:30 ` Dave Stevenson
2026-07-08 13:17 ` [PATCH v3] " Biren Pandya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708124954.26954-2-birenpandya@gmail.com \
--to=birenpandya@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox