From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD1B74C77C8 for ; Wed, 8 Jul 2026 17:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783530553; cv=none; b=tWkvFhRomZwitb/TGLQ0A6EnLSioSmO/RMhM1RmAwjw4fj3M13CxqYMYs0OQzyCcXQQcLbGPSsupVB6eQ1UvDS2WnpKKpBRHpy00eZ8Uwp9rc55IiY266iYtWRiJ2zgkw1E0BcXs5nR40LgN9mkmEFDy8MdktNS6rSe/sPmvJEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783530553; c=relaxed/simple; bh=T3ZTA7fR/TwX7WfcW3K4j+ejRMOK8kk9j+oysKLms4w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jTl65RpNeal8/blCjbPTUTh3vNoYce260/tBwTiM0x+gFsuFH8FeosjcnZCmkoFb6S+cHl3LC8C0lvFV0L+faoNJ4nB+XdswnYami7HfWMa4U4EIzbTAL1xYrz5+slIbTv9kSpmKkTmLlHtf70hp/1mW37zmIXp61LEzxTQ3Rxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IgQx+tTh; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IgQx+tTh" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c8894387780so533412a12.2 for ; Wed, 08 Jul 2026 10:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783530550; x=1784135350; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xMKTs9AoISxOG0YX2UQ2sDdc8Iwlv60LsnZngRJBpHM=; b=IgQx+tThgQppgVu7qDCV11/RlM/utE9JYeYlYlAp6NdeKROBVBT4D7cDlvejpOtPvO wHJrd8UCaGrOKij31Qej0gMnY+14GSYhkCQUWPKov2BNQFaDB/MsUJ1Z9z13C+V6GiQ9 IdXBelCHloooL6t2DrEwQzW/Irsa/f9vFmAOH0PMz7A145LqwJ8iHGTIGU1xvWle87pU chwIGVrzgCHY2xYFhmldVa2rdcXAyIWr7Bc3mb3cWHcx4r9drmi8Rm3j+h3Spy7YknJc zz774K0YZPPw9e8s/DYNE1P+HE60k2zAfHN35CJkdt9HWaCfFZwqkPZnypFp8MbdXZtS 3hSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783530550; x=1784135350; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xMKTs9AoISxOG0YX2UQ2sDdc8Iwlv60LsnZngRJBpHM=; b=L3doly7iRIt6DHoj6I/LiHXjOGXpEGaEQ9JQSu563RURK/lcIdF5sUWODkhvg4x6Zz 0Q4HrVZ3KjQTDOial82Dnu+WwrQ2C1n2NRVRHHdvAGLYhpg52wk30ariQjPH4+Tl1jJ/ vjvWwmmSAhLsOwN9NxzSMr8CI+CjazPPP28gJkKgp+frR46gxjM5ze+TyPYlSqJBpa3/ b3LqDZva0fL2OElPHJ2fRjj4ICGlXOxMbxutDMmhUoa4V7Vwy1K47JvhpkaJdVQV6dJB iQqlJ4Yc3OvihbveAaGJgf5H5rsigo6t0A2lrLeDz1Sk6nkVoNI8/+k8cH1cAQvIVihp uXZA== X-Forwarded-Encrypted: i=1; AHgh+Rr1OERm21+Cfj4x/+M13U78k4X2fv7Egr5qa6v2v50AuT8Rv/uEXqvpYKYTYBMG8szCiJbKWM76drP7TA==@vger.kernel.org X-Gm-Message-State: AOJu0Ywkfh+TzJ9vollFRxo4SDAAUC7kUUP77n1H4Vjj6CAJhIUHLjIA EwdVGaXMh20z47eDbAL1d9qN34gZzZRgiz2X/Q6pDQMb2SMtTeoeZG3AFsF/uYO5 X-Gm-Gg: AfdE7cnn8A8HGB0twiDbEG+78Fl2SfdZVMYOLs+JJw9vsydaIJF0gVWzNhRG4Vi2Zgl PMubJLPfeldSP7jqFqCnhME1+Rh6ONMS2qkKWtIXsISAgChQOUQ7tEOZia4sf1Z9axc114rfV9V xNlHo/UBelN3GoGe1DeeDRGgEp2goVRJFHWlmwjxDAl1Equ4sY6kJN1iPndD93a3jsM2vvWD6OI B90R9d0ZvqcQLhbdvMXbGaK9owm2Dm/gP3/Ny780C/deoCmKQiAE41k6yi62BHvWFUb1INbt7Pm 6Ww9qbOiAGrKMLLgUgPC4g3FnrUqlUsgF7VF+t8O2c2cIj+84IoMqMISswFVtrx9eikphYmTUHf zOJMg7vCwuBwq9aL/uDnpDGvAOKg4q33Z8swgbH5Lr/C4xGcLlg/Xw87e8Rf33pBl24ZItSKY+w UbTRQlC5TxQHVVHaU35yx0k0DrwT56SLjr/nxvSvUdc3c= X-Received: by 2002:a05:6a21:6e8f:b0:3bf:3306:acdb with SMTP id adf61e73a8af0-3c0bceb3208mr3992329637.13.1783530550506; Wed, 08 Jul 2026 10:09:10 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659666e7sm26602154c88.7.2026.07.08.10.09.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 08 Jul 2026 10:09:10 -0700 (PDT) From: Biren Pandya To: niklas.soderlund@ragnatech.se, mchehab@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, Laurent Pinchart , Jacopo Mondi , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Biren Pandya Subject: [PATCH v5 4/4] media: renesas: rzg2l-core: Add missing media_entity_cleanup() Date: Wed, 8 Jul 2026 22:38:48 +0530 Message-ID: <20260708170843.55076-10-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260708170843.55076-6-birenpandya@gmail.com> References: <20260708170843.55076-6-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The probe error paths and the remove function fail to call media_entity_cleanup() upon teardown. While currently a no-op, calling media_entity_cleanup() is an API requirement for entities initialized with media_entity_pads_init() to prevent memory leaks. Add the missing media_entity_cleanup() calls. Additionally, patch the error path in rzg2l_cru_media_init() to ensure that media_device_cleanup(), media_entity_cleanup(), and mutex_destroy() are invoked and the error code is correctly returned if rzg2l_cru_mc_parse_of_graph() fails, rather than silently returning 0 and leaving the initialized structures lingering. Signed-off-by: Biren Pandya --- drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c index 3c5fbd857371c..77b17bcf7aeb7 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c @@ -234,6 +234,10 @@ static int rzg2l_cru_media_init(struct rzg2l_cru_dev *cru) mutex_lock(&cru->mdev_lock); cru->v4l2_dev.mdev = NULL; mutex_unlock(&cru->mdev_lock); + media_device_cleanup(mdev); + media_entity_cleanup(&cru->vdev.entity); + mutex_destroy(&cru->mdev_lock); + return ret; } return 0; @@ -312,6 +316,7 @@ static void rzg2l_cru_remove(struct platform_device *pdev) v4l2_async_nf_cleanup(&cru->notifier); rzg2l_cru_video_unregister(cru); + media_entity_cleanup(&cru->vdev.entity); media_device_cleanup(&cru->mdev); mutex_destroy(&cru->mdev_lock); -- 2.50.1 (Apple Git-155)