From: "Bohdan D. Marcus" <bohdandmarcus@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
"Bohdan D. Marcus" <bohdandmarcus@gmail.com>
Subject: [PATCH v2 2/2] staging: media: atomisp: fix grammar and punctuation in inline comments
Date: Fri, 10 Jul 2026 15:02:54 +0300 [thread overview]
Message-ID: <20260710120254.23565-3-bohdandmarcus@gmail.com> (raw)
In-Reply-To: <20260710120254.23565-1-bohdandmarcus@gmail.com>
Update inline comments in atomisp_cmd.c to comply with kernel
coding style and maintainer expectations. Specifically:
- Capitalize the first letter of sentences.
- Add missing periods at the end of statements.
- Ensure proper spacing before closing comment tags.
Signed-off-by: Bohdan D. Marcus <bohdandmarcus@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 6cd500d9f..6a4d04813 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -216,7 +216,7 @@ int atomisp_freq_scaling(struct atomisp_device *isp,
curr_rules.fps = fps;
curr_rules.run_mode = isp->asd.run_mode->val;
- /* search for the target frequency by looping freq rules*/
+ /* Search for the target frequency by looping freq rules. */
for (i = 0; i < dfs->dfs_table_size; i++) {
if (curr_rules.width != dfs->dfs_table[i].width &&
dfs->dfs_table[i].width != ISP_FREQ_RULE_ANY)
@@ -259,7 +259,7 @@ int atomisp_freq_scaling(struct atomisp_device *isp,
*/
int atomisp_reset(struct atomisp_device *isp)
{
- /* Reset ISP by power-cycling it */
+ /* Reset ISP by power-cycling it. */
int ret = 0;
dev_dbg(isp->dev, "%s\n", __func__);
@@ -420,7 +420,7 @@ static void print_csi_rx_errors(enum mipi_port_id port,
dev_err(isp->dev, " line sync error");
}
-/* Clear irq reg */
+/* Clear irq reg. */
static void clear_irq_reg(struct atomisp_device *isp)
{
struct pci_dev *pdev = to_pci_dev(isp->dev);
@@ -431,7 +431,7 @@ static void clear_irq_reg(struct atomisp_device *isp)
pci_write_config_dword(pdev, PCI_INTERRUPT_CTRL, msg_ret);
}
-/* interrupt handling function*/
+/* Interrupt handling function. */
irqreturn_t atomisp_isr(int irq, void *dev)
{
struct atomisp_device *isp = (struct atomisp_device *)dev;
@@ -481,7 +481,7 @@ irqreturn_t atomisp_isr(int irq, void *dev)
if ((irq_infos & IA_CSS_IRQ_INFO_INPUT_SYSTEM_ERROR) ||
(irq_infos & IA_CSS_IRQ_INFO_IF_ERROR)) {
- /* handle mipi receiver error */
+ /* Handle mipi receiver error. */
u32 rx_infos;
enum mipi_port_id port;
@@ -532,7 +532,7 @@ void atomisp_clear_css_buffer_counters(struct atomisp_sub_device *asd)
asd->dis_bufs_in_css = 0;
}
-/* 0x100000 is the start of dmem inside SP */
+/* 0x100000 is the start of dmem inside SP. */
#define SP_DMEM_BASE 0x100000
void dump_sp_dmem(struct atomisp_device *isp, unsigned int addr,
@@ -614,7 +614,7 @@ void atomisp_flush_video_pipe(struct atomisp_video_pipe *pipe, enum vb2_buffer_s
spin_unlock_irqrestore(&pipe->irq_lock, irqflags);
}
-/* clean out the parameters that did not apply */
+/* Clean out the parameters that did not apply. */
void atomisp_flush_params_queue(struct atomisp_video_pipe *pipe)
{
struct atomisp_css_params_with_list *param;
--
2.55.0
prev parent reply other threads:[~2026-07-10 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 12:02 [PATCH v2 0/2] staging: media: atomisp: clean up comment formatting and grammar Bohdan D. Marcus
2026-07-10 12:02 ` [PATCH v2 1/2] staging: media: atomisp: clean up block comment formatting in headers Bohdan D. Marcus
2026-07-10 12:02 ` Bohdan D. Marcus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260710120254.23565-3-bohdandmarcus@gmail.com \
--to=bohdandmarcus@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox