From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3575C34DCD2 for ; Mon, 20 Jul 2026 07:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784532716; cv=none; b=kIiZY/3CviGSTQpwE5YCQCkLsy6KV6ZcK7G9EUZ7+0xefa4tZEJnZ67tSeceqOuDpMhQIniuKG5oraup2IdkV8XAFAd89gOuPjG2V8DS3ZrPlTmp3ewGVr0UrMZRKoH3htdIu50Bb/Vt8EMp6ZCDv1aPW/3GEnFi2mKpWkSiyQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784532716; c=relaxed/simple; bh=1ElOTal8uzB9pbOiUrKjyapJe6QHK5YfhraTugcjhG4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MWtgykwgk9RGyRLybneP/mDji4oVPfFgo/eAw2vE2K2yU6TkrZmZ0HfBQengvyS4I2xiaR4goYFZHOiYEI+tI7G+LJq4WxxDcRZf3RLHmSUV+a8Yn8dlVNRJQx7Iap55dbycv1PCYg6bGutfnw0BscY/sDFDrp4AbWf3tpzWZJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=iFkThyuE; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="iFkThyuE" Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1DFA1161; Mon, 20 Jul 2026 09:30:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1784532655; bh=1ElOTal8uzB9pbOiUrKjyapJe6QHK5YfhraTugcjhG4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iFkThyuEXUEwqswVzqh7el4XyJgFvZq/jcUzxOqMpZelW4f6PrJyHnzMmfrM5gIZ8 kYQwb514nCrPaxLRNBcZyRh86pzVpkipSFpde/RRTDYUQlzI3E+YLUVWjB5He3DVtk iXUgkDcRB5ApXnC5K6RTSc3Kj0o4iZ7xzhF3XEDA= Date: Mon, 20 Jul 2026 10:31:52 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , Stefan Klug , Mirela Rabulea , =?utf-8?B?QW5kcsOp?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: Re: [PATCH v6 10/16] media: rdacm20: Don't assign set_fmt() Message-ID: <20260720073152.GB2259915@killaraus.ideasonboard.com> References: <20260607215356.842932-1-sakari.ailus@linux.intel.com> <20260701122634.1728782-10-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260701122634.1728782-10-sakari.ailus@linux.intel.com> On Wed, Jul 01, 2026 at 03:26:27PM +0300, Sakari Ailus wrote: > Do not assign set_fmt() as it is the same as get_fmt(), which will be s/will be/is/ > called by the framework now in absence of set_fmt() op. > > Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/rdacm20.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c > index 52e8e2620b4d..0179508626b5 100644 > --- a/drivers/media/i2c/rdacm20.c > +++ b/drivers/media/i2c/rdacm20.c > @@ -442,7 +442,6 @@ static const struct v4l2_subdev_video_ops rdacm20_video_ops = { > static const struct v4l2_subdev_pad_ops rdacm20_subdev_pad_ops = { > .enum_mbus_code = rdacm20_enum_mbus_code, > .get_fmt = rdacm20_get_fmt, > - .set_fmt = rdacm20_get_fmt, > }; > > static const struct v4l2_subdev_ops rdacm20_subdev_ops = { -- Regards, Laurent Pinchart