From: Fernando Rimoli <fernandorimoli11@gmail.com>
To: Jakob Berg Jespersen <dev@berg.pm>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Daniel Scally <dan.scally@ideasonboard.com>,
Hans de Goede <hansg@kernel.org>,
Tooraj Taraz <tooraj.taraz@yahoo.com>,
"Joseph V . Lavigne" <jlavig88@gmail.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Fernando Rimoli <fernandorimoli11@gmail.com>
Subject: Re: [PATCH RFC 2/2] media: i2c: ov5693: fix horizontal flip polarity and Bayer phase
Date: Mon, 20 Jul 2026 19:39:52 +0200 [thread overview]
Message-ID: <20260720173953.126255-1-fernandorimoli11@gmail.com> (raw)
In-Reply-To: <20260720-sp7plus-ov-flips-v1-2-5f345b0673de@berg.pm>
Tested this ov5693 patch on a Surface Pro 9 (Alder Lake IPU6, ov5693 front
camera).
I reproduced your 4-state flip/image matrix on the SP9 via raw V4L2 (capturing
SBGGR10 straight from the ISYS node, so libcamera's rotation handling is out of
the path and I could drive HFLIP/VFLIP directly). Unpatched, the matrix matched
yours: the correct image is at HFLIP=0/VFLIP=1, and the state libcamera
actually uses to undo the 180-degree mount (HFLIP=1+VFLIP=1) comes out
horizontally mirrored.
With this patch applied, the correct, un-mirrored image moves to
HFLIP=1+VFLIP=1 (what libcamera requests now yields the right
orientation). That confirms the inverted-HFLIP / correct-VFLIP conclusion on a
second IPU6 platform.
I did not separately validate the Bayer-phase column offset (my simple debayer
couldn't isolate it), so this Tested-by is for the HFLIP polarity behaviour.
Tested-by: Fernando Rimoli <fernandorimoli11@gmail.com>
next prev parent reply other threads:[~2026-07-20 17:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Q5OH0unwBM9QICxTJXBm1W7LkqYpiGtPRvNqI8FMsDW63Z1AgVArhC3__6dhY4hjrsuDCsbMfvArNyf_qB0Akw==@protonmail.internalid>
2026-07-20 14:28 ` [PATCH RFC 0/2] media: i2c: Surface Pro 7+ camera flip fixes Jakob Berg Jespersen
2026-07-20 14:28 ` [PATCH RFC 1/2] media: i2c: ov8865: fix horizontal flip control polarity Jakob Berg Jespersen
2026-07-28 22:30 ` Sakari Ailus
2026-07-29 13:15 ` Hans de Goede
2026-07-29 13:13 ` Hans de Goede
2026-07-20 14:28 ` [PATCH RFC 2/2] media: i2c: ov5693: fix horizontal flip polarity and Bayer phase Jakob Berg Jespersen
2026-07-20 17:39 ` Fernando Rimoli [this message]
2026-07-29 13:18 ` Hans de Goede
2026-07-22 22:14 ` [PATCH RFC 0/2] media: i2c: Surface Pro 7+ camera flip fixes Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720173953.126255-1-fernandorimoli11@gmail.com \
--to=fernandorimoli11@gmail.com \
--cc=dan.scally@ideasonboard.com \
--cc=dev@berg.pm \
--cc=hansg@kernel.org \
--cc=jlavig88@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tooraj.taraz@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox