From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1710F3EB0FF for ; Sat, 25 Jul 2026 18:09:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785002951; cv=none; b=FuigQ5Zqb3InFvRAxjQf06DAYikxdg3CqMN3GncTyZgJadaxWBbNDIiA29viKAvQqvisjOrUGm08baQuEUPCtdl7z9jswlqI0uREtBd33AIgWWDjvs/qOyXlVNVxRoHgqd+2fYcWNkE76WOE1NCnffB3zxXC16phR8XJPaN/LFQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785002951; c=relaxed/simple; bh=mjrVDz4H6RpOYzrPpqqkMT5INmyzNFeOGabjHCl0QJs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MIr4TLNNAZyVvrNQaMUqtreFBEAIkQDLAuE2fibgw4R3alT28LFiFdaNo5B9+nTE657Nb4Z7xwBp3GFXQ0koF4fItw/AZSiQNxkxCO3KKuVESk2CatGDZVjLKclXKxCiZqowg+/966P49cGEOAodxDE/cn5R/vXc5hOBE175oec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=C2/y2Ota; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TA1YWZuc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="C2/y2Ota"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TA1YWZuc" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66PGxM352616651 for ; Sat, 25 Jul 2026 18:09:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C4fjwuViaOd7s23k+7ReVdvQjEcM0iippnZxvUolPq4=; b=C2/y2OtaohTHBoY4 M1VbnRb4gA0jmAVcNDuqEVwzMNtf3Udlm/WjLaxPkx+HBgZ+VOOZLfhbABtTMMqJ 8dlEhdEbkrhWpErlDUWj5VGd1ZqK4mWOJpstl7enkXwlJyYLXxfe85aOexXDIWLr ZoC76wIsjh41OWj9nzw72m7Vh4r1xB2gNav2NNW6WQRX37j84iJSaFHOqgOPkAXY DhMYdEnYH484Ihwwc8Us+m5rW4ZtTOkgld/sx61fH/AZhyCPaW4hQwwLZWGeFNiW HRfXiImDTDJcL1S8ZPvNRn7/Gi9YhoArs3kOhqtobTdd5j2eezw0HafAU09ZdxuT 3lfHPg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fmmqy9g1s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 25 Jul 2026 18:09:08 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8482b95574dso1447235b3a.1 for ; Sat, 25 Jul 2026 11:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785002948; x=1785607748; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C4fjwuViaOd7s23k+7ReVdvQjEcM0iippnZxvUolPq4=; b=TA1YWZuc2tSM0C63mMYxnqzBGDqIaE++Q11Ym0HlxmCvdUL4gS1MGPPzVrrXaCGH6x RmbYmHhJKGtXALXjU5LTADdmgBkvJera6zFWTvL/H5jpme99yzklZzlPbuLMw4oH3IrJ 543J8eX6/dfWZJ18uA17xFZUdUX2nl1xPeEzdP6/qS7oXXPHxPchsmAuern/Tgr5fM5b IUZfvsrrAz6Wqf5W3qiWZvGKUHomdGrkN5+t3TudljnG7HZlnDMDpm1siZr9BZYODFHA WIOH1YjKJ5KAo7K8tSwGHMpgiHS+AzWX6S/hFsZjmYgCln3uMaXif9joZEEBK/0hr77X EEEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785002948; x=1785607748; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=C4fjwuViaOd7s23k+7ReVdvQjEcM0iippnZxvUolPq4=; b=YpAfHwEC5kJ2tLWq+UviHEj9oY3kGtI8zE1RftEGn/+zM/e/miGqP6QJ+mbtx8r1Ie zhNxyYzggC14SwsltQSBLdpz2u/MEQOfX72slB4y21+WqLMhwdm42hItyiQa9HpK04mz P0IhHwkOab2jy0F2i6gutJ8GceAieUCYFtXslTN6+PObeKljW4DuFLBBWM5lkRcluKUP +ZxZhd4TKpiV9u9KxMOBOl3lVjh1HHGtgTjjzwXQkH2tNUqPGW4/EAsPmxOPTU9HZxlX kU6UNgYLpmYQcPu5LF9wsDOqcZmWYPi5ZlkiiiehzadAkoWh0eyztIs4FRztJ0dp5SDe YhKQ== X-Gm-Message-State: AOJu0YwHO0Boemn8aJ1ACc1+4JErVdi04J1KCPdnLW9ILnkHUkrTayOb MLEINGZTtw/LRyVYk2E6LDTrQQf7IilYWnKRKK3zv77f9p236eRXuHKLa/9zAX27WsQtq8bxV32 BmvaSKnA85MiwOZnu94XxeLSpVswu3dZTGb+JDPLi3b5hJ8BDP0IJkZLYJcXsqZAvUA== X-Gm-Gg: AR+sD12nruLlnlqrCk/eWeqX3e/MU+Zda+gZAUHx/SpXOHiziclHq09QEDWwv+LVoWv pMcetqEbyuDiFOBTBONbweENrwf1eIZ5WZONk0yIIvVsy0RCkwdTsgfHGjInpDJ9iOA7HACDAZy W7qwZR6AsYb4BbrXgXD21Scc0g2g0Z1+wF8PxsxjrsFBFpbGBK3mMwzjHLmf2Bxv+axyGSxEBAu WXPz8vYsF+hVnichhMh5/EKTktN950ivuZrkeoPo69CvIhplKOhJY3ylIZ1MhWnh2tjSFkmRdwk sx4sZmCQV0BKF/wy7oCNDxqf/8r2uTXChiq2HQTmTD9Wl2D0JH7LZ4ecNPq1oaXLbmLQoB9GVPa lOrd1J4iT8bwjpkwQSBi9Chsa7RNskEI= X-Received: by 2002:a05:6a21:1f8a:b0:3ba:f5c7:6bc3 with SMTP id adf61e73a8af0-3c67d95a613mr2891921637.10.1785002947942; Sat, 25 Jul 2026 11:09:07 -0700 (PDT) X-Received: by 2002:a05:6a21:1f8a:b0:3ba:f5c7:6bc3 with SMTP id adf61e73a8af0-3c67d95a613mr2891904637.10.1785002947512; Sat, 25 Jul 2026 11:09:07 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc419c52sm12592642eec.10.2026.07.25.11.09.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2026 11:09:06 -0700 (PDT) From: Sachin Kumar Garg Date: Sat, 25 Jul 2026 23:38:51 +0530 Subject: [PATCH v7 1/3] media: iris: cache work mode after computing it in iris_set_stage Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260725-iris_multi_slice-v7-1-b4365c4930fe@oss.qualcomm.com> References: <20260725-iris_multi_slice-v7-0-b4365c4930fe@oss.qualcomm.com> In-Reply-To: <20260725-iris_multi_slice-v7-0-b4365c4930fe@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Vedang Nagar , Stefan Schmidt , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Kumar Garg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785002937; l=1459; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=mjrVDz4H6RpOYzrPpqqkMT5INmyzNFeOGabjHCl0QJs=; b=qAvhFMi4klyTucRFl4WWUHISZBsWsMYWC9i9jKtK3hLEHlqK9m2QUgCUlhPBYEJC5Xr3DMlaF lzS5k6qv9nQBpjtp7DtBFUGsfZYlpa7VZNUKq6v28dphdXzaKoVKd/1 X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Proofpoint-ORIG-GUID: 7S8ZpZPmPgTpVAVbQp1BbHyDFn7RVuz0 X-Authority-Analysis: v=2.4 cv=drbrzVg4 c=1 sm=1 tr=0 ts=6a64fbc4 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=DQE9uWRhMQBL0dtU3VIA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: 7S8ZpZPmPgTpVAVbQp1BbHyDFn7RVuz0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI1MDE3MiBTYWx0ZWRfX4jgMyltrrqPR skvCHKxVsrDEeYHPslbfEiJMg4dG3Bs2f5JWE8vHgsplMwOaAX4WSayrs4jyFypS3Mxab70DYeg wdSIdjWwrf3F6TF1uGcnEHHbPcmGCO7sxM05GXL0mERcWn7C7j3U+IMW9kW3HSkx91yycxz98zw 3x/TArpU576jjxBrCA6IWdWwclwAmVbnkPeflvKMB3xHz2tDN/ZElQo4Gh/Bsthn7FFaNUlqYLr 7ovaji7kuPim3kC6xic0IwCJlOByuN171roGgte41WHy6vKK3m4O0j2zba1Qk98mYAHu8W7NivG N87cQ75Qp/2o7dGIPWWSIPjR3+ZbjLIXR+ckb+WT0EPp3l//TL1ijxiOroEWdwIyQX2wtYF2jS2 T9RTNhYPzJ9YnQUzZXR2y+2cN4vC+q9nR0ns5vUCxNL/5ed+TsRi/udsjx6dNOdROBruLyxNSgo a7QtuLz5SBT0eNpSfmg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI1MDE3MiBTYWx0ZWRfX2arHBL4zpajI uXVez3ZIBJvpjT8l35J8CI0YC80A1vwNP3Af4ysUCgFSf0MPbGTyiAG69vfg64tYOnoBMQvK1+H YcsMRDfrNqn9UGYipvtf4R0EuoNIyOA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-25_05,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 malwarescore=0 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607250172 iris_set_stage() computes work_mode and sends it to firmware but never updates inst->fw_caps[STAGE].value, leaving the cached STAGE value stale. iris_vpu_enc_bin_size() and iris_vpu3x_vpu4x_calculate_frequency() read this cached value, so a stale default causes them to miscalculate buffer size and clock frequency for sessions actually running in a different stage than the cached one. Update inst->fw_caps[cap_id].value with the computed work_mode before sending it to firmware, keeping the cache consistent with what is actually configured. Fixes: 3a19d7b9e08b ("media: iris: implement set properties to firmware during streamon") Reviewed-by: Vikash Garodia Signed-off-by: Sachin Kumar Garg --- drivers/media/platform/qcom/iris/iris_ctrls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c index 10e33b8a73f6..58d195d2ab87 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -521,6 +521,8 @@ int iris_set_stage(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id work_mode = STAGE_1; } + inst->fw_caps[cap_id].value = work_mode; + return hfi_ops->session_set_property(inst, hfi_id, HFI_HOST_FLAGS_NONE, iris_get_port_info(inst, cap_id), -- 2.34.1