From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EB5E3195EF for ; Tue, 28 Jul 2026 06:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785218591; cv=none; b=AmMviagPtofuwmp0a+MLFFyLmV4XpydH/8VZUnGFr8lK+OPX0CiieBYSXLtKEbtFJ14zT8JlrbUSNfE79VxUndcTFXnaqIPytFYOei29rQENRllT6Ramq0mEDnl4cpzPVfH3TyEV5NYkWk6khEJ5TjG/4UfnKphBu9HMvEE7IIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785218591; c=relaxed/simple; bh=bTdIdA1UCWOsokX2nB8qHgXWeYqizKk/ZKhm2pjS1lk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oImtEO04VCf8ksrFJlb70usMoTIPedwDmYLIbDsYZJIe8115cD4r5fdGGtKORbrg1r+VFq5nagLhSufS6t7BnOU18Au91wd0UZxJBJpul6iK41AfHrnhoh6MSw+pciL99fz0buRhclCjiJv8RB6MqHRQDjqhp6R4XAfTrgeUY+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BhASwRp4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OSIsVPr4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BhASwRp4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OSIsVPr4" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66S40gk01593624 for ; Tue, 28 Jul 2026 06:03:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3IFbWmSKuBlvm9OxAe7Nc3sW/Flxo61XSajqvUznIqo=; b=BhASwRp4z9hDIwRu KeEFhABO+bcLtkr90WgmHzIubWLvurMVfnNfWfLFbTCAhfhv940/TPSEh7YTaCDi GYzmGQpGdUfXSbJpiHWqQ+Vekh7H9QdUYetq4Qt734hZJkw2D1tHb4Xenb8aUBeY SxsD2Qh8QntPhtJ6TBNfkgDEwjc/hNssUEiDkq7ONmFm7+VWqJDvaPhCGfK6TaIt HIJ5Yqix9rme3fTk3w2zkZVxnOWdXNfPWY/zbvVWMCmh9a6NLT+AOc1M0KewrE/b DR6Ory4UJgDUrT30RE83cSMbTd44LAgaWeh1aq3AmTsLZVBYxwZj4zNaTd0ZuKb0 h0VxWw== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fpn19gcp0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Jul 2026 06:03:08 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84a67b16217so1242275b3a.3 for ; Mon, 27 Jul 2026 23:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785218587; x=1785823387; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3IFbWmSKuBlvm9OxAe7Nc3sW/Flxo61XSajqvUznIqo=; b=OSIsVPr4j+1QjKVHIBvoDj4tOSM3OTLyfrR0QDVWCAV5pOWKTZIM1a7NcH2jHIe8Bs 8YjH35nxGq9CfxlL+A/cJAE92IcrJnNHYnllOSw8DayzKCm4cXl/IGa1IdbrtXrCidEn WF+It/++18FutgsguLEjdWmQo+gIgGVAdXcdwjaHQ7fZ7FU4ppktZL5u57n/guGC8OWs BOJFJNReACK4wzjwgf78iRmsjtwfqjXIcQiXnUhlEIOIqxLXJUpokxTnk9ylXW4F9EVy NWUwZRO6DTJ0wBDYz8Lsz5ben5Su7RR+rxVIYmrKKPNjzqXPNNGy8AFGYmJIeXVjGANE +nKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785218587; x=1785823387; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3IFbWmSKuBlvm9OxAe7Nc3sW/Flxo61XSajqvUznIqo=; b=jIZRcFioIGgBLbjkyeUjT65Aeg05c5r1fFzlXKJPK4aA10XgsdFJWCNj5bE+n8pzmo gwTCvqtDf3LMd8jQscvWdaQzd8NFBmcj4wSJUgc3jnLdnMpGVDi1/Uk7CIExxobFg1Tv qmHsR5EaAtLjYLpDbKeY5JkLcLjG3mq7Sh7IA7Mooc3msBZ0ezjCtfSyAxnrUYFVAhTu BRi4dOPSAdHUOyGy/Jfw71rWuAwiM1jaXOUmuECO+wBCUC6SaGQ204FcIdt5qxfcZmQD ci7HMJvS5wDK5jL2ruij4IwKhB7luP7oGyANhJIeaOxnzb+16Qm7VcPRozk0NOcj/viI 6iPA== X-Gm-Message-State: AOJu0Ywoyp87bL2CjtraPjMWvAeOH+1XN1NLH+rKqYsYJjU2VZ62QhXk hQ4NbM3h+bH0kdGhipeaLDXbN9xYP9aHNDeQKzdoZnfH6B6dKGDGvf7YSov5TNmKrJ96RHiIgpN PFbabNBFgWktvylik4p+aC9nlAyxWdrICAHNTUxkmiAHUPb6S5IoX2G8E8YI7Oe7tmA== X-Gm-Gg: AR+sD13PUhyciaHG9NqcJ5taUJn+8hW/oQ3xQtokc1dTywWXpo9X+LcYtwWGUG/pV0l 5Qgg2/74WNuwkAGrGX2OI1xgD0yXDU2UYBHWW5YDpfQZ+blhZdo7iFA60f7fRGRJKIFQvgFSfHt dHR+swLrQcyPlNxEDdjShm374FagFWZKZecLnUf+1JT7vyasODbPmbL6eCgG1fSgU9/qkAHyi+U rrvej97UE6aSYZL1ycnki7MmzbDDPT6p9IlSx/I5a6wLWa/g0Yw1ueUDV72xJDEmGqDRX+wwHr1 Tt5fRIBtwI4cz9VYo0q2crvbf5fJmlX2JxPe26cuhtgzUkfKtl9jWZ/Gc+Eq+8HKaNE7eUS4BhJ 6wvoTfLKjbLFCOQqe/5l/I+vlogutQvE= X-Received: by 2002:a05:6a00:1956:b0:848:6c37:cd74 with SMTP id d2e1a72fcca58-84e931ecd85mr995266b3a.22.1785218587467; Mon, 27 Jul 2026 23:03:07 -0700 (PDT) X-Received: by 2002:a05:6a00:1956:b0:848:6c37:cd74 with SMTP id d2e1a72fcca58-84e931ecd85mr995234b3a.22.1785218587072; Mon, 27 Jul 2026 23:03:07 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e533ce57asm3980421b3a.28.2026.07.27.23.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 23:03:06 -0700 (PDT) From: Sachin Kumar Garg Date: Tue, 28 Jul 2026 11:32:45 +0530 Subject: [PATCH v8 2/3] media: iris: force stage 1 work mode for CBR RC on encoder Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260728-iris_multi_slice-v8-2-eb18f96f0ed8@oss.qualcomm.com> References: <20260728-iris_multi_slice-v8-0-eb18f96f0ed8@oss.qualcomm.com> In-Reply-To: <20260728-iris_multi_slice-v8-0-eb18f96f0ed8@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Vedang Nagar , Stefan Schmidt Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, 20260709-iris-ar50lt-v7-0-76af9dd4d1f6@oss.qualcomm.com, Sachin Kumar Garg , Vishnu Reddy X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785218571; l=1399; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=bTdIdA1UCWOsokX2nB8qHgXWeYqizKk/ZKhm2pjS1lk=; b=wCxFysR1rFFJV2IHKYnmb+ju2PXWqSAB8Uxm4vT7SC6uRydIn/TXlUEQVMYiMzfHzGM4ylkz5 TtV91cKfuLUAkaCH91H6FRg+85NiLTKdY6ulnK1mCmsmLiF5FO2oYET X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Authority-Analysis: v=2.4 cv=TJV1jVla c=1 sm=1 tr=0 ts=6a68461c cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=LMK2Ni0dcLaqO0rVonUA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI4MDA1MyBTYWx0ZWRfX/wZJL7N+SfUv tMLDhFvnMhWpz4zIS+8ukngYHgNd3w6eQJb/gS1QyhQvENLGXIYSptLxOCrWv/K2zspf/6chDow SaMjELCHN7h3vdCo1TVDpcvT1Af9OWkLB4an2jRx5IpyPizZSE/YhLNDkF6/2RSz4O7gYqkcmFk dGleh419Aw5bnxT62x6YUVvxymbZF0I3nVgxzowv0XRNswKs89Ee4VZcsSyD2uJF4Qp4HSP2vtA rQTVtO4qZIBuWz3YXaC3gsFO6yGO3sE+u0nMxWxam83rejaLokUJZrl6kuNKQy+YEKsU22Meo6O C6n6a7ocok6xmbaguKJSc595K3iGZcJnAfhsb4okoB4je2XlZe+cN87zoMGoEmMLLRpRAJS0DAT vTKOmF3XtXYT1MZsGaJSWOyEYJngYjlJbAGSJAlMenXxJcN0Fii7ogyVSx0hiLpF/iT3FHazXkM K4GjnRy2HpOr0vwco3g== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI4MDA1MyBTYWx0ZWRfXwrYyx1tEEK2y dsqhbmK6J2hhb4ZCGu/KCNY4D6e3B7qN/9FA/oVL6T2IQkAOTp0ufcRutKWFpXhG8WnbXj+fgZn nPoj9UxjziBKd+S3TfYB8QHlmnlZmIE= X-Proofpoint-GUID: eoMJaCet5ux6ZWYKRbRy85CAG0mP3RzG X-Proofpoint-ORIG-GUID: eoMJaCet5ux6ZWYKRbRy85CAG0mP3RzG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-28_01,2026-07-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 bulkscore=0 phishscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607280053 iris_set_stage() currently always picks STAGE_2 for encoder sessions. CBR rate control requires stage 1 operation, so force STAGE_1 when BITRATE_MODE is set to CBR. The BITRATE_MODE fw_cap value is used instead of inst->hfi_rc_type since STAGE precedes BITRATE_MODE in enum platform_inst_fw_cap_type, so iris_set_properties() would still see the previous hfi_rc_type when iris_set_stage() runs during initial config Reviewed-by: Vishnu Reddy Reviewed-by: Vikash Garodia Signed-off-by: Sachin Kumar Garg --- drivers/media/platform/qcom/iris/iris_ctrls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c index 80cb43b8bcf4..74a299f72024 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -519,6 +519,9 @@ int iris_set_stage(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id if (inst->domain == DECODER) { if (iris_res_is_less_than(width, height, 1280, 720)) work_mode = STAGE_1; + } else if (inst->domain == ENCODER) { + if (inst->fw_caps[BITRATE_MODE].value == V4L2_MPEG_VIDEO_BITRATE_MODE_CBR) + work_mode = STAGE_1; } inst->fw_caps[cap_id].value = work_mode; -- 2.34.1