From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62EEE476688 for ; Fri, 7 Aug 2026 12:24:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786105497; cv=none; b=KjEJJojoTMjJmYHlIcmbuKg7jtfkc+fSNsg3rZppYDawoKPVfEJ9fpEZp3xBRW2O/6wAWq3vOYXZUffuzBJ/dhZqGgcmQVF+KhDiFFA4Ue00t6Alg7Twj7nd6J6yGDvln6cek8agaaiJCPrqHQjHEg2hIyb4eRjO9Cb8pUTb0pc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786105497; c=relaxed/simple; bh=ArZ6Gps2Ydi73+YcN+sUaSwRyvVHIoyG8P33VIT4A30=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jz6RIrBu3jU188X77QVQzgwIQhP6D6doPROYaoLqBNhhRvEKK6bs8MSHpMYVieuQfUT0wDtWyiy2TxrLeyTYnlX1HS4WuFPozdhjz8Vp/hr3emCeXzX2SgcJUlr/I8Be1RxgXn/K0QGGI3tTwq90/JuQEsCUtw4X0KkzMgLpSCU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gYCPAAdP; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gYCPAAdP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1786105484; x=1817641484; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ArZ6Gps2Ydi73+YcN+sUaSwRyvVHIoyG8P33VIT4A30=; b=gYCPAAdPeY2Tz7vdnbIoOjsnNSxPZooTxgz55y6z28OQzcixwIWn/lZs lQ6t5LCIYlJQC4VzQ9yM715gmCKggzWEUaDqIdaQbbpum5UyUwD3Qj1cJ Y4LVWldNJ01T2DzR33/+il7MUxoRCbVRiJc8LvWGfvG/+/J+1rU7d+Iy+ PXQWn2Klk1k7gyumFJei/V3Wmfe74f1JOTze8KIlhVU1+gQ4e9M6pRjN2 iLpCFZrOKcsEjS0xhcH7ROYGua83j6VJUQfIlU3wh+Vd7m/Hkqv1HcSyT bC61hvPvn8DUpe7mVWuejDJpIrc2GbFiEjvLQTTM8wSi2gFMbJRV99I33 g==; X-CSE-ConnectionGUID: cAvLyegzSaaGzd3RVqcZ6g== X-CSE-MsgGUID: I8+RiAWGRO6ulGE0P41eFw== X-IronPort-AV: E=McAfee;i="6800,10657,11867"; a="90591922" X-IronPort-AV: E=Sophos;i="6.25,210,1779174000"; d="scan'208";a="90591922" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2026 05:24:29 -0700 X-CSE-ConnectionGUID: DVgawbvwRYGOc/E7z1DyOg== X-CSE-MsgGUID: Rl7/UVIdSCOWRA1VHiyl/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,210,1779174000"; d="scan'208";a="259779639" Received: from ijarvine-desk1.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.179]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2026 05:24:23 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id 95246121CB3; Fri, 07 Aug 2026 15:24:20 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1wsJcP-00000000Bvm-35cL; Fri, 07 Aug 2026 15:24:09 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , Stefan Klug , Mirela Rabulea , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: [PATCH v7 04/14] media: imx219: The horizontal blanking step is 8 Date: Fri, 7 Aug 2026 15:23:59 +0300 Message-ID: <20260807122409.45807-5-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260807122409.45807-1-sakari.ailus@linux.intel.com> References: <20260807122409.45807-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The step for the LINE_LENGTH_A register on imx219 is 8. Take this into account in creating and modifying the horizontal blanking control. The minimum line length in pixels as well as the horizontal blanking values are already divisible by 8. Fixes: cd5e2fd89923 ("media: i2c: imx219: make HBLANK r/w to allow longer exposures") Cc: stable@vger.kernel.org Signed-off-by: Sakari Ailus Reviewed-by: Dave Stevenson Reviewed-by: Laurent Pinchart --- drivers/media/i2c/imx219.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index b1f29037af74..05717b1e3224 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -78,6 +78,7 @@ #define IMX219_LLP_MIN 0x0d78 #define IMX219_BINNED_LLP_MIN 0x0de8 #define IMX219_LLP_MAX 0x7ff0 +#define IMX219_LLP_STEP 8 #define IMX219_REG_X_ADD_STA_A CCI_REG16(0x0164) #define IMX219_REG_X_ADD_END_A CCI_REG16(0x0166) @@ -593,7 +594,8 @@ static int imx219_init_controls(struct imx219 *imx219) imx219->hblank = v4l2_ctrl_new_std(ctrl_hdlr, &imx219_ctrl_ops, V4L2_CID_HBLANK, IMX219_LLP_MIN - mode->width, - IMX219_LLP_MAX - mode->width, 1, + IMX219_LLP_MAX - mode->width, + IMX219_LLP_STEP, IMX219_LLP_MIN - mode->width); exposure_max = mode->fll_def - IMX219_EXPOSURE_OFFSET; exposure_def = (exposure_max < IMX219_EXPOSURE_DEFAULT) ? @@ -935,7 +937,8 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd, IMX219_BINNED_LLP_MIN : IMX219_LLP_MIN; ret = __v4l2_ctrl_modify_range(imx219->hblank, llp_min - mode->width, - IMX219_LLP_MAX - mode->width, 1, + IMX219_LLP_MAX - mode->width, + IMX219_LLP_STEP, llp_min - mode->width); if (ret) return ret; -- 2.47.3