Re: [PATCH 2/2] media: uvcvideo: add device entry for Logitech C920 (046d:08e5)

[kernel test robot <lkp@intel.com>]

Hi Pol,

kernel test robot noticed the following build errors:

[auto build test ERROR on linuxtv-media-pending/master]
[also build test ERROR on media-tree/master sailus-media-tree/master linus/master v7.2-rc7 next-20260721]
[cannot apply to sailus-media-tree/streams]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Pol-Fern-ndez-Fern-ndez/media-uvcvideo-add-device-entry-for-Logitech-C920-046d-08e5/20260814-213320
base:   https://git.linuxtv.org/media-ci/media-pending.git master
patch link:    https://lore.kernel.org/r/20260629163805.37879-2-fernandezfernandezpol%40gmail.com
patch subject: [PATCH 2/2] media: uvcvideo: add device entry for Logitech C920 (046d:08e5)
config: x86_64-rhel-9.4-bpf (https://download.01.org/0day-ci/archive/20260816/202608160712.l89JPkSj-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260816/202608160712.l89JPkSj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608160712.l89JPkSj-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/media/usb/uvc/uvc_queue.c: In function 'uvc_queue_buffer_complete':
>> drivers/media/usb/uvc/uvc_queue.c:360:14: error: implicit declaration of function 'uvc_queue_to_stream'; did you mean 'uvc_queue_streaming'? [-Wimplicit-function-declaration]
     360 |             (uvc_queue_to_stream(queue)->dev->quirks & UVC_QUIRK_DROP_STREAM_ERR))) {
         |              ^~~~~~~~~~~~~~~~~~~
         |              uvc_queue_streaming
>> drivers/media/usb/uvc/uvc_queue.c:360:40: error: invalid type argument of '->' (have 'int')
     360 |             (uvc_queue_to_stream(queue)->dev->quirks & UVC_QUIRK_DROP_STREAM_ERR))) {
         |                                        ^~


vim +360 drivers/media/usb/uvc/uvc_queue.c

   352	
   353	static void uvc_queue_buffer_complete(struct kref *ref)
   354	{
   355		struct uvc_buffer *buf = container_of(ref, struct uvc_buffer, ref);
   356		struct vb2_buffer *vb = &buf->buf.vb2_buf;
   357		struct uvc_video_queue *queue = vb2_get_drv_priv(vb->vb2_queue);
   358	
   359		if (buf->error && (!uvc_no_drop_param ||
 > 360		    (uvc_queue_to_stream(queue)->dev->quirks & UVC_QUIRK_DROP_STREAM_ERR))) {
   361			uvc_queue_buffer_requeue(queue, buf);
   362			return;
   363		}
   364	
   365		buf->state = buf->error ? UVC_BUF_STATE_ERROR : UVC_BUF_STATE_DONE;
   366		vb2_set_plane_payload(&buf->buf.vb2_buf, 0, buf->bytesused);
   367		vb2_buffer_done(&buf->buf.vb2_buf, buf->error ? VB2_BUF_STATE_ERROR :
   368								VB2_BUF_STATE_DONE);
   369	}
   370	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki