From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sasha Levin <sashal@kernel.org>,
Andrey Troshin <drtrosh@yandex-team.ru>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-media@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH 5.10] media: mtk-vcodec: potential null pointer deference in SCP
Date: Mon, 17 Aug 2026 11:24:41 -0400 [thread overview]
Message-ID: <20260817150000.3@kernel.org> (raw)
In-Reply-To: <20260817055803.1946-1-drtrosh@yandex-team.ru>
> fw = devm_kzalloc(&dev->plat_dev->dev, sizeof(*fw), GFP_KERNEL);
> + if (!fw)
> + return ERR_PTR(-ENOMEM);
The backport itself is faithful, but the error path it adds returns
without dropping the scp reference taken just above it. That leak is
fixed upstream by 4936cd5817af ("media: mediatek: vcodec: Fix a resource
leak related to the scp device in FW initialization") (Fixes:
53dbe0850444, Cc: stable), and every tree carrying 53dbe0850444 already
carries the follow-up as well - taking this one alone would leave 5.10 as
the only stable tree in the leaky state.
Could you resend it as a 2-patch series covering both commits, targeting
5.15 as well as 5.10? 5.15 is missing both and holds the file at the same
path with an identical blob, so the same two patches apply there
unchanged.
--
Thanks,
Sasha
prev parent reply other threads:[~2026-08-17 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 5:58 [PATCH 5.10] media: mtk-vcodec: potential null pointer deference in SCP Andrey Troshin
2026-08-17 15:24 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817150000.3@kernel.org \
--to=sashal@kernel.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=drtrosh@yandex-team.ru \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiffany.lin@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox