Linux Media Controller development
 help / color / mirror / Atom feed
From: Antti Laakso <antti.laakso@linux.intel.com>
To: linux-media@vger.kernel.org, mchehab@kernel.org,
	sakari.ailus@linux.intel.com, sarang.sapre@intel.com
Cc: daxing.li@intel.com, ong.hock.yu@intel.com, antti.laakso@linux.intel.com
Subject: [PATCH v3 03/44] media: ipu6: Rename buttress_ipc pointer
Date: Thu, 27 Aug 2026 15:32:55 +0300	[thread overview]
Message-ID: <20260827123336.2219048-4-antti.laakso@linux.intel.com> (raw)
In-Reply-To: <20260827123336.2219048-1-antti.laakso@linux.intel.com>

The ipu6_buttress_ipc structure is called as cse sometimes,
rename it to ipc for consistency.

Signed-off-by: Antti Laakso <antti.laakso@linux.intel.com>
---
 drivers/media/pci/intel/ipu6/ipu6-buttress.c | 33 ++++++++++----------
 drivers/media/pci/intel/ipu6/ipu6-buttress.h |  2 +-
 drivers/media/pci/intel/ipu6/ipu6.c          |  4 +--
 3 files changed, 20 insertions(+), 19 deletions(-)

diff --git a/drivers/media/pci/intel/ipu6/ipu6-buttress.c b/drivers/media/pci/intel/ipu6/ipu6-buttress.c
index e0ecb4c8b081..cbe356589a9d 100644
--- a/drivers/media/pci/intel/ipu6/ipu6-buttress.c
+++ b/drivers/media/pci/intel/ipu6/ipu6-buttress.c
@@ -221,7 +221,7 @@ static int ipu6_buttress_ipc_send_bulk(struct ipu6_device *isp,
 	unsigned long tx_timeout_jiffies, rx_timeout_jiffies;
 	unsigned int i, retry = BUTTRESS_IPC_CMD_SEND_RETRY;
 	struct ipu6_buttress *b = &isp->buttress;
-	struct ipu6_buttress_ipc *ipc = &b->cse;
+	struct ipu6_buttress_ipc *ipc = &b->ipc;
 	u32 val;
 	int ret;
 	int tout;
@@ -378,14 +378,15 @@ irqreturn_t ipu6_buttress_isr(int irq, void *isp_ptr)
 		if (irq_status & BUTTRESS_ISR_IPC_FROM_CSE_IS_WAITING) {
 			dev_dbg(&isp->pdev->dev,
 				"BUTTRESS_ISR_IPC_FROM_CSE_IS_WAITING\n");
-			ipu6_buttress_ipc_recv(isp, &b->cse, &b->cse.recv_data);
-			complete(&b->cse.recv_complete);
+
+			ipu6_buttress_ipc_recv(isp, &b->ipc, &b->ipc.recv_data);
+			complete(&b->ipc.recv_complete);
 		}
 
 		if (irq_status & BUTTRESS_ISR_IPC_EXEC_DONE_BY_CSE) {
 			dev_dbg(&isp->pdev->dev,
 				"BUTTRESS_ISR_IPC_EXEC_DONE_BY_CSE\n");
-			complete(&b->cse.send_complete);
+			complete(&b->ipc.send_complete);
 		}
 
 		if (irq_status & BUTTRESS_ISR_SAI_VIOLATION &&
@@ -830,17 +831,17 @@ int ipu6_buttress_init(struct ipu6_device *isp)
 	mutex_init(&b->auth_mutex);
 	mutex_init(&b->cons_mutex);
 	mutex_init(&b->ipc_mutex);
-	init_completion(&b->cse.send_complete);
-	init_completion(&b->cse.recv_complete);
-
-	b->cse.nack = BUTTRESS_CSE2IUDATA0_IPC_NACK;
-	b->cse.nack_mask = BUTTRESS_CSE2IUDATA0_IPC_NACK_MASK;
-	b->cse.csr_in = BUTTRESS_REG_CSE2IUCSR;
-	b->cse.csr_out = BUTTRESS_REG_IU2CSECSR;
-	b->cse.db0_in = BUTTRESS_REG_CSE2IUDB0;
-	b->cse.db0_out = BUTTRESS_REG_IU2CSEDB0;
-	b->cse.data0_in = BUTTRESS_REG_CSE2IUDATA0;
-	b->cse.data0_out = BUTTRESS_REG_IU2CSEDATA0;
+	init_completion(&b->ipc.send_complete);
+	init_completion(&b->ipc.recv_complete);
+
+	b->ipc.nack = BUTTRESS_CSE2IUDATA0_IPC_NACK;
+	b->ipc.nack_mask = BUTTRESS_CSE2IUDATA0_IPC_NACK_MASK;
+	b->ipc.csr_in = BUTTRESS_REG_CSE2IUCSR;
+	b->ipc.csr_out = BUTTRESS_REG_IU2CSECSR;
+	b->ipc.db0_in = BUTTRESS_REG_CSE2IUDB0;
+	b->ipc.db0_out = BUTTRESS_REG_IU2CSEDB0;
+	b->ipc.data0_in = BUTTRESS_REG_CSE2IUDATA0;
+	b->ipc.data0_out = BUTTRESS_REG_IU2CSEDATA0;
 
 	INIT_LIST_HEAD(&b->constraints);
 
@@ -877,7 +878,7 @@ int ipu6_buttress_init(struct ipu6_device *isp)
 
 	/* Retry couple of times in case of CSE initialization is delayed */
 	do {
-		ret = ipu6_buttress_ipc_reset(isp, &b->cse);
+		ret = ipu6_buttress_ipc_reset(isp, &b->ipc);
 		if (ret) {
 			dev_warn(&isp->pdev->dev,
 				 "IPC reset protocol failed, retrying\n");
diff --git a/drivers/media/pci/intel/ipu6/ipu6-buttress.h b/drivers/media/pci/intel/ipu6/ipu6-buttress.h
index 51e5ad48db82..b1c1a10e3e6d 100644
--- a/drivers/media/pci/intel/ipu6/ipu6-buttress.h
+++ b/drivers/media/pci/intel/ipu6/ipu6-buttress.h
@@ -44,7 +44,7 @@ struct ipu6_buttress_ipc {
 
 struct ipu6_buttress {
 	struct mutex power_mutex, auth_mutex, cons_mutex, ipc_mutex;
-	struct ipu6_buttress_ipc cse;
+	struct ipu6_buttress_ipc ipc;
 	struct list_head constraints;
 	u32 wdt_cached_value;
 	bool force_suspend;
diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c
index 6d3235352a1c..efb58bc4d127 100644
--- a/drivers/media/pci/intel/ipu6/ipu6.c
+++ b/drivers/media/pci/intel/ipu6/ipu6.c
@@ -765,7 +765,7 @@ static int ipu6_resume(struct device *dev)
 
 	ipu6_buttress_restore(isp);
 
-	ret = ipu6_buttress_ipc_reset(isp, &b->cse);
+	ret = ipu6_buttress_ipc_reset(isp, &b->ipc);
 	if (ret)
 		dev_err(&isp->pdev->dev, "IPC reset protocol failed!\n");
 
@@ -797,7 +797,7 @@ static int ipu6_runtime_resume(struct device *dev)
 		struct ipu6_buttress *b = &isp->buttress;
 
 		isp->need_ipc_reset = false;
-		ret = ipu6_buttress_ipc_reset(isp, &b->cse);
+		ret = ipu6_buttress_ipc_reset(isp, &b->ipc);
 		if (ret)
 			dev_err(&isp->pdev->dev, "IPC reset protocol failed\n");
 	}
-- 
2.55.0


  parent reply	other threads:[~2026-08-27 12:33 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 12:32 [PATCH v3 00/44] media: ipu6: Add support for ipu7 hardware Antti Laakso
2026-08-27 12:32 ` [PATCH v3 01/44] media: ipu6: Add helpers for IPU runtime variation Antti Laakso
2026-08-27 12:32 ` [PATCH v3 02/44] media: ipu6: Rename pointer to firmware context Antti Laakso
2026-08-27 12:32 ` Antti Laakso [this message]
2026-08-27 12:32 ` [PATCH v3 04/44] media: ipu6: Remove duplicate warnings in cpd validation Antti Laakso
2026-08-27 12:32 ` [PATCH v3 05/44] media: ipu6: Remove unused ipu6 firmware struct Antti Laakso
2026-08-27 12:32 ` [PATCH v3 06/44] media: ipu6: Cleanup ipu6_mmu_init() Antti Laakso
2026-08-27 12:32 ` [PATCH v3 07/44] media: ipu6: Simplify firmware com arguments Antti Laakso
2026-08-27 12:33 ` [PATCH v3 08/44] media: ipu6: Add helper to identify ipu7 Antti Laakso
2026-08-27 12:33 ` [PATCH v3 09/44] media: ipu6: Prepare buttress for ipu7 support Antti Laakso
2026-08-27 12:33 ` [PATCH v3 10/44] media: ipu6: Use single struct for registers Antti Laakso
2026-08-27 12:33 ` [PATCH v3 11/44] media: ipu6: Rename IPU subsys ID Antti Laakso
2026-08-27 12:33 ` [PATCH v3 12/44] media: ipu6: Add ipu7 buttress support Antti Laakso
2026-08-27 12:33 ` [PATCH v3 13/44] media: ipu6: Prepare mmu driver for hw variation Antti Laakso
2026-08-27 12:33 ` [PATCH v3 14/44] media: ipu6: Add ipu7 mmu support Antti Laakso
2026-08-27 12:33 ` [PATCH v3 15/44] media: ipu6: Add ipu7 cpd handling Antti Laakso
2026-08-27 12:33 ` [PATCH v3 16/44] media: ipu6: Add check for pkg_dir before freeing Antti Laakso
2026-08-27 12:33 ` [PATCH v3 17/44] media: ipu6: Rename isys fw msg union Antti Laakso
2026-08-27 12:33 ` [PATCH v3 18/44] media: ipu6: Move isys isr handlers to fw file Antti Laakso
2026-08-27 12:33 ` [PATCH v3 19/44] media: ipu6: Move hw specific buffer handling down Antti Laakso
2026-08-27 12:33 ` [PATCH v3 20/44] media: ipu6: Isolate hw specific buffer handling Antti Laakso
2026-08-27 12:33 ` [PATCH v3 21/44] media: ipu6: Add isys firmware ops Antti Laakso
2026-08-27 12:33 ` [PATCH v3 22/44] media: ipu6: Add ipu7 fw start/stop functionality Antti Laakso
2026-08-27 12:33 ` [PATCH v3 23/44] media: ipu6: Add ipu7 fw com methods Antti Laakso
2026-08-27 12:33 ` [PATCH v3 24/44] media: ipu6: Add ipu7 fw isys ops Antti Laakso
2026-08-27 12:33 ` [PATCH v3 25/44] media: ipu6: Add ipu7 csi2 register definitions Antti Laakso
2026-08-27 12:33 ` [PATCH v3 26/44] media: ipu6: Add ipu7 isr handler Antti Laakso
2026-08-27 12:33 ` [PATCH v3 27/44] media: ipu6: Add ipu7 csi phy driver Antti Laakso
2026-08-27 12:33 ` [PATCH v3 28/44] media: ipu6: Split ipu6 csi2 stream enable/disable Antti Laakso
2026-08-27 12:33 ` [PATCH v3 29/44] media: ipu6: Add support for ipu7 csi2 receiver Antti Laakso
2026-08-27 12:33 ` [PATCH v3 30/44] media: ipu6: Parse bus type for ipu7 Antti Laakso
2026-08-27 12:33 ` [PATCH v3 31/44] media: ipu6: Enable ipu7 isys interrupts Antti Laakso
2026-08-27 12:33 ` [PATCH v3 32/44] media: ipu6: Skip watermark configuration for ipu7 Antti Laakso
2026-08-27 12:33 ` [PATCH v3 33/44] media: ipu6: The SPC init is valid only for ipu6 Antti Laakso
2026-08-27 12:33 ` [PATCH v3 34/44] media: ipu6: The VC arbitration mechanism is ipu6 only Antti Laakso
2026-08-27 12:33 ` [PATCH v3 35/44] media: ipu6: Move buttress mem alloc out from probe Antti Laakso
2026-08-27 12:33 ` [PATCH v3 36/44] media: ipu6: Read correct SKU ID for ipu7 Antti Laakso
2026-08-27 12:33 ` [PATCH v3 37/44] media: ipu6: Add support for fixed iova region Antti Laakso
2026-08-27 12:33 ` [PATCH v3 38/44] media: ipu6: Make fw mapping function reusable Antti Laakso
2026-08-27 12:33 ` [PATCH v3 39/44] media: ipu6: Move isys fw mapping to pci_probe Antti Laakso
2026-08-27 12:33 ` [PATCH v3 40/44] media: ipu6: Map ipu7 firmware Antti Laakso
2026-08-27 12:33 ` [PATCH v3 41/44] media: ipu6: Set model name for ipu7 Antti Laakso
2026-08-27 12:33 ` [PATCH v3 42/44] media: ipu6: Add ipu7.5 buttress support Antti Laakso
2026-08-27 12:33 ` [PATCH v3 43/44] media: ipu6: Add ipu7.5 mmu initialization data Antti Laakso
2026-08-27 12:33 ` [PATCH v3 44/44] media: ipu6: Enable ipu7 and ipu7.5 Antti Laakso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260827123336.2219048-4-antti.laakso@linux.intel.com \
    --to=antti.laakso@linux.intel.com \
    --cc=daxing.li@intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=ong.hock.yu@intel.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sarang.sapre@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox