From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4E342F7F19 for ; Fri, 28 Aug 2026 23:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787959088; cv=none; b=ZJ+EBB9dmvtWsHvVGyKG1k6e3bRObHaYQ8AR4HC11ea3f9kczIx9FkiUn/S1z76z4SCNIMN94z9Gotc8hLHodIJ2j4bsUOhU1r8YVrSRyZ0xUey0/HdQe8SadNsQxsqXdPLVkStdHXZLSeJydyP2yS68kNRc/7n9c2auPVpYm0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787959088; c=relaxed/simple; bh=2Lq50lUytrmm+S28IHrLjU1z+wrPGA3wstjnNQ2ei3s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RQSiie6cc3BXHgIGCu8hQWQlJrDs4et55/+vJmAmSzXrOFdytrHCN3Cb9lpNqS7Yq9kMZeysS9X0IoETRy0h3bbSUu2FGOlgkmYeQW4p8HpCPKYZNmzF76ljG0SdnSSGuwqLrmUri8Zq5hT/Do3QRPSBGvwrt+WGngjVryG+n2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kLnoBw8A; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kLnoBw8A" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-49b8f86c6deso8026425e9.0 for ; Fri, 28 Aug 2026 16:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787959085; x=1788563885; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3a//jCzePczEVRzcT1fYsbmZwFdKhukTh22rftAVB94=; b=kLnoBw8A2SE1sEizMYuYmnNmzWB9eRQAznDLYbnzLbCQRWzN+yytbcOpBJV2VE8fua uoXPNGmdKEwmg7oE6O27cR0xN7lSeuQ23B4LBwTtORyf5ELazXk9wKP6MNwR3UhEzo9C w0B9OstTDgTqDAdZ9yXK8PfF4945YJQ2+Fus3/L533LYXhH6K8KtcO5CJXPIlCmsrfJL 6BQKL5CEOWuz9ta3pjn4H/awJWkfDE0UG9jItlmCf6O8s+V7YJimjtHXeg8/n6wiYSDe i2+ntCivSImVglN04yEQrgTCjzOXmFTwmf5JfaDtk8qoRXedbz9boACIpcxBlAilJsxm O/Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787959085; x=1788563885; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3a//jCzePczEVRzcT1fYsbmZwFdKhukTh22rftAVB94=; b=cNun5iBFhQgGh5wGR308MpxrLxMo3Ol/84wDOphcVj9kEqBza65BwaKWT/Q1lmcM/T we8RinLjQ97iRNcqJpoJCoIOAGhPvX34vW4eohWDGD2PD0LVuTFfROTtlx07ARhnTvgB apy6oh67G+gLpB79ENn3Vh45R8xL6Z4pyBmMhivNQiJGZbd/eT5bxhdMgC30x7PWNPDl q+MFVs0Xz7dJhsX53asbYicnLcBFb3O0fWF0M8VBVe1GFMchru9QN9I+MKyi1XcMZfwz jfhpFVNb7HSgxjAPsf3OvWofEijgYPRgE1IQsB/rWyEEnFNSV4tQg62+BiV4r5AO4FkF ri+g== X-Forwarded-Encrypted: i=1; AHgh+RoaeZx9mwVBmrJMF0/5YJC/OOFQgUZAabFlNMnG1hT4aN5qVocnrRGjx+lhS3veXNxNzRcQdOtEtVkmwg==@vger.kernel.org X-Gm-Message-State: AFuF++k+zFMKZUzNPpYwe9dymRjJIdtG8gXWEqPUd/UNVfZMDnzjmLyY Jpg5Qu4tnNNC6o9Zm9d/ElSuQf8lYtR9y2kyox2TVruK6y9GrCbe/NI= X-Gm-Gg: AR+sD10PfKqc4Rnd2LfgM2E3myiZht1iRvcA1z+Yj83XKjJUyxc1Yk+rWw3ZJc1C65r bBduiIqpx2dVBHtx4n9HAgVYpkLf4QMVPjMKBRLLOl8CY1afEhfwwQVMvtdRJg17Ew4SAxDhUr9 JZs7NBbxYcfd/PcdFjC42ScHbdIub7O3KTERPhpFl0U3GPdb04gk+syzcW3ERJFf5Lr6sjLZplU IJ29ubMNtsc4z5IrTDCVJdPorozAANXQAfRls2TFIXLbgHlr0PI/LwvPmgoCdI1FWgYDr6XttpH GguMPoxB/M/ukyJ+nWzfLBSKYqiDXLXAgh0opc65K2MzAuFgo7vMVY0EphjSuYvIhbZXSiGqLMu 6+PEP0D8zEYbCa36kZxXHIlcOPnvPJFc8Utp0BXV++jCs/Ts35e/m8SGuyyKgBw6QLA7/J1QEJB pIJq8atKtqJ94SyljJ2eumxCXc6gVk9qeFUy2FNf1bTGfKuN8P6i6+HE4ygjI3d8+k1DnIoItHC A4T2s62HLnF X-Received: by 2002:a05:600c:4514:b0:499:900c:9c68 with SMTP id 5b1f17b1804b1-49b91c1f2a2mr158027275e9.6.1787959084902; Fri, 28 Aug 2026 16:18:04 -0700 (PDT) Received: from surface.. ([217.61.227.23]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b4942298fsm164518155e9.1.2026.08.28.16.18.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2026 16:18:04 -0700 (PDT) From: "D. Manresa" To: Jakob Berg Jespersen Cc: Sakari Ailus , Mauro Carvalho Chehab , =?UTF-8?q?K=C3=A9vin=20L=27h=C3=B4pital?= , Paul Kocialkowski , Daniel Scally , Jean-Michel Hautbois , Hans de Goede , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, "D . Manresa" Subject: Re: [PATCH v2 1/2] media: i2c: ov8865: fix horizontal flip control polarity Date: Sat, 29 Aug 2026 01:18:02 +0200 Message-ID: <20260828231803.29776-1-dmanresa@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260729-sp7plus-ov-flips-v2-1-91884b81a8f5@berg.pm> References: <20260729-sp7plus-ov-flips-v2-0-91884b81a8f5@berg.pm> <20260729-sp7plus-ov-flips-v2-1-91884b81a8f5@berg.pm> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, 29 Jul 2026, Jakob Berg Jespersen wrote: > The sensor's native readout is horizontally mirrored and the FORMAT2 > FLIP_HORZ bits (reg 0x3821) un-mirror it. The driver sets those bits for > V4L2_CID_HFLIP=1, so the control is inverted: HFLIP=1 yields the > un-mirrored image and HFLIP=0 the mirrored one, the opposite of what is > requested. Tested on the rear camera of a Surface Pro 7+ (OV8865 behind an IPU6, patch applied on v6.19 sources, module built out of tree and loaded on a linux-surface 6.19.8 kernel). Verified from raw captures at 3264x2448 and 1632x1224: - HFLIP now toggles the horizontal mirror as requested (verified against a fixed scene landmark and by column-profile reversal of the raw frames); - the Bayer order stays BGGR, matching the reported SBGGR10, in every flip state I could produce (HFLIP/VFLIP 0/0, 1/0, 0/1, 1/1, both readout sizes) - so no phase compensation is needed on this sensor and existing colour tunings are unaffected; - with the fix, libcamera's HFLIP=1 + VFLIP=1 correction for the 180 degree SSDB mount now yields a true 180 degree rotation: the raw frame in that state is an exact point rotation of the HFLIP=0/VFLIP=0 frame, where before the series the same request produced the horizontally mirrored image. Tested-by: D. Manresa