From: Sasha Levin <sashal@kernel.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Hans Verkuil <hverkuil@kernel.org>,
ye xingchen <ye.xingchen@zte.com.cn>,
Alessandro Menezes <alessandroasm@gmail.com>
Subject: Re: [PATCH] Revert "media: siano: Convert to use sysfs_emit_at() API"
Date: Mon, 31 Aug 2026 21:21:48 -0400 [thread overview]
Message-ID: <20260831-daily-reply-0004-siano-revert@kernel.org> (raw)
In-Reply-To: <20260830172330.3395671-1-alessandroasm@gmail.com>
> This reverts commit 2f7d0c94396e ("media: siano: Convert to use
> sysfs_emit_at() API").
>
> sysfs_emit_at() may only be used from sysfs show() methods, where the
> destination is the page-sized, page-aligned buffer that sysfs passes to
> the callback.
This looks right, but 2f7d0c94396e ("media: siano: Convert to
use sysfs_emit_at() API") is still unfixed in mainline so taking a
revert into stable now would leave us permanently diverged from
upstream.
So please have it fixed upstream first.
--
Thanks,
Sasha
prev parent reply other threads:[~2026-09-01 1:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 17:23 [PATCH] Revert "media: siano: Convert to use sysfs_emit_at() API" Alessandro Menezes
2026-09-01 1:21 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831-daily-reply-0004-siano-revert@kernel.org \
--to=sashal@kernel.org \
--cc=alessandroasm@gmail.com \
--cc=hverkuil@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stable@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox