From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FB204B5156 for ; Mon, 31 Aug 2026 16:08:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788192492; cv=none; b=jZrKLIgbL0gOrJw6KHeZo9XT4VtyvHkdqNsB1Ls9UpFxC+dKNt3ABVH/YRxziQtvrNTu0v2GcnKSxc4FryFAIZE3vjBeC3n84zYxUDgNtbOiCQckWRj72ugk0R1xfwZ+Q7BdrTCBB0re37O1pmXxyqCWvZg17xqwfik9OcNjiIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788192492; c=relaxed/simple; bh=JaYYc/MebRQQvnPhb6g6B2V4uIViyu5GZFRD0yqRn88=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AbusTmrQqhs0XPH7asrPSz6KPVm+gzkHz3MssEh5l/bgN7eS8jDG9hSg1uKS5QhThvIfkMh+n/75boAX5MZr+VX1fFu7ptqYm3OpUHUPaJtoCOVu+g7EfXyaDIR61kTaz7hGTcpoh+w8/YRkLiNnvHvUkSCGwfoPrjJOR+FqVQg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SkafsuVk; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SkafsuVk" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-49ccfae359fso14009335e9.3 for ; Mon, 31 Aug 2026 09:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788192489; x=1788797289; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xxKjjaswIqYpJP4gFTjG5f76wpVmS82nrOI8R56lUWA=; b=SkafsuVkNSzoPTrPEbZBTik6d1rsqaDqezKWcHYQt8qQmTLt198mzJD86cjFG5xNgF B5l6S3+hcq+nHtlk5stBks7gIBQ0B3r374UOfs3sayaf9ReTyAN10HA8V4sueOt2vZKE TUpVn5aeQM4K1LeoUE12wASGTMaJgFB+FdYSKca2Vkf2SVhxDUNNIC+yW/OSLqpH59sE b3bU5o18kl8eVMxiHNZT2GgwzCe/0BvZhumoYpSDqHB2wl6rGGaAYdFme2fTC6WU1E3F dLXYQlNwtyjaiVlWbcFB3Z/Gusj7qx3xFOtg0Qy4krknPpKGfEAXSgLO2nnbOjWcWns1 TeLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788192489; x=1788797289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xxKjjaswIqYpJP4gFTjG5f76wpVmS82nrOI8R56lUWA=; b=gnzXxZ3jPPpgT2gVK6QdHufW/E0wKqpR16XtmB6/OH08OUF/kGzxAmowOidRbUd24D D9UeP5jLiRzK7LKvBk7b94QSTD+GuaGtYIihZA28IAIv5SpdyH88f47lVoUZqXPFD4E1 mHEBEf0DUtRBp3NabancR/IO9TceFSmPEcg7DbbQa4pyNkJit0F9ExSEQrLu4TU0nu5A M0BONg5rjMtdxGpxJtO3nUjKCsJopYOPrYeCNZ9LClIEOImgiRQOHfihSPFncjfBkKNq C89NRCE1niQligiDb8qY5elA4GZWCT82dF1Uw1KQWIJ0y7q8yXxKNqpXiC6hZnSslkaJ PLdQ== X-Forwarded-Encrypted: i=1; AHgh+RpNOh7qdvW3OOoJlnJKolPkPc5+STNaCH/7IAw0bA/AmWHK6SxycGabNFwQaflFq9Mi2X1mC+LozmfNRg==@vger.kernel.org X-Gm-Message-State: AFuF++kZ224u64BlxLr3sa0rCHJ3C7ideOy5TcgoN18+17+6PLcwWHLb 6GmV9+i+wN4QHoCwab0y5jdm8yszsJHNRX74EuVFGmmRWPBcF2ZOC/w/ X-Gm-Gg: AR+sD10MP6K98vZAavOvTAizoN+3eblHk9a4MQpPsCUeLCMiGyYgAa9a3T/avzIniiQ WvLaD1hMKNgfjkF0b/VwYkg7mNLv572YT3H2Eey/132amJH4UanYl02gk9U3bvEUPNeNf1xT1Fq neZPEGvX3sxGCGlpHbPUtK3RnD/95TjwVu5inEpX9Uq7HM+Xbo89fy85Eg1QD0QnZaO3MSts7jt 6ijQjseAU3BFreD82Id48HSKDlad9KYCFhK/AA/fI9Ih38zTSn2Mtir10XvbT1IJvPhRheZewp7 HYGKrL36d/66LQqRJU7o1wybC3sKllTaxC4x7BTIMZWkZnxM1vOJmoXlAzEDbldi/vjqALqL8sA 4X+zZa9yWjWgboa3lRlgxQ2KxIqVY7EFTzkzSLamMACBZDqbkiYJJ6+SzH3oK0HSWAnHwkwAAX6 WdqEQds2IObgnRZqP2Q0lXYJMmLHcxCd4g09OolMye/g53LbgLwNqF+CVlWO2M+VJDVFY= X-Received: by 2002:a05:600c:1c0a:b0:499:51f0:a9b2 with SMTP id 5b1f17b1804b1-49b91c1dd3fmr440541835e9.1.1788192488967; Mon, 31 Aug 2026 09:08:08 -0700 (PDT) Received: from TC-LAPTOP ([2a01:e0a:b8a:2610:ccbd:b529:37d3:c1b8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482fbab3f3asm23849760f8f.3.2026.08.31.09.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2026 09:08:08 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, andriy.shevchenko@intel.com, v.vitovt@gmail.com, Thierry Chatard Subject: [PATCH v10 5/8] platform/x86: int3472: tps68470: use a common always-on VIO regulator init_data Date: Mon, 31 Aug 2026 18:07:51 +0200 Message-ID: <20260831160754.9857-6-tchatard@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260831160754.9857-1-tchatard@gmail.com> References: <20260831160754.9857-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The surface_go and intel_nvl board data define byte-identical VIO regulator init_data (1.8006 V, apply_uV, always_on). Replace both with a single shared common_tps68470_vio_reg_init_data so new boards with the same requirement can reuse it instead of duplicating the definition. No functional change. Assisted-by: Claude Code:claude-opus-4-8 Signed-off-by: Thierry Chatard --- .../x86/intel/int3472/tps68470_board_data.c | 21 +++++++------------ 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c index c53542465..c2ec802fc 100644 --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c @@ -75,8 +75,12 @@ static const struct regulator_init_data surface_go_tps68470_vcm_reg_init_data = .consumer_supplies = int347a_vcm_consumer_supplies, }; -/* Ensure the always-on VIO regulator has the same voltage as VSIO */ -static const struct regulator_init_data surface_go_tps68470_vio_reg_init_data = { +/* + * Common always-on VIO regulator init_data. Its voltage must match VSIO; + * boards using the TPS68470 I2C pass-through that need this exact setting + * can share this instead of defining their own. + */ +static const struct regulator_init_data common_tps68470_vio_reg_init_data = { .constraints = { .min_uV = 1800600, .max_uV = 1800600, @@ -123,7 +127,7 @@ static const struct tps68470_regulator_platform_data surface_go_tps68470_pdata = [TPS68470_CORE] = &surface_go_tps68470_core_reg_init_data, [TPS68470_ANA] = &surface_go_tps68470_ana_reg_init_data, [TPS68470_VCM] = &surface_go_tps68470_vcm_reg_init_data, - [TPS68470_VIO] = &surface_go_tps68470_vio_reg_init_data, + [TPS68470_VIO] = &common_tps68470_vio_reg_init_data, [TPS68470_VSIO] = &surface_go_tps68470_vsio_reg_init_data, [TPS68470_AUX1] = &surface_go_tps68470_aux1_reg_init_data, [TPS68470_AUX2] = &surface_go_tps68470_aux2_reg_init_data, @@ -339,15 +343,6 @@ static const struct regulator_init_data intel_nvl_tps68470_vcm_reg_init_data = { .consumer_supplies = ovti13b1_vcm_consumer_supplies, }; -/* Ensure the always-on VIO regulator has the same voltage as VSIO */ -static const struct regulator_init_data intel_nvl_tps68470_vio_reg_init_data = { - .constraints = { - .min_uV = 1800600, - .max_uV = 1800600, - .apply_uV = true, - .always_on = true, - }, -}; static const struct regulator_init_data intel_nvl_tps68470_vsio_reg_init_data = { .constraints = { .min_uV = 1800600, @@ -364,7 +359,7 @@ static const struct tps68470_regulator_platform_data intel_nvl_tps68470_pdata = [TPS68470_CORE] = &intel_nvl_tps68470_core_reg_init_data, [TPS68470_ANA] = &intel_nvl_tps68470_ana_reg_init_data, [TPS68470_VCM] = &intel_nvl_tps68470_vcm_reg_init_data, - [TPS68470_VIO] = &intel_nvl_tps68470_vio_reg_init_data, + [TPS68470_VIO] = &common_tps68470_vio_reg_init_data, [TPS68470_VSIO] = &intel_nvl_tps68470_vsio_reg_init_data, }, }; -- 2.53.0