From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 896394A0907 for ; Wed, 2 Sep 2026 13:59:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788357574; cv=none; b=XY2gk/iSXzI8C+uBWTKaDbmtEX56t1ibYIBIdPBnaXqjqA3YbCAguQ5aci0YhQuFddWiF1Cf0Zf0MRXh2q/SS3fiyCXYrw3+gLLactXgNZIMCCwAe1Aqhmlm6Oy1uxNbXwpLBXZ3r8WLF7FEKbeEdbwqEmQfJ7MgY4GuP8LqOwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788357574; c=relaxed/simple; bh=/9eZmU2D0hbNHb92ePV2OaMpbatPpO6xeRcbdoGIcR4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=M6WT1/kJLwi5D2p96uehn63wqMBPsjJbTAFzxBGlxL07lpWLm5cGveqsNxJqWLna7sn6ZNBS3/zJtzXSJ7DBLGclhdt21Pv+ZmK46RV4K0o6lGNpZerHc6wf9jWfmOXYF/piOrnTW4gJtAHunR0liox+SZMc33MdLWnd68TZ6fg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XnA6rvNU; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XnA6rvNU" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-cc1cbb64a1fso1222782a12.1 for ; Wed, 02 Sep 2026 06:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788357572; x=1788962372; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=hrAS7URR96Vhxqaift3zBbsgPvJL26DLyKnxdnXVft4=; b=XnA6rvNUeg5GKgp5saQqJIwI/nqFJpjDlylEZM/agR/kSXe5e3c6bAVMt1Gvk7VCCf vqBr3XK+fIVZ87BXPBpvtxlKsdyPDqWLZLnJ3108EsAVM4z+sphU+MpLyWQDwz7ZiZTn GzE0CfBpO6a1kMheOlupfokE1Mi90LO7hUL0zm8jo+8MBi5GaOQDYzDbi3IjLCbT1PbL l4KMCI+uHc1qZAw7sIXEArNwsVgnAYG27s7ebDePdgiJbWs/GUCmNJLSkhSCT533fhl4 yQa6dsRYkLvH71UcEr2dlq0gvvrc/c8fq1cuxQsueEU3aQAn1eD+6Ul01GcnOAfoxBzn Wj2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788357572; x=1788962372; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hrAS7URR96Vhxqaift3zBbsgPvJL26DLyKnxdnXVft4=; b=GZ2jGNIShKRAPrUZuXC6S/VEtDYUTjUoQq2ccmr69uUIqiqrhs24JYfu6Akr7ZnLwm wf4ihAa9Bg/ldYyjK0un4eaHO8NvESxgFXwX5rRWz+oguK37pnEdheBwRr3y4Tti4TP2 IT9ofhpQi0tTYRNZ95n5gAsza4/qSqRFiEwa53ekpVEWCw8S7t3YEg6S0gLKPQTiLWX4 sfkad8qhUrsdwE6k87ixB+ZkH38WIOtwq5wN865s3vOagfc6vg3cWLO7hpJeq39fU1w7 sMRCPSK+sNyedo8MtpqJp6Q0yzikKvJD37mBtWVN/338GxbDNsZelD6O/om2+6uIgfx+ 5Ulg== X-Gm-Message-State: AFuF++n0J5p1i1yo2DlBgy1e7XJgdIwoP+Wp7lJeYs9cA4aa9XeRhmAP nzDghFFiki0CYM6+eA94Y7nBNatSwmFsQLPhvdeZAwaOAVAotgtKyOTpE66edlqw X-Gm-Gg: AYBFou2YESOxPH067PmaH+p9gN4P8PIUdGaZcTYQISM2YrOid4uv+/e9mvmd8d4Rq1w ZKL6XaPCP9Zgfnk5mg9WkocayabsEXcu7GejlaAa9N5YTsMQ+J5YJVc8VhNUR/q8MCqzh1SDXpU hbgz4BUdyMOCMehEfT0x6zRJ0VR/eFXJKdRsdpt6wZ9LqpJAcwtMtpzXuYSxAQbdu3wwBQs64Kn 3Tfp0TXa9wFyVgtQLs5kfe4Bzg0vTutT1WbGYxIh28z8l3BjHvAgG1Kq7DE9I+z3S2IumQeOkgJ mXz1chsyZqBUt5N0a/N6PsnLBVr2BGlmR9/GJrUbOi4gwXmlyPKZSqPQ114o7H4j+rapFa+czQk gHPVwNAvqEkUAo7fb72dQOfPCCYNCDdnXhi9rZyv5Py8WQM0nk/4qnyy1SRIdOESALoqr/dalAr awf29YppZz1pq8BlH4G5geoTPYdGvLZk89stCcwV5JB85WTQOI3a1iPLhZtuNQPTroBt6/eiaBy WA/g5hOlLXwt0imVrQ8CjZabDy10XVPdl3Atn731E1cc2uMrfgQ8MuFqP+Vv+Kv3yd1MUCT91Th l9jG3PI/HHAaOXy7JkWfG4FoTW87j2gb8rffuIuT628= X-Received: by 2002:a17:90a:ec8c:b0:38e:5964:97a8 with SMTP id 98e67ed59e1d1-39aee04ace5mr8324115a91.16.1788357571759; Wed, 02 Sep 2026 06:59:31 -0700 (PDT) Received: from alanhc-14700.tailb22ec2.ts.net (180-177-138-120.dynamic.kbronet.com.tw. [180.177.138.120]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3990bd21e9dsm12123595a91.4.2026.09.02.06.59.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 06:59:31 -0700 (PDT) From: Hung-Chun Tseng To: Sumit Semwal , =?UTF-8?q?Christian=20K=C3=B6nig?= Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Hung-Chun Tseng Subject: [PATCH v2] dma-buf: fix stale return value documentation for dma_buf_set_name() Date: Wed, 2 Sep 2026 21:59:23 +0800 Message-ID: <20260902135923.3599022-1-alan.tseng.cs@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The kernel-doc for dma_buf_set_name() still documents an -EBUSY return for the case where the dma-buf is already attached to devices: Returns 0 on success. If the dma-buf buffer is already attached to devices, return -EBUSY. That has not been true since commit e73c317efbf9 ("dma-buf: remove restriction of IOCTL:DMA_BUF_SET_NAME"), which dropped the dma_resv_lock() and the !list_empty(&dmabuf->attachments) check that produced -EBUSY. That commit updated the description paragraph above, but left the return value description behind. The only failure the function can report now comes from strndup_user(), propagated via PTR_ERR(); every other path returns 0. Document that instead, using a Return: section so kernel-doc picks it up. No functional change. Fixes: e73c317efbf9 ("dma-buf: remove restriction of IOCTL:DMA_BUF_SET_NAME") Signed-off-by: Hung-Chun Tseng --- Changes in v2: - Use a "Return:" section so kernel-doc actually parses the return value description; scripts/kernel-doc -none -Wall reported "No description found for return value of 'dma_buf_set_name'" before this change and is quiet after it. - Reference the commit that made the -EBUSY text stale, and add a Fixes: tag for it. - Resend to the dma-buf maintainers and dri-devel; v1 only reached linux-media, where it was marked "Not Applicable". v1: https://lore.kernel.org/linux-media/20260730003153.4030818-1-alan.tseng.cs@gmail.com/ drivers/dma-buf/dma-buf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index d504c636dc..6ee3c254d7 100644 --- a/drivers/dma-buf/dma-buf.c +++ b/drivers/dma-buf/dma-buf.c @@ -413,9 +413,8 @@ static __poll_t dma_buf_poll(struct file *file, poll_table *poll) * @buf: [in] A piece of userspace memory that contains the name of * the dma-buf. * - * Returns 0 on success. If the dma-buf buffer is already attached to - * devices, return -EBUSY. - * + * Return: 0 on success, or a negative error code from strndup_user() on + * failure. */ static long dma_buf_set_name(struct dma_buf *dmabuf, const char __user *buf) { -- 2.43.0