From: German <germanpapulindez@gmail.com>
To: linux-media@vger.kernel.org
Cc: German <germanpapulindez@gmail.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: [PATCH] media: staging: ipu7: declare firmware files with MODULE_FIRMWARE
Date: Thu, 3 Sep 2026 10:40:51 +0200 [thread overview]
Message-ID: <20260903084052.17893-1-germanpapulindez@gmail.com> (raw)
drivers/staging/media/ipu7/ipu7.h already defines the three firmware
blob names the driver can request at runtime depending on the SoC
generation:
IPU7_FIRMWARE_NAME "intel/ipu/ipu7_fw.bin"
IPU7P5_FIRMWARE_NAME "intel/ipu/ipu7ptl_fw.bin"
IPU8_FIRMWARE_NAME "intel/ipu/ipu8_fw.bin"
but ipu7.c never declares them via MODULE_FIRMWARE(), so tools that
rely on modinfo to discover firmware dependencies (most initramfs/
initrd generators, e.g. mkinitcpio, dracut) can't automatically
include the right blob for this driver.
$ modinfo -k $(uname -r) intel_ipu7 | grep -iE "firmware|filename"
filename: /lib/modules/7.2.2-arch1-1/kernel/drivers/staging/media/ipu7/intel-ipu7.ko.zst
No "firmware:" line is printed at all, even though the driver does
load one of the three blobs above at probe time (confirmed separately
via dmesg on real Lunar Lake/IPU7 hardware - "firmware cpd file:
intel/ipu/ipu7_fw.bin" - so the dependency is real, just not declared
to modinfo).
This is low priority/cosmetic on distros that ship the full
linux-firmware package unconditionally (as Arch does), but matters
for anyone building a minimal initramfs, or packaging this driver
for a distro that only pulls in firmware modinfo declares.
Signed-off-by: German <germanpapulindez@gmail.com>
---
drivers/staging/media/ipu7/ipu7.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/media/ipu7/ipu7.c b/drivers/staging/media/ipu7/ipu7.c
index ee6b63717ed3..77c474f8a5c0 100644
--- a/drivers/staging/media/ipu7/ipu7.c
+++ b/drivers/staging/media/ipu7/ipu7.c
@@ -2774,3 +2774,7 @@ MODULE_AUTHOR("Qingwu Zhang <qingwu.zhang@intel.com>");
MODULE_AUTHOR("Intel");
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Intel ipu7 pci driver");
+
+MODULE_FIRMWARE(IPU7_FIRMWARE_NAME);
+MODULE_FIRMWARE(IPU7P5_FIRMWARE_NAME);
+MODULE_FIRMWARE(IPU8_FIRMWARE_NAME);
--
2.51.0
next reply other threads:[~2026-09-03 8:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 8:40 German [this message]
2026-09-04 8:31 ` [PATCH] media: staging: ipu7: declare firmware files with MODULE_FIRMWARE Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903084052.17893-1-germanpapulindez@gmail.com \
--to=germanpapulindez@gmail.com \
--cc=bingbu.cao@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox