Linux Media Controller development
 help / color / mirror / Atom feed
From: Sergey Lebedev <lsa.uz@pm.me>
To: German Pablo Lindo <germanpapulindez@gmail.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans de Goede <hansg@kernel.org>,
	Dan Scally <dan.scally@ideasonboard.com>,
	linux-media@vger.kernel.org
Subject: Re: Test [PATCH] media: ipu-bridge: the Surface Pro 11 rear sensor is mounted upside down
Date: Sun, 13 Sep 2026 17:23:39 +0000	[thread overview]
Message-ID: <20260913172332.85174-1-lsa.uz@pm.me> (raw)
In-Reply-To: <20260913170144.5491-1-germanpapulindez@gmail.com>

Thank you. I will carry your tag to the next version.

I want to be sure I understand your result. Please answer yes or no:

  1. Is the image now correct on screen, not upside down?
  2. Did you check this in Gnome Snapshot?
  3. Did you check this in qcam?
  4. Did you check this in Firefox?
  5. Was it correct in the live preview, the moving picture?
  6. Was it correct in a photo file you saved?

Questions 5 and 6 matter most. A program can turn the picture on the screen
and still save the file the old way. I only tested saved files here.

If the answer to 1 is no, that is fine. It does not make the patch wrong.
The patch makes the kernel report the correct rotation. That is all it
claims to do.

I ask because I tested it here. I captured the same scene twice: once with
the patch, once without it. Both images are the same way up. The patch did
not turn the picture. It only changed the number libcamera reports, from 0
to 180.

So if your image is now correct, your program is turning it, using that
number. I could not see that here, and I would like to repeat what you did.
I have the same tablet. Please send:

  uname -r
  pacman -Q libcamera          (or your distribution's command)

and the version of whichever program showed the correct image.

If I can match your setup, I can find which program does the rotation. Then
it is a question for that program, not for the kernel.

Sergey


  reply	other threads:[~2026-09-13 17:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 15:35 [PATCH] media: ipu-bridge: the Surface Pro 11 rear sensor is mounted upside down Sergey Lebedev
2026-09-13 17:01 ` Test " German Pablo Lindo
2026-09-13 17:23   ` Sergey Lebedev [this message]
2026-09-13 18:57     ` More details for " German Pablo Lindo
2026-09-13 19:24       ` Sergey Lebedev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260913172332.85174-1-lsa.uz@pm.me \
    --to=lsa.uz@pm.me \
    --cc=dan.scally@ideasonboard.com \
    --cc=germanpapulindez@gmail.com \
    --cc=hansg@kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox