From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E6193AB288 for ; Tue, 15 Sep 2026 11:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789473493; cv=none; b=LyiOwHDe3/ebLdU+6OGmu1F0bLNu9lFNDC9FzjmYYiPfI71WTD4irJc10mlVcf4I2YD23ahm/kS57BeEIg1ptvCY8mW1nMKG9Pj4fX0iFgkkBhvy+RCkFF9/7e0j0fYcc1rjsYIzykEik8zG1gNClrAj65kRN9yxY1cUHnSGO0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789473493; c=relaxed/simple; bh=8g5Sd3uFifK3ZVwdy+TGQIZh+jmWxcGuzGLJlv4ed50=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=T0ij8QCGrQK3xbhotIKctEtJhqSqxjMJgp+wykof7+YYW6bWLpMGh5sGLo9GEl2RTzVDkfLRvxUONN5nNahRu5PxMrVdx3dKKT3Uqp9v7PJJCvEle7EiPVoX8weauk25Atsd4Iwl4ksMJlkZUEyoFq3dKxCNn2kIKod608qe7rA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UJOgV5xm; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UJOgV5xm" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-396ccb1a98fso2388467a91.1 for ; Tue, 15 Sep 2026 04:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789473492; x=1790078292; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=BrGTdKyYWPDzcFJDUsLHUxteyx4n5jj5bbwXZChmZq4=; b=UJOgV5xmpcexrx8WPOzF9+dgeAnoI4fLkiJQBwICqMb4rqapGLQSNET7cz+2SLajNI WDg+PsecXJMOVrUsub/T31Ol1fpThGMqBdexgwxa0hsnCSEWa8QCmlPmE12vyDDeVMD/ +7RHE2w+yrWIcffX13f3zwkHpnz+99yldeqfXvPvNDa6ckxAxOVmUTCBmuST1RfdOW8C 0XAE6rKzw+0JtIAzqwUytVkFRSvh1htg7Ow00kMDHACP87Dfq5JscoWCAMZAMCmHyMZB fmBQAmcIO+DypvpTOLciOnZADrXzLR00iIyQOgPR4Y8eYQx93Lo483onOkYrYZvXCWUg G55Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789473492; x=1790078292; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BrGTdKyYWPDzcFJDUsLHUxteyx4n5jj5bbwXZChmZq4=; b=mRc9d8XfnhiRnvEOqwmqKKJi36i84EMHY9iCMRHAGxeOaXBeoTTQPIrk8hftS4c8QK MdKl4YvGLL/FEVzqlO9Y+0ZRb73eVKnfN2xSQ7p4YWL6xll/LrC0Pa7cC6pItjzE2DOr kL4+EOXauE59jZjgTASAaQVNafiwvvVHUn+JpH4zRjkIEgxVw0TZ3hvrY/GWY0tcW1hu R5E6xpalGkDfVQbEzGjdaNhEHQOdlA5jWkGo3IM7R7UwpwBN/jnUQbmMpxUsSNMKx2Fh tv/OBdl8hnKnEQ2Nzno99vCOMtTpcPmwE4mUb1gncGfoRm1XmZ/Ldr5MUfEp6Yr0xelM pPrg== X-Forwarded-Encrypted: i=1; AKwUvBzINNOtu3z3M3E2RC3iQb2KWe2jzY4AtTVSwcoRszZTTYvhvoQKBK4u3wy793fDPJqN6BUOa/eYPjMSUw==@vger.kernel.org X-Gm-Message-State: AFuF++kYTq5hG5CiBB/s7rFHDMCu0MYxeokj8hki/l+VMZ79fiYh3KRN auCIqLb33sY0xb85iBWyx8sFrAUbpaEX5TnsVfeFjXEGjuvyzyMBXQLC X-Gm-Gg: AYBFou1A3MyzwIrDJ9275PpNvPZqBlRm1FT1yaRvwtrNl4T00dvkR1K3GZNVN2qzzF+ x5bskcTNxTxjyDalP17vcKJMW7brSkbT6DrI7q8wdczHiYAI3e3LC+U25gma3ImSa++MferQtdl +TM/ZyhRNDTwC+G41mpAAb2WO528/43nRMf9o9GWd2QUAhvXz297C1RlVK0hwyLJhISALf3hekM lkqj/seJLIjtbUzImPHEK8//d5W34ZUV9Gs1q968vX4PMkJL5ey7jwaV3X0fmqAKYWamgU68VaI OCJGxZ2GMgfBh5wXB1RJ9/XEdRiryKdJH/UBc67EvL9p4elMK0CsfiOPTbnPMLd6JMX3Ch0AszR VUzi/oE1rrmkB1SX5PAWHn24e5ex/Odfs8WEUz4Dt2LSkP+U+Rz+NJ2EsOXwXTKU5d+rHPzZ9ws IHRPhWJkiiuoYeojjoZ89PLGNK0iUDT2eIN0xbN8ftKsyDwFz11nkTNQ== X-Received: by 2002:a17:90a:d648:b0:39d:cbb1:c96f with SMTP id 98e67ed59e1d1-39dec09a779mr13558544a91.18.1789473491565; Tue, 15 Sep 2026 04:58:11 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1002::de93]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39dfdacba6bsm4953697a91.14.2026.09.15.04.58.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 04:58:10 -0700 (PDT) From: Guangshuo Li To: Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno , Nicolas Dufresne , Fei Shao , Kees Cook , Guangshuo Li , Chen-Yu Tsai , Hans Verkuil , Steve Cho , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: stable@vger.kernel.org Subject: [PATCH] media: mediatek: vcodec: destroy core workqueue on remove Date: Tue, 15 Sep 2026 19:57:53 +0800 Message-ID: <20260915115753.2411047-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The decoder probe allocates core_workqueue for latency-based decoder architectures. The probe failure paths destroy the workqueue, but the normal remove path only destroys decode_workqueue. As a result, removing a latency-based decoder leaves core_workqueue allocated after the device lifetime has ended. Destroy core_workqueue during remove for latency-based decoder architectures, matching the cleanup performed by the probe failure paths. This issue was found by manual code inspection. Fixes: 365e4ba01df4 ("media: mtk-vcodec: Add work queue for core hardware decode") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- .../media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c index e936ed8dffba..426d060d937c 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c @@ -570,6 +570,8 @@ static void mtk_vcodec_dec_remove(struct platform_device *pdev) struct mtk_vcodec_dec_dev *dev = platform_get_drvdata(pdev); destroy_workqueue(dev->decode_workqueue); + if (IS_VDEC_LAT_ARCH(dev->vdec_pdata->hw_arch)) + destroy_workqueue(dev->core_workqueue); if (media_devnode_is_registered(dev->mdev_dec.devnode)) { media_device_unregister(&dev->mdev_dec); -- 2.43.0