From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-06.mail-europe.com (mail-06.mail-europe.com [85.9.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC4C348EC8F for ; Mon, 21 Sep 2026 13:01:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.9.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789995676; cv=none; b=FdZF54+SToW+GUtQUcbf9R6xQgNffOP4B0UMEl443wVPKOHh45gn2q5fdgvin9zRKAe2ODSeNO+VqeLoeZfax7PLL+ypdAWolf3WrXWoKZ7pXgdsuF3D2AF/sMTuQCkXPC5TcG5v0DLz65ipKoSw2DDqacgT4qt5Rtn7R1+5FkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789995676; c=relaxed/simple; bh=+UwjiZrchWMNmc9IYXnFU9yFxXs1bhtYuw6HbaPEMBo=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=heVS5r7hUgtIIo9qjmdlDbgtpJxLppJ7cqyr4Y4S7UedqGSMwidgReYYKvjjKdXRIm5gLON05BWPfKgf2VYvyOHJroKbpJKhoww5Cdrgy2OhYSvvP0CZtK6qjFqYqjR+EKED4lN+ftEFePqOJopODLZ9yvTH1rPr0gh8cFYkTF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=pm.me; spf=pass smtp.mailfrom=pm.me; dkim=pass (2048-bit key) header.d=pm.me header.i=@pm.me header.b=Xr1ZySUT; arc=none smtp.client-ip=85.9.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=pm.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pm.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pm.me header.i=@pm.me header.b="Xr1ZySUT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail3; t=1789995659; x=1790254859; bh=z9lx7/98NMh4Z1OM2zipNmgn2bDt5PWUnV9/wJKsrDU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Xr1ZySUTHdMyd/JhSA0Ee6xJwg80DvD77zS/Coti7uJNWesDzbj3rmPB6cCg0BrDh EVB78TZvWG4N3ROrfkmvSkjG/+I17H+0S0cWiyLDYlxUPqSfNUkYURS/zEuzbZ5x4Z 7L2Bv572+5SBE5VUt1iWu8oOk66maZuHbs95z4P8yGAzx0TPc7uM/9Zwo9qFZxoiEa m47Fv43Mlc2pn4Pdz+dQV700YVOA018c71WdKh/1HyCSlyiEPGvU9AycngPS8MZ1eA qpy8fAy4I/HNnNIr49z2qyNPPtJp6Q+vCmT20gZHqa8pBFlrRVYP6RipyzK5128JtN crXXq6kA1ZGpQ== Date: Mon, 21 Sep 2026 13:00:53 +0000 To: Sakari Ailus , linux-media@vger.kernel.org From: Sergey Lebedev Cc: Kieran Bingham , Dave Stevenson , Mauro Carvalho Chehab , German Pablo Lindo , linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: i2c: ov13858: add horizontal and vertical flip controls Message-ID: <20260921130046.80552-1-lsa.uz@pm.me> In-Reply-To: References: <20260921082609.30830-1-lsa.uz@pm.me> <178998112223.1723501.7946524742858282804@ping.linuxembedded.co.uk> Feedback-ID: 113843758:user:proton X-Pm-Message-ID: a99a1ccaa8ce3360abb74f32e46771aaa89bc807 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable v2 is posted, as its own thread: https://lore.kernel.org/all/20260921124444.79396-1-lsa.uz@pm.me/ Sakari - it does not do the set_selection() part, and the changelog says why at length. The short of it: ov13858 has no get_selection or set_selection at all, so there is no crop rectangle for the flips to move, and ov13b10 writes its window offsets register-side without exposing one either. Glad to add selection support as its own patch if you would like it here. Kieran, Dave - everything you both raised is in v2. Sergey