From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46C9A3FF1AE for ; Tue, 22 Sep 2026 12:05:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790078750; cv=none; b=Ep/L4FZfKVUOeOnZCvsIRK63ncgwM2358XLsYBJGLa9bYnMBQgTQJX6/+vm6FoPL90Ww8+9rMzet/t3xtYTEpoUAIhur6sy5V6VgF4p86Bm3Qlpr03Q38TjIoOuuqtExzLrVWnhZYhRZULcLk0eyfEOze4FHCRgn9OTDNXw7LTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790078750; c=relaxed/simple; bh=dyFop+GWK8kPwETce6O6U3jKi8pEOcQXQbDk8OF3Fhg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Eh3MyHMRY8qkwhY/06TMGQoKs4KDau3GHgNUZWfdeWRfxSwC8cU0Q/jatmnyl5OQq6oa60zTMDQAlaeTEVa72FDFK1+ADCsJ9vx/dF4HulVMbU7Uhi3OsfScmycaDNBQ+jBBzHx46l0NLQXbBZ4CP33/WEltsrpSMIjMMt002cQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jjQsNwYp; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jjQsNwYp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1790078748; x=1821614748; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dyFop+GWK8kPwETce6O6U3jKi8pEOcQXQbDk8OF3Fhg=; b=jjQsNwYpqiRgy1bQJXhNFBEh2uVbgmUS1NwGE1GGVadcpm+L1xXKhQYs pPbVALApxVy2UCtCllFuwrtGoAoNvQO4Y0Zq1xtfOayOvpUYabpHHHt0D f4BNmkxa7x3Rua0VMGX0qhHTzsm6IQWanDb+sW2fzX38Ww9O1EIBkp6bH IFwOFEqIFCHPECuEwnHXS2/gtcBh5LzsL2V+QVDp33ggeaXmnocUhblqM j5/ot9O1p1Yb8vwpimgnQLD6y0B+hyIdg9XO8GVYZNyRjLAnoP9v+hLyf xTGuMl3cF14Ay3fTtRCPmKT6GQNG4/iCh6+1JPv8oaHtENh7bpQghI7g5 g==; X-CSE-ConnectionGUID: zHWNupvUQNCMmRVgDSgu/A== X-CSE-MsgGUID: jstHEyg1REufsDxr85roFA== X-IronPort-AV: E=McAfee;i="6800,10657,11912"; a="78227085" X-IronPort-AV: E=Sophos;i="6.27,116,1787036400"; d="scan'208";a="78227085" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2026 05:05:47 -0700 X-CSE-ConnectionGUID: fSKzZrVNT0Kvxy+ZIWiFkg== X-CSE-MsgGUID: PWEdX28MRZybJmwklcEYXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,116,1787036400"; d="scan'208";a="301029153" Received: from carterle-desk.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.41]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2026 05:05:45 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id A94A4121CA4; Tue, 22 Sep 2026 15:05:40 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1x8zFi-00000003lHw-3YSg; Tue, 22 Sep 2026 15:05:38 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: "Yan, Dongcheng" , Mehdi Djait , "Yu, Ong Hock" , "Ng, Khai Wen" , Antti Laakso , "Bajpai, Manik" , Divyamani Tripathi , Nicola Fiorillo Subject: [PATCH v3 07/21] media: ipu6: Get watermark configuration directly from ipdata Date: Tue, 22 Sep 2026 15:05:24 +0300 Message-ID: <20260922120538.896684-8-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260922120538.896684-1-sakari.ailus@linux.intel.com> References: <20260922120538.896684-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of passing watermark configuration data around, get it directly from IPU variant specific static data structure. Signed-off-by: Sakari Ailus --- drivers/media/pci/intel/ipu6/ipu6-isys-video.c | 12 ++++-------- drivers/media/pci/intel/ipu6/ipu6-isys-video.h | 2 -- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c index 3d455872f29a..b3cbd4266da1 100644 --- a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c @@ -657,8 +657,6 @@ void ipu6_isys_configure_stream_watermark(struct ipu6_isys_video *av, av->watermark.width = ipu6_isys_get_frame_width(av); av->watermark.height = ipu6_isys_get_frame_height(av); - av->watermark.sram_gran_shift = isys->pdata->ipdata->sram_gran_shift; - av->watermark.sram_gran_size = isys->pdata->ipdata->sram_gran_size; ret = v4l2_g_ctrl(esd->ctrl_handler, &hb); if (!ret && hb.value >= 0) @@ -697,17 +695,15 @@ static void calculate_stream_datarate(struct ipu6_isys_video *av) ipu6_isys_get_isys_format(ipu6_isys_get_format(av), 0); u32 pages_per_line, pb_bytes_per_line, pixels_per_line, bytes_per_line; u64 line_time_ns, stream_data_rate; - u16 shift, size; - - shift = watermark->sram_gran_shift; - size = watermark->sram_gran_size; pixels_per_line = watermark->width + watermark->hblank; line_time_ns = div_u64(pixels_per_line * NSEC_PER_SEC, watermark->pixel_rate); bytes_per_line = watermark->width * pfmt->bpp / 8; - pages_per_line = DIV_ROUND_UP(bytes_per_line, size); - pb_bytes_per_line = pages_per_line << shift; + pages_per_line = DIV_ROUND_UP(bytes_per_line, + av->isys->pdata->ipdata->sram_gran_size); + pb_bytes_per_line = + pages_per_line << av->isys->pdata->ipdata->sram_gran_shift; stream_data_rate = div64_u64(pb_bytes_per_line * 1000, line_time_ns); watermark->stream_data_rate = stream_data_rate; diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-video.h b/drivers/media/pci/intel/ipu6/ipu6-isys-video.h index 5e522686135f..4c890c6af8f5 100644 --- a/drivers/media/pci/intel/ipu6/ipu6-isys-video.h +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-video.h @@ -73,8 +73,6 @@ struct video_stream_watermark { u32 frame_rate; u64 pixel_rate; u64 stream_data_rate; - u16 sram_gran_shift; - u16 sram_gran_size; struct list_head stream_node; }; -- 2.47.3