From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 884DE3C988D for ; Fri, 25 Sep 2026 19:16:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790363820; cv=none; b=X/kE9FkBfppglHVvyk3EXsoOPvcWM/pGhP/9RLz3TpUgW+R2E/VDB7v19y/LPiWNACFEpR/tKFG6TxYb0VePDI7y/x6vibfB4zJBnnnpQHxNfwYTFwUqkskyoo7Bxkyjsr9MrpoVuVcM9u1LtVHxhEASTD90V/iepsl82F3kkjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790363820; c=relaxed/simple; bh=j5qbuXrDX2plwlT/z3lSzoNInbPkdLmaRYkhQoo2lGM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G46ZSEcazwoNkc5MEf10Vnl6AOidX1ZbmBlDHwyOd+MClAWXPe9QobLnrF6i+NUn3naNQOWrqDRbQqJ5TywEb1kMGcj5OlN9z9YWOW3mZ94uczkUp772R1pxsGeRrUtbSE2kh4YjXxd4PW2YZI1+voL4WrcgbSj9K46E0LAlXlk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dlL1i+Bb; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dlL1i+Bb" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-93be6d3f424so174745385a.1 for ; Fri, 25 Sep 2026 12:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790363817; x=1790968617; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Lfjo9pAawGhp175tsWiMgt+u8R0WsNzuMBsHkL3MrJQ=; b=dlL1i+Bb52Um433seW73O7dcdH2e9hWMsQX+rkvscV9Wvdz1mMrjVsY8GOXoqxQPlm Aoaqyse9+uuHpidc3CS+twF+Jne+LMAUql8wYeQvqEMkUX1q2C73CiAjOZC8lHnh6+B7 BCHVcgtJua85zps8cZCXW3c9BvLo5WwoJwOcYmzsIPYOaDf4Yaw6V+a3FF7crvYdg3xc 6dBRCCT/+lKxH0RYDQC94f0gZioKD+dRED9+rvrHZSVRdWjgDxotXx9Qa9oL5K6c4NkG OTd8VRbToR4KaOvcs9VScSqpX6qWsbi9NHV/ECPPK4WJqhuLGfm/NiXe6HZ9B73Vbxwa MpWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790363817; x=1790968617; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Lfjo9pAawGhp175tsWiMgt+u8R0WsNzuMBsHkL3MrJQ=; b=yrLnDe5ss+o+wklyvIQ2kCDZH167dX/EJI9IG8THrPWVoK1JJdQexCiuNx2FU+EsNw Yox5jPEEXU4kxaJvYusacONwyaKFa8hHppEwRMGlZEZ6qPKW8tKjd5WXE0gFhLHlPruf nCVwFdflodNEkgo6DzmilDzgqHC26m/xbm0nVBJiIhwtu6UwvS3CX9Z7TlnfxL6SJ6Sz 9uUW1wHPRQCaE8Zp6qS9tNWv5dZE9CE/5qBO9q9ODFHzYFmXBVTPI/0c4Lb/TNpj3cAc GZfoZ29p1GI2YisQ7BABbF9m0otTPT7Syk9PGAnOq8LoNo5EaQHq8zhQgi3Liu5U2fKl 9f0Q== X-Forwarded-Encrypted: i=1; AKwUvBxzVnBnNTS0uoy2w19stsfbpiCIigKdRWR1gB/w8yW2RXgY5AesqonmsQcuX8TU16QOqfEhBWYHR+Dl4Q==@vger.kernel.org X-Gm-Message-State: AFuF++m8t4bB8K5Yf+rL0puMLS01k85sKDnnV3AhKfUo6okB2TjQdops 85qR6jlFu52mNaIu/oSa5/RVIS+ZfXAO/GT8Q640NQfA4T9A2L9Mzvs= X-Gm-Gg: AYBFou3FXVGZ5k3GNdKKGtgLgjzZkwjNn1fAM43H59K3HRjRrJVvXDTTl7RRgMCbgKP wLaU4FC9aLpJYxZ7G4nRWkAQKplHfysL/P8eyMKwPmI9L9B5vsMCYk6cpLnAgkZ0MZkqYYYpO0k vQGRZ30iRMT94+tutlaP++xwQkMan+jKY2ZQDELN+WDuBDTYc3gTEQvB+cRcFguKw36raZD+zWB RmHFTSc/8aIlzJA2yl91wW7Qlgh6YYRT+nS2Jj68ZDdk/61BjbdJYW+W75mmhJomeGp8zTk7oeV XVHlNsa/Tx63zWF1EVkhVKIoozOvYbXa/qV9WwkCIQBiUXTS4DaUJcMgYfYScNVIEUyAKKf0caW Bl0aIXOYXuxiZBJgKwlfzE5dltwE7Y7OsESsLNYhzYfkCsC0tMUkcf0+L7Oh5LtfjBKYu7PUAnV TbWFaO6O1JgkbhtJq2TBnjGU6SexhL5c+YxxJzzC6oVUftVwxmvoXV5ZOUftKxvHf5wUQQ1Y+8I 60Z1WmL+j6fBUB/u12399d+O4Rv23mtMQTpMigZCGv2VTFddZ8NrOGspneAksyC27fQ4kK22tYG GlPZak9ISnj8LFxQwUBRIVBFsQb5 X-Received: by 2002:a05:620a:4045:b0:93b:cb64:25a5 with SMTP id af79cd13be357-93c43c28e52mr647745785a.12.1790363817360; Fri, 25 Sep 2026 12:16:57 -0700 (PDT) Received: from i4-gl-tmk5904-1.ad.psu.edu ([130.203.156.90]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-914309a24c4sm24142666d6.6.2026.09.25.12.16.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 12:16:56 -0700 (PDT) From: Myeonghun Pak To: Vikash Garodia , Dikshita Agarwal Cc: Myeonghun Pak , Bryan O'Donoghue , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sashiko , stable@vger.kernel.org, Ijae Kim Subject: [PATCH v3 1/2] media: venus: hfi: disable IRQ before freeing HFI device Date: Fri, 25 Sep 2026 15:16:52 -0400 Message-ID: <20260925191653.3144006-2-mhun512@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260925191653.3144006-1-mhun512@gmail.com> References: <20260925191653.3144006-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit venus_hfi_destroy() releases the interface queues and frees hdev before calling disable_irq(). An IRQ handler that has already read core->priv can continue to access hdev and its queues after they are freed. Clearing core->priv does not revoke the handler's local pointer. Commit 640803003cd9 ("media: venus: hfi: explicitly release IRQ during teardown") added disable_irq(), but placed it after kfree(hdev), too late to protect a handler already using hdev. Disable the IRQ first so that both the hard IRQ and threaded handler have completed before clearing core->priv or releasing hdev. Fixes: d96d3f30c0f2 ("[media] media: venus: hfi: add Venus HFI files") Reported-by: Sashiko Closes: https://lore.kernel.org/all/20260612103333.5585D1F000E9@smtp.kernel.org/ Cc: stable@vger.kernel.org Assisted-by: LLM Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/media/platform/qcom/venus/hfi_venus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c index bd82066bb6e7..e7e4e78a186a 100644 --- a/drivers/media/platform/qcom/venus/hfi_venus.c +++ b/drivers/media/platform/qcom/venus/hfi_venus.c @@ -1689,11 +1689,11 @@ void venus_hfi_destroy(struct venus_core *core) { struct venus_hfi_device *hdev = to_hfi_priv(core); + disable_irq(core->irq); core->priv = NULL; venus_interface_queues_release(hdev); mutex_destroy(&hdev->lock); kfree(hdev); - disable_irq(core->irq); core->ops = NULL; } -- 2.53.0