From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy2-f9.google.com (mail-dy2-f9.google.com [74.125.229.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E63C9286A4 for ; Sat, 26 Sep 2026 08:43:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790412211; cv=none; b=K4oVNSxswpLsOD0k7TyoTSTwMVmU8RC5ig0yQLFFSgBEVpohsEKZgn9bt3pciArEsv/ImPXUtVp3sdLdL5ZFmHbyJA3L6XaaSKckRFekzrJUNSVU+CDLBU/A3bQOcdcR1Mipj+k0Kavzvf5dCk5a0JORtuRkF4O+KMgvOsokyPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790412211; c=relaxed/simple; bh=FXZ/O9NxkMPrU9h+reZfFy89Tqxxb60b+xqI2ZJbDKw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Pxqv93glthR8Z/UqG4PtP/EveRGjTFURQHjy8f3N81EH2NLiDDAgZtVmjGAdYlb9kpgak3K4inzsKS/FnSTCOwKKc8VTmX7meqqO+TLqifjqkj1eUqSUtvIkAOfA1xthgcMBHPfa8TfAJ5dGqCkm+LxihjG2lnDjNDg5tNHwmDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sLt5gyoP; arc=none smtp.client-ip=74.125.229.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sLt5gyoP" Received: by mail-dy2-f9.google.com with SMTP id 5a478bee46e88-32ee2d032f8so487228eec.1 for ; Sat, 26 Sep 2026 01:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790412209; x=1791017009; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yjxGTnd2mKbbrlmpZXTSuvBmHY+YigrHR6jMxFwo5ms=; b=sLt5gyoPv7Iwgw7Qc2IIUh+/AXu33GpkrRb6iVoodfs3zlX+1RWj9u72g8RThtvsTN XXVSiCcIg7N7UizidnD0qBDn4ZNJ8XSPFYubSu0cHFW9RmmhpjsuB0h9bWzctovxgMG9 39hCjTMeq0BpluKkPrKl3Xis5GS/+L56aZjtX7wUQL1R/jA0TvFG4X3lfEdg6OrYq+dO qOmRXIImykzPDI2AhGWIQbPWWvwyCUKcnBXCMNgqyoVdhbXMR1zNfrZ9C7MYUshwCyyW 13jAcENpYxLPMzvl6RaKjIe1e//kvOQjJ2Tv3hX1SMmmFNW3RxlpDRKpaEVGrPTnJCtT J9zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790412209; x=1791017009; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yjxGTnd2mKbbrlmpZXTSuvBmHY+YigrHR6jMxFwo5ms=; b=GCTBgeeZ09Edi49yUiQRGnrITak5Q4RLTqQOvvep7HVoa8AW5ATYER6z3XdFMl1KHs hNDyB0FjVF78j+aUK5nsfcPBL3MQESdmTVlOzBo4kvcnI8bBZXTknL9YOlz2hic7R80Q 8Ct49kAVYyVqr9ZZ/lvsk8w/dRnAEamnhoWL0eYRN+f7xGEcGdKl2DTeElN0Jd7A41Y+ FdUmGNT6qEbLxVEtl66RupaJFVzmIMmJ96HRfNvnEpZQFpsWbtxnR/ciWB8xeMLigylo BlZUxR9eZEuz7rkJJdw63pyQS2ju6R0KRK0OuMeA9JL4PTTclT55mw3PChfnbOzDSf6T LHgQ== X-Gm-Message-State: AFuF++mUVO6vefwvEUsXgq0mgEnzfqmueoVxltQHdgfJsyeVCbsDjWxK 1/kbP5CsPTS5WvC8iB81N8AFzAvLGAJFfRSfa0Q+FVmUPtjnDK/edRcE X-Gm-Gg: AYBFou2v20UD9esfain6/qG0kcSqzTXOFUU+mGTAoYnjPXSWTxYFAIr6po9EehwhJv4 IkDg8/RIuhg8NDRLfW3ljZea8bc1G6QF/Zim+35gLI+gbreHUkuD3Fh8UvwinOcPV0GcdUWus56 kFInsmX5gq3krca4hmx0k4PNPQnZESmvLBaiVSeSXD64+h+/rtaOq5o1DPZdlxfU1Th/YtxPXAH IxEuHB42jbGS3exOIyOillcVQChs9DOdWriK0XwHXmUr4hS/Cp603AKVubYMZQ3VHfcGZXrHcdj PVhW7XiHjW9t/en6MREItlqtcqmHyMUrxs1fSyFw+Qcpf2rGeuXc617WG5tNQl+2uHKhiAt9+Ai y4E+5z8cfZLIFvj6mRP/qzgYJumJBpqNx+C/DpfTzD1ubHblbsFEzug9MPAncznhI3xxK8TAPmE DZ/PkTZXOdihztqb7951c8hoP+SILIzI/vFUnpwN2lz9vAiyVchaKrF3ybd3S82c8T0nIWSV00A AiOGIP8OvXI65xFl7oZuxqPFtYQJUNoBrFsnEnKao24zqAeRUj8IGQ= X-Received: by 2002:a05:7301:f10:b0:33b:c69b:7074 with SMTP id 5a478bee46e88-342700be120mr2225602eec.4.1790412208861; Sat, 26 Sep 2026 01:43:28 -0700 (PDT) Received: from Raccoon ([157.51.160.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3421dbb2971sm8463086eec.10.2026.09.26.01.43.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Sep 2026 01:43:28 -0700 (PDT) From: Rohinthan P To: hverkuil@kernel.org, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+caaca441bae2799984d3@syzkaller.appspotmail.com Subject: [PATCH v2] media: vivid: check for NULL dev in vivid_probe() control setup Date: Sat, 26 Sep 2026 14:13:18 +0530 Message-ID: <20260926084318.12161-1-rokinthanp03@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260922125434.19361-1-rokinthanp03@gmail.com> References: <20260922125434.19361-1-rokinthanp03@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In vivid_probe(), after creating instances, the driver iterates through vivid_devs[0..n_devs-1] to populate HDMI and S-Video 'Connected To' controls. However, it dereferences dev->has_vid_out without verifying that dev is non-NULL. If an instance fails during creation, vivid_devs[i] remains NULL, causing a general protection fault: Oops: general protection fault KASAN: probably user-memory-access in range [0x0000000000005f38-0x0000000000005f3f] RIP: 0010:vivid_probe+0x579/0x10d0 Add NULL pointer checks in both loops in vivid_probe() before accessing vivid_devs[i]. Fixes: d7c969f37515 ("media: vivid: Add 'Is Connected To' menu controls") Reported-by: syzbot+caaca441bae2799984d3@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=caaca441bae2799984d3 Signed-off-by: Rohinthan P --- Changes in v2: - Remove .suppress_bind_attrs = true so driver bind/unbind via sysfs remains supported as required by the test-media test suite. - Update author name to "Rohinthan P". drivers/media/test-drivers/vivid/vivid-core.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/media/test-drivers/vivid/vivid-core.c b/drivers/media/test-drivers/vivid/vivid-core.c index 62cfb5f..1860ad6 100644 --- a/drivers/media/test-drivers/vivid/vivid-core.c +++ b/drivers/media/test-drivers/vivid/vivid-core.c @@ -2116,17 +2116,19 @@ static int vivid_probe(struct platform_device *pdev) for (int i = 0; i < n_devs; i++) { struct vivid_dev *dev = vivid_devs[i]; + if (!dev) + continue; if (!dev->has_vid_out) continue; for (int j = 0; j < dev->num_outputs && hdmi_count < MAX_MENU_ITEMS; ++j) { if (dev->output_type[j] == HDMI) { - vivid_ctrl_hdmi_to_output_instance[hdmi_count] = vivid_devs[i]; + vivid_ctrl_hdmi_to_output_instance[hdmi_count] = dev; vivid_ctrl_hdmi_to_output_index[hdmi_count++] = j; } } for (int j = 0; j < dev->num_outputs && svid_count < MAX_MENU_ITEMS; ++j) { if (dev->output_type[j] == SVID) { - vivid_ctrl_svid_to_output_instance[svid_count] = vivid_devs[i]; + vivid_ctrl_svid_to_output_instance[svid_count] = dev; vivid_ctrl_svid_to_output_index[svid_count++] = j; } } @@ -2134,13 +2136,17 @@ static int vivid_probe(struct platform_device *pdev) hdmi_count = min(hdmi_count, MAX_MENU_ITEMS); svid_count = min(svid_count, MAX_MENU_ITEMS); for (int i = 0; i < n_devs; i++) { - for (int j = 0; j < vivid_devs[i]->num_hdmi_inputs; j++) { - struct v4l2_ctrl *c = vivid_devs[i]->ctrl_hdmi_to_output[j]; + struct vivid_dev *dev = vivid_devs[i]; + + if (!dev) + continue; + for (int j = 0; j < dev->num_hdmi_inputs; j++) { + struct v4l2_ctrl *c = dev->ctrl_hdmi_to_output[j]; v4l2_ctrl_modify_range(c, c->minimum, hdmi_count - 1, 0, c->default_value); } - for (int j = 0; j < vivid_devs[i]->num_svid_inputs; j++) { - struct v4l2_ctrl *c = vivid_devs[i]->ctrl_svid_to_output[j]; + for (int j = 0; j < dev->num_svid_inputs; j++) { + struct v4l2_ctrl *c = dev->ctrl_svid_to_output[j]; v4l2_ctrl_modify_range(c, c->minimum, svid_count - 1, 0, c->default_value); } -- 2.53.0