From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl,
Prabhakar <prabhakar.csengg@gmail.com>,
"Kate Hsuan" <hpa@redhat.com>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Tommaso Merciai" <tomm.merciai@gmail.com>,
"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
"Sylvain Petinot" <sylvain.petinot@foss.st.com>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Julien Massot" <julien.massot@collabora.com>,
"Naushir Patuck" <naush@raspberrypi.com>,
"Yan, Dongcheng" <dongcheng.yan@intel.com>,
"Stefan Klug" <stefan.klug@ideasonboard.com>,
"Mirela Rabulea" <mirela.rabulea@nxp.com>,
"André Apitzsch" <git@apitzsch.eu>,
"Heimir Thor Sverrisson" <heimir.sverrisson@gmail.com>,
"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
"Mehdi Djait" <mehdi.djait@linux.intel.com>,
"Ricardo Ribalda Delgado" <ribalda@kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
"Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"David Plowman" <david.plowman@raspberrypi.com>,
"Yu, Ong Hock" <ong.hock.yu@intel.com>,
"Ng, Khai Wen" <khai.wen.ng@intel.com>,
"Jai Luthra" <jai.luthra@ideasonboard.com>,
"Rishikesh Donadkar" <r-donadkar@ti.com>,
"Mattijs Korpershoek" <mkorpershoek@kernel.org>,
"Antti Laakso" <antti.laakso@linux.intel.com>,
"Dumitru Ceclan" <dumitru.ceclan@analog.com>,
"Martin Hecht" <Martin.Hecht@avnet.eu>,
"Andrian Suciu" <Adrian.Suciu@analog.com>,
"Martin Hecht" <mhecht73@gmail.com>,
"Cosmin Tanislav" <demonsingur@gmail.com>,
"Vivekananda Dayananda" <vivekana@amd.com>,
"Quentin Freimanis" <quentin@q-lab.dev>,
"Cory Keitz" <ckeitz@amazon.com>
Subject: Re: [PATCH 1/2] media: mc: Keep INTERNAL pad flags just for the kernel, for now
Date: Wed, 7 Oct 2026 23:18:58 +0200 [thread overview]
Message-ID: <20261007211858.GB664854@killaraus.ideasonboard.com> (raw)
In-Reply-To: <20261007204135.782415-2-sakari.ailus@linux.intel.com>
On Wed, Oct 07, 2026 at 11:41:34PM +0300, Sakari Ailus wrote:
> Do not expose INTERNAL pads on UAPI as the documentation nor
s/as the/as neither the/
> v4l2-compliance changes to support MEDIA_PAD_FL_INTERNAL pads has not yet
> been merged.
"have been merged yet"
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> include/uapi/linux/media.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
> index 80cfd12a43fc..63e69a517987 100644
> --- a/include/uapi/linux/media.h
> +++ b/include/uapi/linux/media.h
> @@ -208,7 +208,13 @@ struct media_entity_desc {
> #define MEDIA_PAD_FL_SINK (1U << 0)
> #define MEDIA_PAD_FL_SOURCE (1U << 1)
> #define MEDIA_PAD_FL_MUST_CONNECT (1U << 2)
> +#if defined(__KERNEL__)
> +/*
> + * Forgo INTERNAL pads until proper documentation and v4l2-compliance testing is
s/is$/are/
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + * merged.
> + */
> #define MEDIA_PAD_FL_INTERNAL (1U << 3)
> +#endif /* __KERNEL__ */
>
> struct media_pad_desc {
> __u32 entity; /* entity ID */
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2026-10-07 21:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 20:41 [PATCH 0/2] Keep MEDIA_PAD_FL_INTERNAL for kernel only, for now Sakari Ailus
2026-10-07 20:41 ` [PATCH 1/2] media: mc: Keep INTERNAL pad flags just for the kernel, " Sakari Ailus
2026-10-07 21:18 ` Laurent Pinchart [this message]
2026-10-08 6:52 ` Hans Verkuil
2026-10-07 20:41 ` [PATCH 2/2] media: maxim-serdes: Disable test pattern generator " Sakari Ailus
2026-10-08 6:58 ` Hans Verkuil
2026-10-08 7:51 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007211858.GB664854@killaraus.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=Adrian.Suciu@analog.com \
--cc=Martin.Hecht@avnet.eu \
--cc=antti.laakso@linux.intel.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=ckeitz@amazon.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=david.plowman@raspberrypi.com \
--cc=demonsingur@gmail.com \
--cc=dongcheng.yan@intel.com \
--cc=dumitru.ceclan@analog.com \
--cc=git@apitzsch.eu \
--cc=hans@jjverkuil.nl \
--cc=hansg@kernel.org \
--cc=heimir.sverrisson@gmail.com \
--cc=hpa@redhat.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jai.luthra@ideasonboard.com \
--cc=julien.massot@collabora.com \
--cc=khai.wen.ng@intel.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=mhecht73@gmail.com \
--cc=mirela.rabulea@nxp.com \
--cc=mkorpershoek@kernel.org \
--cc=naush@raspberrypi.com \
--cc=ong.hock.yu@intel.com \
--cc=prabhakar.csengg@gmail.com \
--cc=quentin@q-lab.dev \
--cc=r-donadkar@ti.com \
--cc=ribalda@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stefan.klug@ideasonboard.com \
--cc=sylvain.petinot@foss.st.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tomm.merciai@gmail.com \
--cc=vivekana@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox