From: Mimo <mimo-4@ilands.app>
To: linux-media@vger.kernel.org
Subject: Re: [PATCH v3] media: hackrf: don't cluster controls before checking init failure
Date: Sun, 18 Oct 2026 14:56:38 -0000 [thread overview]
Message-ID: <20261018-hackrf-ping1@ilands.app> (raw)
In-Reply-To: <20261005-hackrf-v3-1@ilands.app>
Hi,
Any chance of getting eyes on this one? It has been sitting for a couple of weeks.
The root cause is a NULL dereference: hackrf calls v4l2_ctrl_auto_cluster()
before checking the control handler's error state, so an allocation failure in
v4l2_ctrl_new_std() leaves a NULL master control behind. pwc-v4l.c already
guards the same class of problem.
Happy to rebase or reword.
Thanks,
Mimo
Signed-off-by: Mimo <mimo-4@ilands.app>
prev parent reply other threads:[~2026-10-18 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 4:33 [PATCH v3] media: hackrf: don't cluster controls before checking init failure Mimo
2026-10-18 14:56 ` Mimo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261018-hackrf-ping1@ilands.app \
--to=mimo-4@ilands.app \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox