From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=103.168.172.156 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792503888; b=5kTO6IOhc6FKWbwugPSaNO1DjKFARDdp/v8zRRRTgKaZ2uYqtX3Zot1gYJd3EDrGiRHc heqhV5Pb63YhdAU/RK1gZpiBRnFVil5p/T8RbYst1GXx8BwSn24yzDa79q0Auhfg6JhmE 1o/HGrFubEr8LNvVdgWTgh3XVgekyBniyiBJL1jb50v0osUbZ5wlxT1W88MHD7IcLFvzS noWtZfAAT1EniumpgoHS2MF1uC1Wn9tt890QAi75VCErxaT47EhCuiSlG03PQHtgofwkl j+mfOW18TpRRhYTXumlLmnVzAf77bOaoprawPVKOk9eRo/lQkVq7GPEma9AMWtwcjaA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792503888; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Received:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=7sFqYPku9IMCaAgjb1BHGg9OMs1Jn2kXfjeeNqqIfW4=; b=QgwilKoGuMhPpA2H6yMvasjpLs5UTla9owifLWNlgzx8YECdMv/0mdwcOrpULmTd2EF+ gxHFU6sYIvcdHIZZQSyk8FgUIDMHtIEx5bI14PvN6MPxsTe0ngn2xe8vRNv/7/4xKxacZ ewRQusbPtGo9oknuTOcGPaj0SSo5PY71fC2f5jA3tSVXHFG2Lzpn1CZfXLoEKM5qAV8CG J93a8WzJugyiS3cXCohK99zd3Ens22hyGX4hdH0OzsWQF/dcmtZTw83e4W/yu0xtuOgxE ECV4XXbDxMs8X3XCOZeCnVDBCf/RVcJP5Pz/ujqefPTuBK4ic97cijt+Bn3o1mEnbKA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=ragnatech.se; spf=pass smtp.mailfrom=ragnatech.se; dkim=pass header.d=ragnatech.se header.i=@ragnatech.se header.a=rsa-sha256 header.s=fm1 header.b=Azw65VhM; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=o7Ae6oBD; arc=none smtp.remote-ip=103.168.172.156 Received: from fhigh-a5-smtp.messagingengine.com (fhigh-a5-smtp.messagingengine.com [103.168.172.156]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64E05606A327 for ; Tue, 20 Oct 2026 13:44:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 64E05606A327 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=ragnatech.se header.i=@ragnatech.se header.a=rsa-sha256 header.s=fm1 header.b=Azw65VhM; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=o7Ae6oBD Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id C553A1400127 for ; Tue, 20 Oct 2026 09:44:47 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Tue, 20 Oct 2026 09:44:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1792503887; x=1792590287; bh=7sFqYPku9IMCaAgjb1BHGg9OMs1Jn2kXfjeeNqqIfW4=; b= Azw65VhMY29Q5fqTJy/B/ERFesM94CIXQfuf1QNF+KlAe3GVPs4G4H1d+m/72BSu rNpUylzVIpHuLZxHy6jLsI90mSWwX9PjWKcbo8ta/P/k3Gl8cNqJPBqcq6MpzKpz Z8NbTUir+JU2o7WX6/oyJCGSW1tywCsLSW/vCL+He6wWSEqYpeBiKvXsuEjzZU56 QejeR/yTBML1obHIWWNffMI3yXhDpJjUkpf7MzxPSHG6bPvi4k0YqJg4VYD5p/Zm wyZVnpU2yFid2HLovNiQep0oCRfS+Z4t/VFXnYqsEDKl235QN+0oTfuLghC+KA7u nI4iP5fXaQahnkJ6ByvRPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1792503887; x= 1792590287; bh=7sFqYPku9IMCaAgjb1BHGg9OMs1Jn2kXfjeeNqqIfW4=; b=o 7Ae6oBDo74Z8A56wSzQSlQ11NhVK3ZiU+yRe8GIpSuktQvXGQzfWVwT9DzDXbfgP xfDnCNPPHyvJu1NeFRcZzM/GpbffW5X7FT0ymYE2GLDAMBo19t+tgVzyZ10tVCfD egDBHZPrrwfI2It4OHDnYs8JrBKrU79bSBOfx/Mg6v25sFN+AJmztw+WBKiftigb p/8rEConEfTgogo3R2iu/S7yVnaTQFGFPe9hZy8XhMx+IGjwAT9TektwbBrJZs36 eIxaP9FYT7mhaVdRC9eBw23k56Mai1LaTSLTz5bjw9xaVz7KRLa3B8YkgiLWK/pS JKC0Y0Jgdxl9fBUbmOo3Q== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-10-08; sw=lmtpprox; action=sign d=ragnatech.se a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1792503887; d=ragnatech.se; mf=PG5pa2xhcy5zb2Rlcmx1bmQrcmVuZXNhc0ByYWduYXRlY2guc2U+; rt=PGxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZz4=; s=fm1:rsa-sha256:KLM0NL8l9ZE9Bl2L396Fi2bk1zh4zciGXmuc+4pdoi2XzbK t3u0oy0wdgQv4gY4Nq0J97uaYa8U9Q7npnZuoGMJlFZ51VzgE1c0m72PLYbbuLAE 5McBNMyQ29uTiQS6Ryk6/CvfIAsafn/0bw++d+kLQ2cr0JQINHlX6ETAixG1qVnz vuWNab76TBmxExYjvNkJmqfLmZgVmuSN5apbvhwfrkjRrI7OzOWTAALV4PypnywT pcj/cVQ1durilDix0cxgzximRFhJp7MQxk3jUbpuwR4/PS2+jsKV5wPWKswUFmmp 1nYWnM0KgN11QqqpmsAUmEbAnE4c7L//8ppCMhg==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-10-08; sw=lmtpprox; action=mi-m=1; hc=13; hn=cc,content-disposition,content-transfer-encoding, content-type,date,feedback-id,from,in-reply-to,message-id, mime-version,references,subject,to; Message-Instance: m=1; h=sha256:IeknNZlS48ZgPlaDg9w+WYE+IXDLDzMZ8dlg4l8Q0UQ=:SBzfYmoygIRTYjuunMl4N8cUIjWvhkSILabDTFdYnZU=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFIg3lKdUyp26TRMc44J7IZ/m5v61+2X4w0llVDhQsWoMpOuaqnFv8z1H3n3YbuMg 4j2P5cQ3PYMTvpNF0s0HI1l9d7YYvvBWLG0M2jdVqikgQjqckR1pyaijHJjLG5ZBv5dm8Q DM86YskcEFVqyu5+GkXcLICIUi5UOFPXGubhBMhSzrJPYfXBkwDHpF0U15QNP//kE6VGII s1SNFLszlrytpJHzmCi/7CTXOcWjhbbzPd5N58vaPmwpVy19NuIbeolNhWHRmZdjANLCmn 39oBAtVxXqF7fHSKOJzhp0it+Uuja9Mhj+mZF+1GX3Bhy/bkyt4NNkPyOKEufgvIg59qrr JlL1o2Zi1MRP1EXMZ7zJmQ+Ea9oISlEIB5tvRHE9wav0CkxE4e4Ax6Sayv79hGk2y0ivlI Yc5TFwaolnno239jDwTbarIk+5LzD6gEoLzZFqu6ypdCdgp010Y6xqO+/7Qgj7btJRuNnk Xq2YWwGqF7wGTfSumHnc94wvbjxhotlZT0txDpTjJv/HMof5zPfAZPyXmV6jHUnH2h/JqA +h6/PFhuaFLlxnQgbYjJNyW3/wPfyGK+ZVAYcLB+wmhp1PeUVGgJrAQaZc5x3sR5BUj+av ba1ujUUuQH7qe98Mw0XiuOPKmJ8j4Fu9PLIPxrPlxe+Fi9PtfbyzHOf5uFAg X-ME-Proxy: Feedback-ID: i80c9496c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Oct 2026 09:44:46 -0400 (EDT) Date: Tue, 20 Oct 2026 15:44:44 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Cc: Jacopo Mondi , Jai Luthra , Mauro Carvalho Chehab , Geert Uytterhoeven , Magnus Damm , =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= , Yusuke Goda , Yuya Hamamachi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 1/4] media: rcar-isp: ispcore: Honour requested bytesperline on RAW input Message-ID: <20261020134444.GC1172387@ragnatech.se> References: <20261019-v4l2-add-nv12-v1-0-4a84736803b6@ragnatech.se> <20261019-v4l2-add-nv12-v1-1-4a84736803b6@ragnatech.se> <6c8e77c9-c0a2-40c6-8e7f-7e2d51c71740@ideasonboard.com> X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6c8e77c9-c0a2-40c6-8e7f-7e2d51c71740@ideasonboard.com> Hi Barnabás, Thanks for your review. On 2026-10-20 11:36:04 +0200, Barnabás Pőcze wrote: > Hi > > 2026. 10. 19. 21:35 keltezéssel, Niklas Söderlund írta: > > From: Yuya Hamamachi > > > > The RAW input video device always overwrote the bytesperline requested > > by userspace with width * bpp. The input buffers are however shared with > > the VIN, which may use a larger line stride (for example 3296 instead of > > 3280 bytes for a 1640 pixel wide 10 bit image). The dmabuf exported by > > the ISP was then smaller than the VIN buffer size, and queueing it to > > the VIN failed with -EINVAL: > > > > __prepare_dmabuf: invalid dmabuf length 4042752 for plane 0, > > minimum length 4060672 > > > > Use the requested bytesperline if it is larger than the minimum. > > > > Signed-off-by: Yuya Hamamachi > > [Niklas: Use max(min(..)) instead of if statement] > > Signed-off-by: Niklas Söderlund > > --- > > drivers/media/platform/renesas/rcar-isp/core-io.c | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/media/platform/renesas/rcar-isp/core-io.c b/drivers/media/platform/renesas/rcar-isp/core-io.c > > index b60b91f43d42..badde72352c1 100644 > > --- a/drivers/media/platform/renesas/rcar-isp/core-io.c > > +++ b/drivers/media/platform/renesas/rcar-isp/core-io.c > > @@ -5,6 +5,8 @@ > > * Copyright (C) 2026 Ragnatech AB > > */ > > +#include > > + > > #include > > #include > > #include > > @@ -335,6 +337,7 @@ static void risp_io_input_try_format(struct rcar_isp_core_io *io, > > struct v4l2_pix_format_mplane *pix) > > { > > unsigned int bpp = 0; > > + unsigned int bpl; > > v4l_bound_align_image(&pix->width, RISP_MIN_WIDTH, RISP_MAX_WIDTH, RISP_SIZE_ALIGNMENT, > > &pix->height, RISP_MIN_HEIGHT, RISP_MAX_HEIGHT, RISP_SIZE_ALIGNMENT, > > @@ -352,11 +355,17 @@ static void risp_io_input_try_format(struct rcar_isp_core_io *io, > > bpp = risp_io_input_formats[0].bpp; > > } > > + /* > > + * Honour the line stride requested by userspace, the buffers are > > + * shared with the VIN which may use a larger stride than the minimum. > > + */ > > + bpl = max(pix->width * bpp, min(pix->plane_fmt[0].bytesperline, SZ_64K)); > > clamp(pix->plane_fmt[0].bytesperline, pix->width * bpp, SZ_64K) Good idea. > > ? > > And does the device really accept any value between these two limits? The stride register where this is programmed is 16 bit wide. > > > > + > > pix->field = V4L2_FIELD_NONE; > > pix->colorspace = V4L2_COLORSPACE_RAW; > > pix->num_planes = 1; > > - pix->plane_fmt[0].bytesperline = pix->width * bpp; > > + pix->plane_fmt[0].bytesperline = bpl; > > pix->plane_fmt[0].sizeimage = pix->plane_fmt[0].bytesperline * pix->height; > > } > > > -- Kind Regards, Niklas Söderlund