Linux Media Controller development
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: "Pavel Begunkov" <asml.silence@gmail.com>,
	"David Wei" <dw@davidwei.uk>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	"Taehee Yoo" <ap420073@gmail.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Kaiyuan Zhang" <kaiyuanz@google.com>,
	"Bobby Eshleman" <bobbyeshleman@meta.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@kernel.org>,
	"Jesper Dangaard Brouer" <hawk@kernel.org>,
	"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
	"Simon Horman" <horms@kernel.org>,
	"Shuah Khan" <shuah@kernel.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Dragos Tatulea" <dtatulea@nvidia.com>,
	"Nikolay Aleksandrov" <razor@blackwall.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Tariq Toukan" <tariqt@nvidia.com>,
	"Kaifeng Wang" <kaifengw@google.com>
Subject: Re: [PATCH net v4 3/4] netdevsim: support devmem RX and TX bindings
Date: Thu, 22 Oct 2026 18:19:11 -0700	[thread overview]
Message-ID: <20261022181911.5d19ff13@kernel.org> (raw)
In-Reply-To: <CAHS8izN_N25mm9vALax+P+W45gyxVoMbZoTXW3r6nPC2Z0A7JQ@mail.gmail.com>

On Thu, 22 Oct 2026 08:41:43 -0700 Mina Almasry wrote:
> On Wed, Oct 21, 2026 at 1:23 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > On Tue, 20 Oct 2026 23:17:34 -0700 Mina Almasry wrote:  
> > > But on the other hand the test coverage is nice, and maybe one day if
> > > we add enough devmem support in netdevsim we'll be able to fuzz the
> > > data path or something. Is there a way to get the best of both worlds?
> > > Like put a comment on top of netdevsim that this is test simulator
> > > device and any missing functionality and/or bugs in it should be
> > > medium criticality max or something? Or is it too much trouble and I
> > > should drop the netdevsim support and tests?  
> >
> > I already strip Fixes tags and apply the patches to net-next.
> > But it's still a burden. If you're signing up to fix the issues /
> > review the slop we can try.  
> 
> I'm more than happy to help but I'm not sure what you have
> specifically in mind. What I was going to do is put a comment/readme
> in drivers/net/netdevsim with a note to sashiko and LLMs, "this is a
> netdev simulator, used for testing; do not call out missing or
> incomplete functionality as bugs." And then hope that the LLMs and
> sashiko pick the directive. If not, I can tell patch submitters to
> ignore sashiko code review bug findings in netdevsim. Is that
> sufficient, or do you need something else from me?

No, the fact that it's a test harness only impacts whether fixes
got to net & stable, not whether bugs need to be fixed.
I was expecting you to keep an eye on the list and review any fixes
that come, basically.

> And we can always revert the added devmem supprot in netdev sim if it
> becomes an issue.

Right.

  reply	other threads:[~2026-10-23  1:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 16:39 [PATCH net v4 0/4] net: devmem: fix RX and TX binding teardown on device unregistration Mina Almasry
2026-10-15 16:39 ` [PATCH net v4 1/4] net: devmem: unmap dma_buf synchronously on queue uninstall Mina Almasry
2026-10-15 21:34   ` Stanislav Fomichev
2026-10-18 16:01   ` netdev-bot+sashiko
2026-10-15 16:39 ` [PATCH net v4 2/4] net: devmem: detach TX bindings on NETDEV_UNREGISTER Mina Almasry
2026-10-15 21:34   ` Stanislav Fomichev
2026-10-18 16:01   ` netdev-bot+sashiko
2026-10-15 16:39 ` [PATCH net v4 3/4] netdevsim: support devmem RX and TX bindings Mina Almasry
2026-10-15 21:34   ` Stanislav Fomichev
2026-10-18 16:01   ` netdev-bot+sashiko
2026-10-19 16:10     ` Mina Almasry
2026-10-20 19:18   ` Jakub Kicinski
2026-10-21  6:17     ` Mina Almasry
2026-10-21 20:23       ` Jakub Kicinski
2026-10-22 15:41         ` Mina Almasry
2026-10-23  1:19           ` Jakub Kicinski [this message]
2026-10-15 16:39 ` [PATCH net v4 4/4] selftests: net: add devmem RX and TX netdev unregister tests Mina Almasry
2026-10-15 21:34   ` Stanislav Fomichev
2026-10-20 19:16 ` [PATCH net v4 0/4] net: devmem: fix RX and TX binding teardown on device unregistration Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261022181911.5d19ff13@kernel.org \
    --to=kuba@kernel.org \
    --cc=almasrymina@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=ap420073@gmail.com \
    --cc=asml.silence@gmail.com \
    --cc=bobbyeshleman@meta.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dtatulea@nvidia.com \
    --cc=dw@davidwei.uk \
    --cc=edumazet@kernel.org \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=kaifengw@google.com \
    --cc=kaiyuanz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox